Xuanwo opened a new issue, #1676:
URL: https://github.com/apache/incubator-fury/issues/1676

   ## Is your feature request related to a problem? Please describe.
   
   Our current rust naming doesn't fit well with most rust projects.
   
   
https://github.com/apache/incubator-fury/blob/31d37f9cf2021899f3dc2f1b06d5b45e79099251/rust/fury/src/types.rs#L156-L183
   
   Clippy will complain about:
   
   ```shell
   error: name `JAVASCRIPT` contains a capitalized acronym
      --> fury/src/types.rs:254:5
       |
   254 |     JAVASCRIPT = 5,
       |     ^^^^^^^^^^ help: consider making the acronym lowercase, except the 
initial letter: `Javascript`
       |
       = help: for further information visit 
https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
   ```
   
   Do those names align with our protocol? Can we change them for better 
clarity?
   
   ## Describe the solution you'd like
   
   Update enums to make rust clippy happy.
   
   ## Additional context
   
   None.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to