LiangliangSui commented on PR #1686: URL: https://github.com/apache/fury/pull/1686#issuecomment-2185563555
I don't think it's necessary. Reading `classDefOffset` and reading `numClassDefs` should be what `readClassDefs` should do. We shouldn't distribute what `readClassDefs` should do to other functions. Why would we do this? Just to move `Constants.INVALID_OFFSITE` to `Fury`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
