chaokunyang commented on code in PR #1701:
URL: https://github.com/apache/fury/pull/1701#discussion_r1670445481
##########
java/fury-core/src/main/java/org/apache/fury/serializer/ObjectSerializer.java:
##########
@@ -228,6 +229,65 @@ public void write(MemoryBuffer buffer, T value) {
writeContainerFields(buffer, value, fury, refResolver, classResolver);
}
+ @Override
+ public T copy(T originObj) {
+ if (isRecord) {
+ return originObj;
Review Comment:
fields of Record may be mutable, we should not skip its update unless we can
ensure all fields are immutable types. And if all fields value are immutable,
and fields are final, we can take it as immutable even if it's not record
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
