theweipeng commented on code in PR #1675: URL: https://github.com/apache/fury/pull/1675#discussion_r1681103848
########## javascript/packages/fury/lib/meta/MetaString.ts: ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +export class MetaString { + // Encode function that handles all Unicode characters + static encode(str: string): Uint8Array { + const encoder = new TextEncoder(); Review Comment: > The TextEncoder/Decoder native functions have been removed. The main issue is not whether to use TextEncoder or not, but that you need to implement our protocol. Neither `TextEncoder` nor `atob` can meet our requirements because our protocol is private and not a simple conversion from char to numbers. () The code you submitted in (https://github.com/apache/fury/pull/1675/commits/e5a9c3acc120e73e403b6860f81c630480141094) is right. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
