theweipeng commented on code in PR #1795:
URL: https://github.com/apache/fury/pull/1795#discussion_r1707423502
##########
rust/fury-core/src/serializer/string.rs:
##########
@@ -37,8 +38,8 @@ impl Serializer for String {
Ok(context.reader.string(len as usize))
}
- fn ty() -> FieldType {
- FieldType::STRING
+ fn ty(_fury: &Fury) -> i16 {
Review Comment:
Yes. but type is a keyword, and type_id is a member of Any which is
available for every type. ty is not a good choise, Maybe we can use
fury_type_id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
