yuluo-yx commented on PR #148: URL: https://github.com/apache/fury-site/pull/148#issuecomment-2293438082
> LGTM overall, but I suggest copying all documents under `docs` into `i18n/en-us/docusaurus-plugin-content-docs` before building websites instead of commit those copied files into git repository. The document under `docs` will be overwrited by docs under `https://github.com/apache/fury/tree/main/docs`. Other parts looks good to me, although I think we should write script using python/shell instead of golang for better maintainability, but that can be left in futher PR afaik, in docusaurus, the internationalization part is actually implemented. Documents and blogs in the root directory must be a placeholder file. It is best not to have any documentation content, which may cause some unavoidable interference in internationalization. However, this is a problem I encountered when building the Spring Cloud Alibaba official website before, and I am not sure whether the new version will have an impact. I'll do some research and if it works, I'll improve this feature. I think go script is also a very good choice. It copies files concurrently very quickly. You can see its execution time from the action log. 😆 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
