chaokunyang commented on code in PR #173: URL: https://github.com/apache/fury-site/pull/173#discussion_r1732139574
########## docs/guide/java_serialization_guide.md: ########## @@ -392,15 +386,11 @@ losing any information. If metadata sharing is not enabled, the new class data will be skipped and an `NonexistentSkipClass` stub object will be returned. -## Migration +## Serialized Library Migration ### JDK migration -If you use JDK serialization before, and you can't upgrade your client and server at the same time, which is common for -online application. Fury provided an util method `org.apache.fury.serializer.JavaSerializer.serializedByJDK` to check -whether -the binary are generated by jdk serialization, you use following pattern to make exiting serialization protocol-aware, -then upgrade serialization to fury in an async rolling-up way: +If you use JDK serialization before, and you can't upgrade your client and server at the same time, which is common for online application. Fury provided an util method `org.apache.fury.serializer.JavaSerializer.serializedByJDK` to check whether the binary are generated by jdk serialization, you use following pattern to make exiting serialization protocol-aware, then upgrade serialization to fury in an async rolling-up way: Review Comment: ```suggestion If you use JDK serialization before, and you can't upgrade your client and server at the same time, which is common for online application. Fury provided an util method `org.apache.fury.serializer.JavaSerializer.serializedByJDK` to check whether the binary are generated by jdk serialization, you use following pattern to make existing serialization protocol-aware, then upgrade serialization to fury in a rolling-up way: ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
