wywen commented on PR #1886: URL: https://github.com/apache/fury/pull/1886#issuecomment-2416750294
> > writeVarUint16 > > My bad, MemoryBuffer didn't provide read/writeVarUint16 method, we can keep using read/writeVarUint32, the performance will be same Will doing a reinterpret_cast to short be more compact (kotlin toXYZ methods are `reinterpret_cast` not `static_cast` )? I tried it and it passes boundary and roundtrip tests, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
