chaokunyang commented on code in PR #1904:
URL: https://github.com/apache/fury/pull/1904#discussion_r1815402313
##########
java/fury-core/src/main/java/org/apache/fury/serializer/NonexistentClassSerializers.java:
##########
@@ -226,14 +227,21 @@ public Object read(MemoryBuffer buffer) {
public static final class NonexistentEnumClassSerializer extends Serializer {
private final NonexistentEnum[] enumConstants;
+ private final MetaStringResolver metaStringResolver;
public NonexistentEnumClassSerializer(Fury fury) {
super(fury, NonexistentEnum.class);
+ metaStringResolver = fury.getMetaStringResolver();
enumConstants = NonexistentEnum.class.getEnumConstants();
}
@Override
public Object read(MemoryBuffer buffer) {
+ if (fury.getConfig().serializeEnumByName()) {
+ metaStringResolver.readMetaStringBytes(buffer);
Review Comment:
I mean your implementation here is right, no need to change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
