chaokunyang commented on code in PR #1911:
URL: https://github.com/apache/fury/pull/1911#discussion_r1817861722
##########
java/fury-core/src/main/java/org/apache/fury/serializer/collection/ChildContainerSerializers.java:
##########
@@ -210,11 +216,14 @@ public Map newMap(MemoryBuffer buffer) {
}
@Override
- public T copy(T originMap) {
- if (objectSerializer == null) {
- objectSerializer = new ObjectSerializer<>(fury, type, false);
+ public Map newMap(Map originMap) {
Review Comment:
Why can't we just delegate copy to objectSerializer? I think we should
follow same pattern as serialization did
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
