PragmaTwice commented on code in PR #1885:
URL: https://github.com/apache/fury/pull/1885#discussion_r1883712235


##########
cpp/fury/util/logging.h:
##########
@@ -35,7 +35,7 @@ enum class FuryLogLevel {
   DEBUG = -1,
   INFO = 0,
   WARNING = 1,
-  ERROR = 2,
+  ERR = 2,

Review Comment:
   Just took a glance, and I think that maybe the Cython generated code defines 
a macro named `ERROR` and it's included before this header so that weird thing 
happens. Not familiar with related code here, maybe @penguin-wwy has ideas 
about this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to