chaokunyang commented on code in PR #2042:
URL: https://github.com/apache/fury/pull/2042#discussion_r1946027730
##########
java/pom.xml:
##########
@@ -105,6 +107,11 @@
<artifactId>janino</artifactId>
<version>${janino.version}</version>
</dependency>
+ <dependency>
Review Comment:
could we move this dependency version info into fury-extensions module? we
try to keep this pom simplistic
##########
java/pom.xml:
##########
@@ -81,6 +82,7 @@
<maven.compiler.target>1.8</maven.compiler.target>
<guava.version>32.1.2-jre</guava.version>
<janino.version>3.1.10</janino.version>
+ <zstd.version>1.5.6-9</zstd.version>
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
