chaokunyang commented on code in PR #2057:
URL: https://github.com/apache/fury/pull/2057#discussion_r1954301973
##########
java/fury-core/src/main/java/org/apache/fury/serializer/collection/AbstractMapSerializer.java:
##########
@@ -125,6 +126,32 @@ public void setValueSerializer(Serializer valueSerializer)
{
this.valueSerializer = valueSerializer;
}
+ /**
+ * this method try to eliminate the virtual function call and help JIT
inline for java String
+ * type.
+ */
+ private void tryFastSerialize(Serializer serializer, MemoryBuffer buffer,
Object value) {
Review Comment:
Could we avoid create a new method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]