This is an automated email from the ASF dual-hosted git repository.
chaokunyang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/fury.git
The following commit(s) were added to refs/heads/main by this push:
new e33a1f71 fix(java): Fix error with `MemoryBuffer::readBytesAsInt64`
when not in LITTLE_ENDIAN mode #2068 (#2069)
e33a1f71 is described below
commit e33a1f71d32d767fb62e5b7da576ccada702116b
Author: Leo <[email protected]>
AuthorDate: Tue Feb 18 15:03:50 2025 +0800
fix(java): Fix error with `MemoryBuffer::readBytesAsInt64` when not in
LITTLE_ENDIAN mode #2068 (#2069)
## What does this PR do?
Fix the issue with `MemoryBuffer::readBytesAsInt64` when the system is
not in LITTLE_ENDIAN mode.
## Related issues
- Fix #2068
## Does this PR introduce any user-facing change?
<!--
If any user-facing interface changes, please [open an
issue](https://github.com/apache/fury/issues/new/choose) describing the
need to do so and update the document if necessary.
-->
- [ ] Does this PR introduce any public API change?
- [ ] Does this PR introduce any binary protocol compatibility change?
## Benchmark
<!--
When the PR has an impact on performance (if you don't know whether the
PR will have an impact on performance, you can submit the PR first, and
if it will have impact on performance, the code reviewer will explain
it), be sure to attach a benchmark data here.
-->
---
.../src/main/java/org/apache/fury/memory/MemoryBuffer.java | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
a/java/fury-core/src/main/java/org/apache/fury/memory/MemoryBuffer.java
b/java/fury-core/src/main/java/org/apache/fury/memory/MemoryBuffer.java
index 6379b6ed..d5003e36 100644
--- a/java/fury-core/src/main/java/org/apache/fury/memory/MemoryBuffer.java
+++ b/java/fury-core/src/main/java/org/apache/fury/memory/MemoryBuffer.java
@@ -2198,10 +2198,9 @@ public final class MemoryBuffer {
int remaining = size - readerIdx;
if (remaining >= 8) {
readerIndex = readerIdx + len;
- long v =
- UNSAFE.getLong(heapMemory, address + readerIdx)
- & (0xffffffffffffffffL >>> ((8 - len) * 8));
- return LITTLE_ENDIAN ? v : Long.reverseBytes(v);
+ long v = UNSAFE.getLong(heapMemory, address + readerIdx);
+ v = (LITTLE_ENDIAN ? v : Long.reverseBytes(v)) & (0xffffffffffffffffL
>>> ((8 - len) * 8));
+ return v;
}
return slowReadBytesAsInt64(remaining, len);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
