pjfanning commented on code in PR #2102:
URL: https://github.com/apache/fury/pull/2102#discussion_r1997651808
##########
java/fury-core/src/main/java/org/apache/fury/resolver/DisallowedList.java:
##########
@@ -52,6 +61,33 @@ class DisallowedList {
}
}
+ private static String calculateSHA256(Set<String> disallowedSet) {
Review Comment:
I think this would simpler if calculated the digest of the file bytes. That
preserves the line endings so no need to add back separators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
