LouisLou2 opened a new pull request, #2108: URL: https://github.com/apache/fury/pull/2108
<!-- **Thanks for contributing to Fury.** **If this is your first time opening a PR on fury, you can refer to [CONTRIBUTING.md](https://github.com/apache/fury/blob/main/CONTRIBUTING.md).** Contribution Checklist - The **Apache Fury (incubating)** community has restrictions on the naming of pr titles. You can also find instructions in [CONTRIBUTING.md](https://github.com/apache/fury/blob/main/CONTRIBUTING.md). - Fury has a strong focus on performance. If the PR you submit will have an impact on performance, please benchmark it first and provide the benchmark result here. --> ## What does this PR do? ### Problem The struct hash calculation implementations in Java and Python are inconsistent. When `classinfo` is `None` in the Python implementation, the method returns early without updating the hash value, whereas the Java implementation continues with a default hash value of 0. ### Solution Modified the `visit_customized` method in the Python implementation to initialize `hash_value` to 0 before checking if `classinfo` is `None`, ensuring the hash computation continues regardless of the `classinfo` status. This approach aligns with the Java implementation behavior. Changes: - Initialize `hash_value` to 0 at the beginning of the method - Replace the early return with a conditional assignment to `hash_value` - Always call `_compute_field_hash` at the end of the method ### Testing Verified the fix by running the `CrossLanguageTest.java` tests that were previously failing due to this issue. The struct hash values now match between Java and Python implementations. ## Related issues - #2107 ## Does this PR introduce any user-facing change? <!-- If any user-facing interface changes, please [open an issue](https://github.com/apache/fury/issues/new/choose) describing the need to do so and update the document if necessary. --> - [ ] Does this PR introduce any public API change? - [ ] Does this PR introduce any binary protocol compatibility change? ## Benchmark <!-- When the PR has an impact on performance (if you don't know whether the PR will have an impact on performance, you can submit the PR first, and if it will have impact on performance, the code reviewer will explain it), be sure to attach a benchmark data here. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
