chaokunyang commented on code in PR #2112:
URL: https://github.com/apache/fury/pull/2112#discussion_r2008773244
##########
dart/packages/fury-core/lib/src/code_gen/analyse/impl/cons/constructor_analyzer.dart:
##########
@@ -0,0 +1,250 @@
+// ConstructorParams analyse(
+// List<ConstructorElement> cons,
+// int classId,
+// @LocationEnsure(LocationLevel.clsLevel) LocationMark locationMark,
+// ){
+// assert(locationMark.ensureClassLevel);
+// // 虽说通过ConstructorElement也可以找到对应的ClassId, 但是调用者直接提供吧
+// ConstructorElement? unnamedCons;
+// for (var consEle in cons){
+// if (consEle.name.isEmpty){
+// unnamedCons = consEle;
+// break;
+// }
+// }
+// if (unnamedCons == null){
+// throw FuryGenExcep.noUnamedConstructor(locationMark.libPath,
locationMark.clsName);
+// }
Review Comment:
Maybe use english comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
