chaokunyang commented on code in PR #2112: URL: https://github.com/apache/fury/pull/2112#discussion_r2010424069
########## dart/packages/fury/lib/src/serializer/other_core/string_serializer.dart: ########## @@ -0,0 +1,96 @@ +import 'dart:typed_data'; +import 'package:fury/src/config/fury_config.dart'; +import 'package:fury/src/const/obj_type.dart'; +import 'package:fury/src/deserializer_pack.dart'; +import 'package:fury/src/exception/deserialization_exception.dart'; +import 'package:fury/src/memory/byte_reader.dart'; +import 'package:fury/src/memory/byte_writer.dart'; +import 'package:fury/src/serializer/serializer.dart'; +import 'package:fury/src/serializer/serializer_cache.dart'; +import 'package:fury/src/serializer_pack.dart'; +import 'package:fury/src/util/string_util.dart'; + Review Comment: We could leave common serializers under `dart/packages/fury/lib/src/serializer` directly. Only serializers which constructs a group like collection/time should be left into another sub directory -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
