chaokunyang commented on code in PR #2112:
URL: https://github.com/apache/fury/pull/2112#discussion_r2019737389
##########
dart/packages/fury/lib/src/resolver/ref/ser_ref_resolver.dart:
##########
@@ -0,0 +1,22 @@
+import 'package:fury/src/const/ref_flag.dart';
+import 'package:fury/src/resolver/impl/ref/ser_map_resolver.dart';
+import 'package:fury/src/resolver/impl/ref/ser_no_ref_resolver.dart';
+
+typedef SerRefRes = ({RefFlag refFlag, int? refId});
Review Comment:
`Res` can be recognized as `Resource`, we shoudl avoid such abbr in whole
codebase. How about `SerializationRefMeta`?
I suggest to avoid all uncommon abbr in this PR. We could take
https://github.com/google/json_serializable.dart/blob/master/json_serializable/lib/src/json_serializable_generator.dart
as an example.
Fury favors clarity over brevity in naming conventions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
