[Git][gajim/gajim][master] Print malformed pubsub avatar stanzas

[Philipp Hörist]

Philipp Hörist pushed to branch master at gajim / gajim


Commits:
1d566563 by Philipp Hörist at 2017-10-08T14:32:59+02:00
Print malformed pubsub avatar stanzas

- - - - -


1 changed file:

- gajim/common/connection_handlers_events.py


Changes:

=====================================
gajim/common/connection_handlers_events.py
=====================================
--- a/gajim/common/connection_handlers_events.py
+++ b/gajim/common/connection_handlers_events.py
@@ -584,14 +584,20 @@ class PubsubAvatarReceivedEvent(nec.NetworkIncomingEvent):
         if self.items_node.getAttr('node') != 'urn:xmpp:avatar:data':
             return
         item = self.items_node.getTag('item')
+        if not item:
+            log.warning('Received malformed avatar data via pubsub')
+            log.warning(self.stanza)
+            return
         self.sha = item.getAttr('id')
         data_tag = item.getTag('data', namespace='urn:xmpp:avatar:data')
         if self.sha is None or data_tag is None:
             log.warning('Received malformed avatar data via pubsub')
+            log.warning(self.stanza)
             return
         self.data = data_tag.getData()
         if self.data is None:
             log.warning('Received malformed avatar data via pubsub')
+            log.warning(self.stanza)
             return
         self.data = base64.b64decode(self.data.encode('utf-8'))
 



View it on GitLab: 
https://dev.gajim.org/gajim/gajim/commit/1d5665632a9dc3f0f02fd48815445676e236d4e0

---
View it on GitLab: 
https://dev.gajim.org/gajim/gajim/commit/1d5665632a9dc3f0f02fd48815445676e236d4e0
You're receiving this email because of your account on dev.gajim.org.

_______________________________________________
Commits mailing list
Commits@gajim.org
https://lists.gajim.org/cgi-bin/listinfo/commits