[Git][gajim/gajim][master] Use appmenu only if system supports it

[Philipp Hörist]

Philipp Hörist pushed to branch master at gajim / gajim


Commits:
fc627fc1 by Philipp Hörist at 2017-11-24T18:54:30+01:00
Use appmenu only if system supports it

- - - - -


3 changed files:

- gajim/common/app.py
- gajim/gajim.py
- gajim/gui_menu_builder.py


Changes:

=====================================
gajim/common/app.py
=====================================
--- a/gajim/common/app.py
+++ b/gajim/common/app.py
@@ -28,6 +28,7 @@
 ##
 
 import os
+import sys
 import logging
 import locale
 import uuid
@@ -500,3 +501,10 @@ def get_priority(account, show):
 def log(domain):
     root = 'gajim.'
     return logging.getLogger(root + domain)
+
+def prefers_app_menu():
+    if sys.platform == 'darwin':
+        return True
+    if sys.platform == 'win32':
+        return False
+    return app.prefers_app_menu()


=====================================
gajim/gajim.py
=====================================
--- a/gajim/gajim.py
+++ b/gajim/gajim.py
@@ -215,10 +215,9 @@ class GajimApplication(Gtk.Application):
         builder.add_from_file(path)
         menubar = builder.get_object("menubar")
         appmenu = builder.get_object("appmenu")
-        if os.name != 'nt':
+        if app.prefers_app_menu():
             self.set_app_menu(appmenu)
         else:
-            # Dont set Application Menu for Windows
             # Add it to the menubar instead
             menubar.prepend_submenu('Gajim', appmenu)
         self.set_menubar(menubar)


=====================================
gajim/gui_menu_builder.py
=====================================
--- a/gajim/gui_menu_builder.py
+++ b/gajim/gui_menu_builder.py
@@ -767,9 +767,9 @@ def get_account_menu(account):
 def build_accounts_menu():
     menubar = app.app.get_menubar()
     # Accounts Submenu
-    menu_position = 0
-    if os.name == 'nt':
-        menu_position = 1
+    menu_position = 1
+    if app.prefers_app_menu():
+        menu_position = 0
 
     acc_menu = menubar.get_item_link(menu_position, 'submenu')
     acc_menu.remove_all()
@@ -796,9 +796,9 @@ def build_bookmark_menu(account):
     if not bookmark_menu:
         return
 
-    menu_position = 0
-    if os.name == 'nt':
-        menu_position = 1
+    menu_position = 1
+    if app.prefers_app_menu():
+        menu_position = 0
 
     # Accounts Submenu
     acc_menu = menubar.get_item_link(menu_position, 'submenu')



View it on GitLab: 
https://dev.gajim.org/gajim/gajim/commit/fc627fc19cc145a86383b221416422709bd03d9d

---
View it on GitLab: 
https://dev.gajim.org/gajim/gajim/commit/fc627fc19cc145a86383b221416422709bd03d9d
You're receiving this email because of your account on dev.gajim.org.

_______________________________________________
Commits mailing list
Commits@gajim.org
https://lists.gajim.org/cgi-bin/listinfo/commits