Philipp Hörist pushed to branch master at gajim / gajim


Commits:
d7af6eb2 by Philipp Hörist at 2019-10-26T06:50:50Z
Chatstates: Never stop message processing inside that module

Clients adding chatstates should not disrupt Gajim

- - - - -


1 changed file:

- gajim/common/modules/chatstates.py


Changes:

=====================================
gajim/common/modules/chatstates.py
=====================================
@@ -137,16 +137,14 @@ class Chatstate(BaseModule):
                          account=self._account,
                          contact=contact))
 
-    def _process_chatstate(self, _con, stanza, properties):
+    def _process_chatstate(self, _con, _stanza, properties):
         if not properties.has_chatstate:
             return
 
         if (properties.is_self_message or
                 properties.type.is_groupchat or
+                properties.is_mam_message or
                 properties.is_carbon_message and properties.carbon.is_sent):
-            if properties.chatstate in ('inactive', 'gone',
-                                        'composing', 'paused'):
-                raise nbxmpp.NodeProcessed
             return
 
         if properties.is_muc_pm:
@@ -167,15 +165,6 @@ class Chatstate(BaseModule):
                          account=self._account,
                          contact=contact))
 
-        if properties.chatstate in ('inactive', 'gone', 'composing', 'paused'):
-            if properties.body is None:
-                # So we dont lose a message if a client implements not
-                # recomended behavior
-                raise nbxmpp.NodeProcessed
-
-            self._log.warning('Chatstate with body received')
-            self._log.warning(stanza)
-
     @ensure_enabled
     def _check_last_interaction(self) -> GLib.SOURCE_CONTINUE:
         now = time.time()



View it on GitLab: 
https://dev.gajim.org/gajim/gajim/commit/d7af6eb2f229ebf9718bdccb0737515feb577235

-- 
View it on GitLab: 
https://dev.gajim.org/gajim/gajim/commit/d7af6eb2f229ebf9718bdccb0737515feb577235
You're receiving this email because of your account on dev.gajim.org.


_______________________________________________
Commits mailing list
[email protected]
https://lists.gajim.org/cgi-bin/listinfo/commits

Reply via email to