Philipp Hörist pushed to branch refactor_view at gajim / gajim
Commits:
8ceb84d5 by Philipp Hörist at 2022-09-18T15:27:46+02:00
cfix: Don’t use disconnect_by_func()
- - - - -
1 changed file:
- gajim/gtk/conversation/view.py
Changes:
=====================================
gajim/gtk/conversation/view.py
=====================================
@@ -130,6 +130,7 @@ def __init__(self) -> None:
self._block_signals = False
self._signal_handlers_enabled = False
+ self._signal_handler_ids = (0, 0)
self.add(self._list_box)
self.set_focus_vadjustment(Gtk.Adjustment())
@@ -141,11 +142,15 @@ def _enable_signal_handlers(self, enable: bool) -> None:
vadjustment = self.get_vadjustment()
if enable:
- vadjustment.connect('notify::upper', self._on_adj_upper_changed)
- vadjustment.connect('notify::value', self._on_adj_value_changed)
+ upper_id = vadjustment.connect('notify::upper',
+ self._on_adj_upper_changed)
+ value_id = vadjustment.connect('notify::value',
+ self._on_adj_value_changed)
+ self._signal_handler_ids = (upper_id, value_id)
else:
- vadjustment.disconnect_by_func(self._on_adj_upper_changed)
- vadjustment.disconnect_by_func(self._on_adj_value_changed)
+ upper_id, value_id = self._signal_handler_ids
+ vadjustment.disconnect(upper_id)
+ vadjustment.disconnect(value_id)
self._signal_handlers_enabled = enable
View it on GitLab:
https://dev.gajim.org/gajim/gajim/-/commit/8ceb84d5a5fbcbd36b7664db5e67d633b7ba52d3
--
View it on GitLab:
https://dev.gajim.org/gajim/gajim/-/commit/8ceb84d5a5fbcbd36b7664db5e67d633b7ba52d3
You're receiving this email because of your account on dev.gajim.org.
_______________________________________________
Commits mailing list
[email protected]
https://lists.gajim.org/cgi-bin/listinfo/commits
