Daniel Brötzmann pushed to branch master at gajim / gajim
Commits:
f45619bb by wurstsalat at 2023-01-20T23:25:10+01:00
fix: JingleAudio: Always resample audio before processing with webrtcdsp
Resample both input and output in order to make sure both run at the same
sampling rate in all cases.
Fixes #11023
- - - - -
1 changed file:
- gajim/common/jingle_rtp.py
Changes:
=====================================
gajim/common/jingle_rtp.py
=====================================
@@ -440,17 +440,24 @@ def setup_stream(self) -> None:
if 'webrtcdsp' in self.available_gst_plugins:
self.src_bin = self.make_bin_from_config(
'audio_input_device',
- '''%s
+ '''
+ %s
+ ! audioconvert
+ ! audioresample
+ ! audio/x-raw,rate=48000
! webrtcdsp
echo-suppression-level=high
noise-suppression-level=very-high
voice-detection=true
- ! audioconvert ''',
+ ''',
_('audio input'))
else:
self.src_bin = self.make_bin_from_config(
'audio_input_device',
- '%s ! audioconvert ',
+ '''
+ %s
+ ! audioconvert
+ ''',
_('audio input'))
# setting name=webrtcechoprobe0 is needed because lingering probes
@@ -458,13 +465,23 @@ def setup_stream(self) -> None:
if 'webrtcdsp' in self.available_gst_plugins:
self.sink = self.make_bin_from_config(
'audio_output_device',
- '''audioconvert ! volume name=gajim_out_vol !
- webrtcechoprobe name=webrtcechoprobe0 ! %s''',
+ '''
+ audioconvert
+ ! audioresample
+ ! audio/x-raw,rate=48000
+ ! volume name=gajim_out_vol
+ ! webrtcechoprobe name=webrtcechoprobe0
+ ! %s
+ ''',
_('audio output'))
else:
self.sink = self.make_bin_from_config(
'audio_output_device',
- 'audioconvert ! volume name=gajim_out_vol ! %s',
+ '''
+ audioconvert
+ ! volume name=gajim_out_vol
+ ! %s
+ ''',
_('audio output'))
self.mic_volume = self.src_bin.get_by_name('gajim_vol')
self.out_volume = self.sink.get_by_name('gajim_out_vol')
View it on GitLab:
https://dev.gajim.org/gajim/gajim/-/commit/f45619bb11672e374a2a772f4b27a4c13ad0f95d
--
View it on GitLab:
https://dev.gajim.org/gajim/gajim/-/commit/f45619bb11672e374a2a772f4b27a4c13ad0f95d
You're receiving this email because of your account on dev.gajim.org.
_______________________________________________
Commits mailing list
[email protected]
https://lists.gajim.org/cgi-bin/listinfo/commits
