Philipp Hörist pushed to branch master at gajim / gajim
Commits:
e3c64a20 by Philipp Hörist at 2023-04-15T20:52:16+02:00
refactor: Return mime types as Set
- - - - -
40928818 by Philipp Hörist at 2023-04-15T20:55:49+02:00
new: Preview: Add more logging
- - - - -
2 changed files:
- gajim/common/preview.py
- gajim/common/preview_helpers.py
Changes:
=====================================
gajim/common/preview.py
=====================================
@@ -225,6 +225,9 @@ def __init__(self) -> None:
# to stop previews by preview_id, see stop_audio_except(preview_id)
self._audio_stop_functions: dict[int, Callable[..., None]] = {}
+ log.info('Supported mime types for preview')
+ log.info(sorted(list(PREVIEWABLE_MIME_TYPES)))
+
def get_preview(self, preview_id: str) -> Optional[Preview]:
return self._previews.get(preview_id)
@@ -280,6 +283,7 @@ def _accept_uri(urlparts: ParseResult,
if app.settings.get('preview_allow_all_images'):
mime_type = guess_mime_type(uri)
if mime_type not in MIME_TYPES:
+ log.info('%s not in allowed mime types', mime_type)
return False
if mime_type == 'application/octet-stream' and uri != oob_url:
=====================================
gajim/common/preview_helpers.py
=====================================
@@ -430,7 +430,7 @@ def contains_audio_streams(file_path: Path) -> bool:
return has_audio
-def get_previewable_mime_types() -> tuple[str, ...]:
+def get_previewable_mime_types() -> set[str]:
previewable_mime_types: set[str] = set()
for fmt in GdkPixbuf.Pixbuf.get_formats():
for mime_type in fmt.get_mime_types():
@@ -440,7 +440,7 @@ def get_previewable_mime_types() -> tuple[str, ...]:
for mime_type in Image.MIME.values():
previewable_mime_types.add(mime_type.lower())
- return tuple(filter(
+ return set(filter(
lambda mime_type: mime_type.startswith('image'),
previewable_mime_types
))
View it on GitLab:
https://dev.gajim.org/gajim/gajim/-/compare/810b48a89d5644c554eff9a640b160525cf3ee6e...409288180e1e3a2dd5efcf77a511f4c9c2fce7df
--
View it on GitLab:
https://dev.gajim.org/gajim/gajim/-/compare/810b48a89d5644c554eff9a640b160525cf3ee6e...409288180e1e3a2dd5efcf77a511f4c9c2fce7df
You're receiving this email because of your account on dev.gajim.org.
_______________________________________________
Commits mailing list
[email protected]
https://lists.gajim.org/cgi-bin/listinfo/commits
