Daniel Brötzmann pushed to branch master at gajim / gajim
Commits:
af23279d by wurstsalat at 2023-06-06T21:21:12+02:00
cq: Tests: Make type check pass for SSLErrorDialog and CertificateDialog
- - - - -
3 changed files:
- pyproject.toml
- test/dialogs/certificate_dialog.py
- test/dialogs/ssl_error_dialog.py
Changes:
=====================================
pyproject.toml
=====================================
@@ -103,11 +103,9 @@ exclude = [
"gajim/plugins/pluginmanager.py",
"scripts/update_flatpak_manifest.py",
"test/common/test_uri_util.py",
- "test/dialogs/certificate_dialog.py",
"test/dialogs/change_password.py",
"test/dialogs/dataform.py",
"test/dialogs/groupchat_info.py",
- "test/dialogs/ssl_error_dialog.py",
"test/gui/test_menus.py",
"test/gui/test_nick_completion.py",
]
=====================================
test/dialogs/certificate_dialog.py
=====================================
@@ -44,7 +44,7 @@
-----END CERTIFICATE-----'''
gio_cert = Gio.TlsCertificate.new_from_pem(cert, -1)
-win = CertificateDialog(None, 'testacc', gio_cert)
+win = CertificateDialog(Gtk.Window(), 'testacc', gio_cert)
win.connect('destroy', Gtk.main_quit)
win.show_all()
Gtk.main()
=====================================
test/dialogs/ssl_error_dialog.py
=====================================
@@ -1,3 +1,5 @@
+from typing import cast
+
from unittest.mock import MagicMock
from gi.repository import Gio
@@ -49,11 +51,14 @@
app.settings = MagicMock()
app.settings.get_account_setting = MagicMock(
- return_value=['[email protected]'])
+ return_value='[email protected]')
gio_cert = Gio.TlsCertificate.new_from_pem(cert, -1)
-ssl_error_num = 10
-win = SSLErrorDialog('testacc', None, gio_cert, ssl_error_num)
+# Listing of Gio.TlsCertificateFlags:
+# https://lazka.github.io/pgi-docs/#Gio-2.0/flags.html#Gio.TlsCertificateFlags
+ssl_error_num = cast(Gio.TlsCertificateFlags, 10)
+
+win = SSLErrorDialog('testacc', MagicMock(), gio_cert, ssl_error_num)
win.connect('destroy', Gtk.main_quit)
win.show_all()
Gtk.main()
View it on GitLab:
https://dev.gajim.org/gajim/gajim/-/commit/af23279d95c58bdb2c335b55e0e396e188d70e66
--
View it on GitLab:
https://dev.gajim.org/gajim/gajim/-/commit/af23279d95c58bdb2c335b55e0e396e188d70e66
You're receiving this email because of your account on dev.gajim.org.
_______________________________________________
Commits mailing list
[email protected]
https://lists.gajim.org/cgi-bin/listinfo/commits
