Philipp Hörist pushed to branch master at gajim / gajim


Commits:
08211288 by Philipp Hörist at 2023-10-06T22:57:30+02:00
fix: ChatListStack: Handle missing last visible child

It’s not entirely clear how this can ever happen, but it does apparently

- - - - -


1 changed file:

- gajim/gtk/chat_list_stack.py


Changes:

=====================================
gajim/gtk/chat_list_stack.py
=====================================
@@ -104,16 +104,18 @@ def _add_actions(self) -> None:
             app.window.add_action(act)
 
     def _on_visible_child_name(self, _stack: Gtk.Stack, _param: str) -> None:
-        if self._last_visible_child_name == self.get_visible_child_name():
+        new_visible_child_name = self.get_visible_child_name()
+        if self._last_visible_child_name == new_visible_child_name:
             return
 
         if self._last_visible_child_name != 'default':
             chat_list = cast(
-                ChatList,
+                ChatList | None,
                 self.get_child_by_name(self._last_visible_child_name))
-            chat_list.set_filter_text('')
-        last_child = self.get_visible_child_name() or 'default'
-        self._last_visible_child_name = last_child
+            if chat_list is not None:
+                chat_list.set_filter_text('')
+
+        self._last_visible_child_name = new_visible_child_name or 'default'
 
     def get_chatlist(self, workspace_id: str) -> ChatList:
         return self._chat_lists[workspace_id]



View it on GitLab: 
https://dev.gajim.org/gajim/gajim/-/commit/08211288050eda313632720adabdb5b955cee9d8

-- 
View it on GitLab: 
https://dev.gajim.org/gajim/gajim/-/commit/08211288050eda313632720adabdb5b955cee9d8
You're receiving this email because of your account on dev.gajim.org.


_______________________________________________
Commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to