Philipp Hörist pushed to branch gtk4 at gajim / gajim


Commits:
436cc53e by Philipp Hörist at 2024-10-03T18:31:35+02:00
refactor: Fix Plugins window

- - - - -


2 changed files:

- gajim/data/gui/plugins.ui
- gajim/gtk/plugins.py


Changes:

=====================================
gajim/data/gui/plugins.ui
=====================================
@@ -16,7 +16,6 @@
     </columns>
   </object>
   <object class="GtkBox" id="plugins_box">
-    <property name="border-width">18</property>
     <property name="spacing">18</property>
     <child>
       <object class="GtkBox">
@@ -27,7 +26,6 @@
             <property name="vexpand">1</property>
             <property name="focusable">1</property>
             <property name="hscrollbar-policy">never</property>
-            <property name="shadow-type">out</property>
             <property name="child">
               <object class="GtkTreeView" id="plugins_treeview">
                 <property name="focusable">1</property>
@@ -145,8 +143,6 @@
           <object class="GtkBox" id="toolbar">
             <property name="css-classes">toolbar</property>
             <property name="can-focus">0</property>
-            <property name="show-arrow">False</property>
-            <property name="icon_size">1</property>
             <child>
               <object class="GtkButton" id="install_from_zip_button">
                 <property name="can-focus">0</property>
@@ -178,7 +174,6 @@
             <child>
               <object class="GtkButton" id="help_button">
                 <property name="can-focus">0</property>
-                <property name="no-show-all">True</property>
                 <property name="tooltip-text" translatable="1">Click to view 
Gajim&apos;s wiki page on how to install plugins in Flatpak.</property>
                 <property name="label" translatable="1">help</property>
                 <property name="use-underline">1</property>


=====================================
gajim/gtk/plugins.py
=====================================
@@ -59,13 +59,12 @@ def __init__(self) -> None:
         EventHelper.__init__(self)
 
         self.set_application(app.app)
-        self.set_position(Gtk.WindowPosition.CENTER)
         self.set_default_size(650, 500)
         self.set_show_menubar(False)
         self.set_title(_('Plugins'))
 
         self._ui = get_builder('plugins.ui', self)
-        self.add(self._ui.plugins_box)
+        self.set_child(self._ui.plugins_box)
 
         if app.is_flatpak():
             self._ui.help_button.show()
@@ -87,8 +86,7 @@ def __init__(self) -> None:
         self._load_repository_manifests()
 
         self.connect('destroy', self._on_destroy)
-        self.connect('key-press-event', self._on_key_press)
-        self._ui.connect_signals(self)
+        # self.connect('key-press-event', self._on_key_press) TODO GTK4
 
         self.register_events([
             ('plugin-removed', ged.GUI1, self._on_plugin_removed),
@@ -102,7 +100,7 @@ def __init__(self) -> None:
         app.plugin_repository.connect('download-failed',
                                       self._on_download_failed)
 
-        self.show_all()
+        self.show()
 
     def _on_render_enabled_cell(self,
                                 _tree_column: Gtk.TreeViewColumn,



View it on GitLab: 
https://dev.gajim.org/gajim/gajim/-/commit/436cc53e17e9356db950acdf49efbebec88a7102

-- 
View it on GitLab: 
https://dev.gajim.org/gajim/gajim/-/commit/436cc53e17e9356db950acdf49efbebec88a7102
You're receiving this email because of your account on dev.gajim.org.


_______________________________________________
Commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to