Daniel Brötzmann pushed to branch gtk4 at gajim / gajim


Commits:
54d0be5a by wurstsalat at 2024-10-31T11:14:33+01:00
refactor: GroupchatManage: Fix TODO

- - - - -


2 changed files:

- gajim/gtk/groupchat_details.py
- gajim/gtk/groupchat_manage.py


Changes:

=====================================
gajim/gtk/groupchat_details.py
=====================================
@@ -34,7 +34,7 @@ def __init__(
     ) -> None:
         GajimAppWindow.__init__(
             self,
-            name='StartChatDialog',
+            name='GroupchatDetails',
             title=_('Group Chat Details'),
             default_height=600,
             add_window_padding=False,


=====================================
gajim/gtk/groupchat_manage.py
=====================================
@@ -1,6 +1,8 @@
 #
 # SPDX-License-Identifier: GPL-3.0-only
 
+from typing import cast
+
 import logging
 from pathlib import Path
 
@@ -22,6 +24,8 @@
 from gajim.gtk.builder import get_builder
 from gajim.gtk.dialogs import ErrorDialog
 from gajim.gtk.filechoosers import AvatarFileChooserButton
+from gajim.gtk.groupchat_details import GroupchatDetails
+from gajim.gtk.util import get_app_window
 from gajim.gtk.util import SignalManager
 
 log = logging.getLogger('gajim.gtk.groupchat_manage')
@@ -289,10 +293,9 @@ def _on_destroy_confirmed(self, _button: Gtk.Button) -> 
None:
         alternate_jid = self._ui.destroy_alternate_entry.get_text()
         self._client.get_module('MUC').destroy(
             self._contact.jid, reason, alternate_jid)
-        # TODO GTK4
-        return
-        window = self.get_toplevel()
-        window.destroy()
+
+        window = cast(GroupchatDetails, get_app_window('GroupchatDetails'))
+        window.close()
 
     def _on_destroy_cancelled(self, _button: Gtk.Button) -> None:
         self._ui.stack.set_visible_child_name('manage')



View it on GitLab: 
https://dev.gajim.org/gajim/gajim/-/commit/54d0be5a1ae80da2a57f8932132770874d161e68

-- 
View it on GitLab: 
https://dev.gajim.org/gajim/gajim/-/commit/54d0be5a1ae80da2a57f8932132770874d161e68
You're receiving this email because of your account on dev.gajim.org.


_______________________________________________
Commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to