Philipp Hörist pushed to branch master at gajim / gajim


Commits:
2bacaf2b by Philipp Hörist at 2024-12-15T13:36:25+01:00
cfix: DropDownSetting: Disconnect signal on unroot

- - - - -
ef6302c4 by Philipp Hörist at 2024-12-15T13:36:25+01:00
cfix: SpinSetting: Show minimum 5 chars

- - - - -


1 changed file:

- gajim/gtk/settings.py


Changes:

=====================================
gajim/gtk/settings.py
=====================================
@@ -559,19 +559,22 @@ def __init__(self, *args: Any, range_: tuple[float, 
float, float]) -> None:
             page_size=0,
         )
 
-        self.spin = Gtk.SpinButton()
-        self.spin.set_adjustment(adjustment)
-        self.spin.set_numeric(True)
-        self.spin.set_update_policy(Gtk.SpinButtonUpdatePolicy.IF_VALID)
+        self.spin = Gtk.SpinButton(
+            adjustment=adjustment,
+            halign=Gtk.Align.END,
+            hexpand=True,
+            numeric=True,
+            update_policy=Gtk.SpinButtonUpdatePolicy.IF_VALID,
+            valign=Gtk.Align.CENTER,
+            width_chars=5,
+        )
 
         assert self.setting_value is not None
         if isinstance(self.setting_value, float):
             self.spin.set_digits(3)
 
         self.spin.set_value(float(self.setting_value))
-        self.spin.set_halign(Gtk.Align.END)
-        self.spin.set_valign(Gtk.Align.CENTER)
-        self.spin.set_hexpand(True)
+
         self._connect(self.spin, "notify::value", self.on_value_change)
 
         self.setting_box.append(self.spin)
@@ -691,6 +694,7 @@ def __init__(
         self._add_action_button(kwargs)
 
     def do_unroot(self) -> None:
+        self._dropdown.disconnect_by_func(self._on_selected)
         GenericSetting.do_unroot(self)
         app.check_finalize(self._dropdown)
         del self._dropdown



View it on GitLab: 
https://dev.gajim.org/gajim/gajim/-/compare/5428516878a1b2562ebc76bbdbac6f67a8a32ea2...ef6302c4da87254e265dc6110700022b0e51a24c

-- 
View it on GitLab: 
https://dev.gajim.org/gajim/gajim/-/compare/5428516878a1b2562ebc76bbdbac6f67a8a32ea2...ef6302c4da87254e265dc6110700022b0e51a24c
You're receiving this email because of your account on dev.gajim.org.


_______________________________________________
Commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to