GEODE-2433 Backwards compatibility tests are not actually running Tests will now fail of there are no older versions of Geode to test against.
Project: http://git-wip-us.apache.org/repos/asf/geode/repo Commit: http://git-wip-us.apache.org/repos/asf/geode/commit/5e6f6734 Tree: http://git-wip-us.apache.org/repos/asf/geode/tree/5e6f6734 Diff: http://git-wip-us.apache.org/repos/asf/geode/diff/5e6f6734 Branch: refs/heads/master Commit: 5e6f67346c75a92084bbb1e46f7f0c016353eb97 Parents: 5554dd2 Author: Bruce Schuchardt <bschucha...@pivotal.io> Authored: Mon Feb 6 11:38:47 2017 -0800 Committer: Bruce Schuchardt <bschucha...@pivotal.io> Committed: Mon Feb 6 13:31:05 2017 -0800 ---------------------------------------------------------------------- .../cache/rollingupgrade/RollingUpgrade2DUnitTest.java | 8 +++++++- .../cache/rollingupgrade/RollingUpgradeDUnitTest.java | 8 +++++++- .../cache/tier/sockets/ClientServerMiscBCDUnitTest.java | 2 +- 3 files changed, 15 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/geode/blob/5e6f6734/geode-core/src/test/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgrade2DUnitTest.java ---------------------------------------------------------------------- diff --git a/geode-core/src/test/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgrade2DUnitTest.java b/geode-core/src/test/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgrade2DUnitTest.java index 14d87f9..5106935 100755 --- a/geode-core/src/test/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgrade2DUnitTest.java +++ b/geode-core/src/test/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgrade2DUnitTest.java @@ -112,7 +112,13 @@ public class RollingUpgrade2DUnitTest extends JUnit4DistributedTestCase { @Parameterized.Parameters public static Collection<String> data() { - return VersionManager.getInstance().getVersionsWithoutCurrent(); + List<String> result = VersionManager.getInstance().getVersionsWithoutCurrent(); + if (result.size() < 1) { + throw new RuntimeException("No older versions of Geode were found to test against"); + } else { + System.out.println("running against these versions: " + result); + } + return result; } // just a test flag that can be set when trying to run a test in eclipse and avoiding IllegalState http://git-wip-us.apache.org/repos/asf/geode/blob/5e6f6734/geode-core/src/test/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgradeDUnitTest.java ---------------------------------------------------------------------- diff --git a/geode-core/src/test/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgradeDUnitTest.java b/geode-core/src/test/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgradeDUnitTest.java index 369bc3b..54b51de 100644 --- a/geode-core/src/test/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgradeDUnitTest.java +++ b/geode-core/src/test/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgradeDUnitTest.java @@ -74,7 +74,13 @@ public class RollingUpgradeDUnitTest extends JUnit4DistributedTestCase { @Parameterized.Parameters public static Collection<String> data() { - return VersionManager.getInstance().getVersionsWithoutCurrent(); + List<String> result = VersionManager.getInstance().getVersionsWithoutCurrent(); + if (result.size() < 1) { + throw new RuntimeException("No older versions of Geode were found to test against"); + } else { + System.out.println("running against these versions: " + result); + } + return result; } private File[] testingDirs = new File[3]; http://git-wip-us.apache.org/repos/asf/geode/blob/5e6f6734/geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscBCDUnitTest.java ---------------------------------------------------------------------- diff --git a/geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscBCDUnitTest.java b/geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscBCDUnitTest.java index 28fe3f2..be0ac6b 100755 --- a/geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscBCDUnitTest.java +++ b/geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscBCDUnitTest.java @@ -32,7 +32,7 @@ import java.util.List; public class ClientServerMiscBCDUnitTest extends ClientServerMiscDUnitTest { @Parameterized.Parameters public static Collection<String> data() { - List<String> result = VersionManager.getInstance().getVersionsWithoutCurrent(); + List<String> result = VersionManager.getInstance().getVersionsWithoutCurrent(); if (result.size() < 1) { throw new RuntimeException("No older versions of Geode were found to test against"); } else {
