http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/execute/AbstractExecution.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/execute/AbstractExecution.java b/geode-core/src/main/java/org/apache/geode/internal/cache/execute/AbstractExecution.java index f09a378..64b2284 100755 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/execute/AbstractExecution.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/execute/AbstractExecution.java @@ -116,8 +116,7 @@ public abstract class AbstractExecution implements InternalExecution { public static final byte HA_HASRESULT_OPTIMIZEFORWRITE_REEXECUTE = 15; - public static final byte getFunctionState(boolean isHA, boolean hasResult, - boolean optimizeForWrite) { + public static byte getFunctionState(boolean isHA, boolean hasResult, boolean optimizeForWrite) { if (isHA) { if (hasResult) { if (optimizeForWrite) { @@ -144,7 +143,7 @@ public abstract class AbstractExecution implements InternalExecution { } } - public static final byte getReexecuteFunctionState(byte fnState) { + public static byte getReexecuteFunctionState(byte fnState) { if (fnState == HA_HASRESULT_NO_OPTIMIZEFORWRITE) { return HA_HASRESULT_NO_OPTIMIZEFORWRITE_REEXECUTE; } else if (fnState == HA_HASRESULT_OPTIMIZEFORWRITE) { @@ -238,16 +237,16 @@ public abstract class AbstractExecution implements InternalExecution { return isFnSerializationReqd; } - public final Collection<InternalDistributedMember> getExecutionNodes() { + public Collection<InternalDistributedMember> getExecutionNodes() { return this.executionNodes; } - public final void setRequireExecutionNodes(ExecutionNodesListener listener) { + public void setRequireExecutionNodes(ExecutionNodesListener listener) { this.executionNodes = Collections.emptySet(); this.executionNodesListener = listener; } - public final void setExecutionNodes(Set<InternalDistributedMember> nodes) { + public void setExecutionNodes(Set<InternalDistributedMember> nodes) { if (this.executionNodes != null) { this.executionNodes = nodes; if (this.executionNodesListener != null) { @@ -256,7 +255,7 @@ public abstract class AbstractExecution implements InternalExecution { } } - public final void executeFunctionOnLocalPRNode(final Function fn, final FunctionContext cx, + public void executeFunctionOnLocalPRNode(final Function fn, final FunctionContext cx, final PartitionedRegionFunctionResultSender sender, DM dm, boolean isTx) { if (dm instanceof DistributionManager && !isTx) { if (ServerConnection.isExecuteFunctionOnLocalNodeOnly().byteValue() == 1) { @@ -294,7 +293,7 @@ public abstract class AbstractExecution implements InternalExecution { // Bug41118 : in case of lonerDistribuedSystem do local execution through // main thread otherwise give execution to FunctionExecutor from // DistributionManager - public final void executeFunctionOnLocalNode(final Function fn, final FunctionContext cx, + public void executeFunctionOnLocalNode(final Function fn, final FunctionContext cx, final ResultSender sender, DM dm, final boolean isTx) { if (dm instanceof DistributionManager && !isTx) { final DistributionManager newDM = (DistributionManager) dm; @@ -318,7 +317,7 @@ public abstract class AbstractExecution implements InternalExecution { } } - public final void executeFunctionLocally(final Function fn, final FunctionContext cx, + public void executeFunctionLocally(final Function fn, final FunctionContext cx, final ResultSender sender, DM dm) { FunctionStats stats = FunctionStats.getFunctionStats(fn.getId(), dm.getSystem()); @@ -396,7 +395,7 @@ public abstract class AbstractExecution implements InternalExecution { return executeFunction(function); } - public final void setWaitOnExceptionFlag(boolean waitOnException) { + public void setWaitOnExceptionFlag(boolean waitOnException) { this.setForwardExceptions(waitOnException); this.waitOnException = waitOnException; } @@ -438,7 +437,7 @@ public abstract class AbstractExecution implements InternalExecution { */ public abstract void validateExecution(Function function, Set targetMembers); - public final LocalResultCollector<?, ?> getLocalResultCollector(Function function, + public LocalResultCollector<?, ?> getLocalResultCollector(Function function, final ResultCollector<?, ?> rc) { if (rc instanceof LocalResultCollector) { return (LocalResultCollector) rc;
http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionContextImpl.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionContextImpl.java b/geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionContextImpl.java index c616cbd..39190f3 100755 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionContextImpl.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionContextImpl.java @@ -63,7 +63,7 @@ public class FunctionContextImpl implements FunctionContext { * * @return the arguments or null if there are no arguments */ - public final Object getArguments() { + public Object getArguments() { return this.args; } http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/execute/MemberFunctionResultSender.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/execute/MemberFunctionResultSender.java b/geode-core/src/main/java/org/apache/geode/internal/cache/execute/MemberFunctionResultSender.java index d0b7bb8..d0a0b88 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/execute/MemberFunctionResultSender.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/execute/MemberFunctionResultSender.java @@ -33,7 +33,7 @@ import org.apache.geode.internal.logging.log4j.LocalizedMessage; * * */ -public final class MemberFunctionResultSender implements InternalResultSender { +public class MemberFunctionResultSender implements InternalResultSender { private static final Logger logger = LogService.getLogger(); http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/execute/NoResult.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/execute/NoResult.java b/geode-core/src/main/java/org/apache/geode/internal/cache/execute/NoResult.java index 19b5421..3694e98 100755 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/execute/NoResult.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/execute/NoResult.java @@ -36,7 +36,7 @@ import org.apache.geode.internal.i18n.LocalizedStrings; * @see Function#hasResult() * */ -public final class NoResult implements ResultCollector, Serializable { +public class NoResult implements ResultCollector, Serializable { private static final long serialVersionUID = -4901369422864228848L; http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/execute/PartitionedRegionFunctionResultSender.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/execute/PartitionedRegionFunctionResultSender.java b/geode-core/src/main/java/org/apache/geode/internal/cache/execute/PartitionedRegionFunctionResultSender.java index 9aa8262..5fb1f78 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/execute/PartitionedRegionFunctionResultSender.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/execute/PartitionedRegionFunctionResultSender.java @@ -40,7 +40,7 @@ import org.apache.geode.internal.logging.log4j.LocalizedMessage; * */ -public final class PartitionedRegionFunctionResultSender implements InternalResultSender { +public class PartitionedRegionFunctionResultSender implements InternalResultSender { private static final Logger logger = LogService.getLogger(); http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/ha/QueueRemovalMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/ha/QueueRemovalMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/ha/QueueRemovalMessage.java index 7879538..357d18c 100755 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/ha/QueueRemovalMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/ha/QueueRemovalMessage.java @@ -44,7 +44,7 @@ import org.apache.geode.internal.logging.log4j.LocalizedMessage; * that have been dispatched by this node. The messages are received by other nodes and the * processing is handed over to an executor */ -public final class QueueRemovalMessage extends PooledDistributionMessage { +public class QueueRemovalMessage extends PooledDistributionMessage { private static final Logger logger = LogService.getLogger(); /** http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/locks/TXLockBatch.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/locks/TXLockBatch.java b/geode-core/src/main/java/org/apache/geode/internal/cache/locks/TXLockBatch.java index 2a2a37c..c762158 100755 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/locks/TXLockBatch.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/locks/TXLockBatch.java @@ -33,7 +33,7 @@ import org.apache.geode.distributed.internal.membership.*; * Adapts multiple TXRegionLockRequests to one DLockBatch for DLock to use. * */ -public final class TXLockBatch implements DLockBatch, DataSerializableFixedID { +public class TXLockBatch implements DLockBatch, DataSerializableFixedID { /** Identifies the batch as a single entity */ private TXLockIdImpl txLockId; http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/locks/TXLockIdImpl.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/locks/TXLockIdImpl.java b/geode-core/src/main/java/org/apache/geode/internal/cache/locks/TXLockIdImpl.java index 848088b..0fd607c 100755 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/locks/TXLockIdImpl.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/locks/TXLockIdImpl.java @@ -27,7 +27,7 @@ import org.apache.geode.distributed.internal.membership.*; * Identifies a group of transaction locks. * */ -public final class TXLockIdImpl implements TXLockId, DataSerializableFixedID { +public class TXLockIdImpl implements TXLockId, DataSerializableFixedID { private static final long serialVersionUID = 8579214625084490134L; /** DistributionManager id for this member */ @@ -50,11 +50,11 @@ public final class TXLockIdImpl implements TXLockId, DataSerializableFixedID { } } - public final int getCount() { + public int getCount() { return this.id; } - public final InternalDistributedMember getMemberId() { + public InternalDistributedMember getMemberId() { return this.memberId; } http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/locks/TXLockUpdateParticipantsMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/locks/TXLockUpdateParticipantsMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/locks/TXLockUpdateParticipantsMessage.java index bd1ea6d..5d03abd 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/locks/TXLockUpdateParticipantsMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/locks/TXLockUpdateParticipantsMessage.java @@ -46,7 +46,7 @@ import java.util.Set; * * @since GemFire 4.1.1 */ -public final class TXLockUpdateParticipantsMessage extends PooledDistributionMessage +public class TXLockUpdateParticipantsMessage extends PooledDistributionMessage implements MessageWithReply { private transient TXLockId txLockId; @@ -144,7 +144,7 @@ public final class TXLockUpdateParticipantsMessage extends PooledDistributionMes /** * The simple reply message that the sender waits for */ - public static final class TXLockUpdateParticipantsReplyMessage extends ReplyMessage { + public static class TXLockUpdateParticipantsReplyMessage extends ReplyMessage { @Override public int getDSFID() { http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/locks/TXOriginatorRecoveryProcessor.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/locks/TXOriginatorRecoveryProcessor.java b/geode-core/src/main/java/org/apache/geode/internal/cache/locks/TXOriginatorRecoveryProcessor.java index 6deae63..0dc75ff 100755 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/locks/TXOriginatorRecoveryProcessor.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/locks/TXOriginatorRecoveryProcessor.java @@ -120,7 +120,7 @@ public class TXOriginatorRecoveryProcessor extends ReplyProcessor21 { // ------------------------------------------------------------------------- // TXOriginatorRecoveryMessage // ------------------------------------------------------------------------- - public static final class TXOriginatorRecoveryMessage extends PooledDistributionMessage + public static class TXOriginatorRecoveryMessage extends PooledDistributionMessage implements MessageWithReply { /** The transaction lock for which the originator orphaned */ @@ -266,7 +266,7 @@ public class TXOriginatorRecoveryProcessor extends ReplyProcessor21 { // ------------------------------------------------------------------------- // TXOriginatorRecoveryReplyMessage // ------------------------------------------------------------------------- - public static final class TXOriginatorRecoveryReplyMessage extends ReplyMessage { + public static class TXOriginatorRecoveryReplyMessage extends ReplyMessage { /** The transaction lock for which the originator orphaned */ protected TXLockId txLockId; // only for the toString http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/lru/HeapLRUStatistics.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/lru/HeapLRUStatistics.java b/geode-core/src/main/java/org/apache/geode/internal/cache/lru/HeapLRUStatistics.java index ea8018a..105d4de 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/lru/HeapLRUStatistics.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/lru/HeapLRUStatistics.java @@ -44,7 +44,7 @@ public class HeapLRUStatistics extends LRUStatistics { * @see EnableLRU#mustEvict */ @Override - final public void updateCounter(long delta) { + public void updateCounter(long delta) { super.updateCounter(delta); } @@ -54,7 +54,7 @@ public class HeapLRUStatistics extends LRUStatistics { * <b>NOT</b> reset the counter value. */ @Override - final public void resetCounter() { + public void resetCounter() { super.resetCounter(); } } http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/lru/LRUCapacityController.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/lru/LRUCapacityController.java b/geode-core/src/main/java/org/apache/geode/internal/cache/lru/LRUCapacityController.java index 98e007c..f1972a6 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/lru/LRUCapacityController.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/lru/LRUCapacityController.java @@ -51,7 +51,7 @@ import java.util.*; * * @since GemFire 2.0.2 */ -public final class LRUCapacityController extends LRUAlgorithm implements Declarable { +public class LRUCapacityController extends LRUAlgorithm implements Declarable { private static final long serialVersionUID = -4383074909189355938L; http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/lru/MemLRUCapacityController.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/lru/MemLRUCapacityController.java b/geode-core/src/main/java/org/apache/geode/internal/cache/lru/MemLRUCapacityController.java index 1694f1b..17673a3 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/lru/MemLRUCapacityController.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/lru/MemLRUCapacityController.java @@ -74,7 +74,7 @@ import org.apache.geode.internal.i18n.LocalizedStrings; * * @since GemFire 2.0.2 */ -public final class MemLRUCapacityController extends LRUAlgorithm implements Declarable { +public class MemLRUCapacityController extends LRUAlgorithm implements Declarable { private static final long serialVersionUID = 6364183985590572514L; http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/lru/NewLRUClockHand.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/lru/NewLRUClockHand.java b/geode-core/src/main/java/org/apache/geode/internal/cache/lru/NewLRUClockHand.java index bbfef42..ccab3c7 100755 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/lru/NewLRUClockHand.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/lru/NewLRUClockHand.java @@ -141,7 +141,7 @@ public class NewLRUClockHand { * * @param aNode Description of the Parameter */ - public final void appendEntry(final LRUClockNode aNode) { + public void appendEntry(final LRUClockNode aNode) { synchronized (this.lock) { if (aNode.nextLRUNode() != null || aNode.prevLRUNode() != null) { return; @@ -408,7 +408,7 @@ public class NewLRUClockHand { protected static class HeadLock extends Object { } - private static final class GuardNode implements LRUClockNode { + private static class GuardNode implements LRUClockNode { private LRUClockNode next; LRUClockNode prev; http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/AllBucketProfilesUpdateMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/AllBucketProfilesUpdateMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/AllBucketProfilesUpdateMessage.java index 8b4cea7..910de64 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/AllBucketProfilesUpdateMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/AllBucketProfilesUpdateMessage.java @@ -42,7 +42,7 @@ import org.apache.geode.internal.logging.LogService; * * @since GemFire 6.6 */ -public final class AllBucketProfilesUpdateMessage extends DistributionMessage +public class AllBucketProfilesUpdateMessage extends DistributionMessage implements MessageWithReply { private static final Logger logger = LogService.getLogger(); @@ -54,7 +54,7 @@ public final class AllBucketProfilesUpdateMessage extends DistributionMessage public AllBucketProfilesUpdateMessage() {} @Override - final public int getProcessorType() { + public int getProcessorType() { return DistributionManager.WAITING_POOL_EXECUTOR; } http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/BecomePrimaryBucketMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/BecomePrimaryBucketMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/BecomePrimaryBucketMessage.java index eeb3704..b5de2e8 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/BecomePrimaryBucketMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/BecomePrimaryBucketMessage.java @@ -113,8 +113,8 @@ public class BecomePrimaryBucketMessage extends PartitionMessage { } @Override - protected final boolean operateOnPartitionedRegion(DistributionManager dm, - PartitionedRegion region, long startTime) throws ForceReattemptException { + protected boolean operateOnPartitionedRegion(DistributionManager dm, PartitionedRegion region, + long startTime) throws ForceReattemptException { // this is executing in the WAITING_POOL_EXECUTOR byte responseCode = BecomePrimaryBucketReplyMessage.NOT_SECONDARY; @@ -158,7 +158,7 @@ public class BecomePrimaryBucketMessage extends PartitionMessage { out.writeBoolean(this.isRebalance); } - public static final class BecomePrimaryBucketReplyMessage extends ReplyMessage { + public static class BecomePrimaryBucketReplyMessage extends ReplyMessage { static final byte NOT_SECONDARY = 0; static final byte OK = 1; http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/BucketBackupMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/BucketBackupMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/BucketBackupMessage.java index 122791d..8d164c8 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/BucketBackupMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/BucketBackupMessage.java @@ -37,7 +37,7 @@ import org.apache.geode.internal.logging.log4j.LogMarker; * * @since GemFire 5.0 */ -public final class BucketBackupMessage extends PartitionMessage { +public class BucketBackupMessage extends PartitionMessage { private static final Logger logger = LogService.getLogger(); http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/BucketProfileUpdateMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/BucketProfileUpdateMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/BucketProfileUpdateMessage.java index e413033..e353393 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/BucketProfileUpdateMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/BucketProfileUpdateMessage.java @@ -42,8 +42,7 @@ import org.apache.geode.internal.logging.LogService; * * @since GemFire 5.1 */ -public final class BucketProfileUpdateMessage extends DistributionMessage - implements MessageWithReply { +public class BucketProfileUpdateMessage extends DistributionMessage implements MessageWithReply { private static final Logger logger = LogService.getLogger(); private static final long serialVersionUID = 1L; @@ -55,7 +54,7 @@ public final class BucketProfileUpdateMessage extends DistributionMessage public BucketProfileUpdateMessage() {} @Override - final public int getProcessorType() { + public int getProcessorType() { return DistributionManager.WAITING_POOL_EXECUTOR; } http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/BucketSizeMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/BucketSizeMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/BucketSizeMessage.java index ed17740..ee5d1be 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/BucketSizeMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/BucketSizeMessage.java @@ -46,7 +46,7 @@ import org.apache.geode.internal.logging.log4j.LogMarker; * @since GemFire 5.0 */ -public final class BucketSizeMessage extends PartitionMessage { +public class BucketSizeMessage extends PartitionMessage { private static final Logger logger = LogService.getLogger(); /** The list of buckets whose size is needed, if null, then all buckets */ @@ -66,7 +66,7 @@ public final class BucketSizeMessage extends PartitionMessage { } @Override - final public int getProcessorType() { + public int getProcessorType() { return DistributionManager.STANDARD_EXECUTOR; } @@ -135,7 +135,7 @@ public final class BucketSizeMessage extends PartitionMessage { out.writeInt(this.bucketId); // fix for bug 38228 } - public static final class BucketSizeReplyMessage extends HighPriorityDistributionMessage { + public static class BucketSizeReplyMessage extends HighPriorityDistributionMessage { /** The shared obj id of the ReplyProcessor */ private int processorId; http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/ContainsKeyValueMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/ContainsKeyValueMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/ContainsKeyValueMessage.java index d6422c2..709cb13 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/ContainsKeyValueMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/ContainsKeyValueMessage.java @@ -44,7 +44,7 @@ import org.apache.geode.internal.logging.LogService; import org.apache.geode.internal.logging.log4j.LocalizedMessage; import org.apache.geode.internal.logging.log4j.LogMarker; -public final class ContainsKeyValueMessage extends PartitionMessageWithDirectReply { +public class ContainsKeyValueMessage extends PartitionMessageWithDirectReply { private static final Logger logger = LogService.getLogger(); private boolean valueCheck; @@ -169,7 +169,7 @@ public final class ContainsKeyValueMessage extends PartitionMessageWithDirectRep out.writeInt(this.bucketId.intValue()); } - public static final class ContainsKeyValueReplyMessage extends ReplyMessage { + public static class ContainsKeyValueReplyMessage extends ReplyMessage { /** Propagated exception from remote node to operation initiator */ private boolean containsKeyValue; http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/CreateBucketMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/CreateBucketMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/CreateBucketMessage.java index 744e013..90f3396 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/CreateBucketMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/CreateBucketMessage.java @@ -55,7 +55,7 @@ import org.apache.geode.internal.logging.log4j.LogMarker; * @since GemFire 6.0 * */ -public final class CreateBucketMessage extends PartitionMessage { +public class CreateBucketMessage extends PartitionMessage { private static final Logger logger = LogService.getLogger(); /** The key associated with the value that must be sent */ @@ -81,7 +81,7 @@ public final class CreateBucketMessage extends PartitionMessage { } @Override - final public int getProcessorType() { + public int getProcessorType() { return DistributionManager.WAITING_POOL_EXECUTOR; } @@ -194,7 +194,7 @@ public final class CreateBucketMessage extends PartitionMessage { * * @since GemFire 5.0 */ - public static final class CreateBucketReplyMessage extends ReplyMessage { + public static class CreateBucketReplyMessage extends ReplyMessage { private InternalDistributedMember primary; /** http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/CreateMissingBucketsTask.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/CreateMissingBucketsTask.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/CreateMissingBucketsTask.java index e72e2cf..18503c5 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/CreateMissingBucketsTask.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/CreateMissingBucketsTask.java @@ -24,7 +24,7 @@ import org.apache.geode.internal.cache.PartitionedRegion.RecoveryLock; * A task for creating buckets in a child colocated region that are present in the leader region. * */ -public final class CreateMissingBucketsTask extends RecoveryRunnable { +public class CreateMissingBucketsTask extends RecoveryRunnable { public CreateMissingBucketsTask(PRHARedundancyProvider prhaRedundancyProvider) { super(prhaRedundancyProvider); } http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DeposePrimaryBucketMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DeposePrimaryBucketMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DeposePrimaryBucketMessage.java index f305fa8..f1633bd 100755 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DeposePrimaryBucketMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DeposePrimaryBucketMessage.java @@ -134,7 +134,7 @@ public class DeposePrimaryBucketMessage extends PartitionMessage { out.writeInt(this.bucketId); } - public static final class DeposePrimaryBucketReplyMessage extends ReplyMessage { + public static class DeposePrimaryBucketReplyMessage extends ReplyMessage { /** * Empty constructor to conform to DataSerializable interface http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DestroyMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DestroyMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DestroyMessage.java index bffaf4d..7009a98 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DestroyMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DestroyMessage.java @@ -442,19 +442,19 @@ public class DestroyMessage extends PartitionMessageWithDirectReply { } } - protected final Object getKey() { + protected Object getKey() { return this.key; } - private final void setKey(Object key) { + private void setKey(Object key) { this.key = key; } - public final Operation getOperation() { + public Operation getOperation() { return this.op; } - protected final Object getCallbackArg() { + protected Object getCallbackArg() { return this.cbArg; } http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DestroyRegionOnDataStoreMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DestroyRegionOnDataStoreMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DestroyRegionOnDataStoreMessage.java index 9bbc39d..d0c959c 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DestroyRegionOnDataStoreMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DestroyRegionOnDataStoreMessage.java @@ -41,7 +41,7 @@ import org.apache.geode.internal.cache.PartitionedRegionDataStore; * * @since GemFire 5.0 */ -public final class DestroyRegionOnDataStoreMessage extends PartitionMessage { +public class DestroyRegionOnDataStoreMessage extends PartitionMessage { private Object callbackArg; @@ -101,13 +101,13 @@ public final class DestroyRegionOnDataStoreMessage extends PartitionMessage { } @Override - public final void fromData(final DataInput in) throws IOException, ClassNotFoundException { + public void fromData(final DataInput in) throws IOException, ClassNotFoundException { super.fromData(in); callbackArg = DataSerializer.readObject(in); } @Override - public final void toData(final DataOutput out) throws IOException { + public void toData(final DataOutput out) throws IOException { super.toData(out); DataSerializer.writeObject(callbackArg, out); } http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DumpAllPRConfigMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DumpAllPRConfigMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DumpAllPRConfigMessage.java index 08daeb7..07b293b 100755 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DumpAllPRConfigMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DumpAllPRConfigMessage.java @@ -32,7 +32,7 @@ import org.apache.geode.internal.logging.log4j.LogMarker; * * @see org.apache.geode.internal.cache.PartitionedRegion#sendDumpAllPartitionedRegions() */ -public final class DumpAllPRConfigMessage extends PartitionMessage { +public class DumpAllPRConfigMessage extends PartitionMessage { private static final Logger logger = LogService.getLogger(); public DumpAllPRConfigMessage() {} http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DumpB2NRegion.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DumpB2NRegion.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DumpB2NRegion.java index 6314f2d..220c51f 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DumpB2NRegion.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DumpB2NRegion.java @@ -54,7 +54,7 @@ import org.apache.geode.internal.logging.log4j.LogMarker; * * @see org.apache.geode.internal.cache.PartitionedRegion#sendDumpB2NRegionForBucket(int) */ -public final class DumpB2NRegion extends PartitionMessage { +public class DumpB2NRegion extends PartitionMessage { private static final Logger logger = LogService.getLogger(); private int bucketId; @@ -167,7 +167,7 @@ public final class DumpB2NRegion extends PartitionMessage { - public static final class DumpB2NReplyMessage extends ReplyMessage { + public static class DumpB2NReplyMessage extends ReplyMessage { private PrimaryInfo primaryInfo; public DumpB2NReplyMessage() {} http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DumpBucketsMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DumpBucketsMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DumpBucketsMessage.java index d924b69..b8bd629 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DumpBucketsMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DumpBucketsMessage.java @@ -36,7 +36,7 @@ import org.apache.geode.internal.logging.log4j.LogMarker; * * @see org.apache.geode.internal.cache.PartitionedRegion#dumpAllBuckets(boolean) */ -public final class DumpBucketsMessage extends PartitionMessage { +public class DumpBucketsMessage extends PartitionMessage { private static final Logger logger = LogService.getLogger(); boolean validateOnly; http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/EndBucketCreationMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/EndBucketCreationMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/EndBucketCreationMessage.java index 0502d5f..355c3b5 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/EndBucketCreationMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/EndBucketCreationMessage.java @@ -90,8 +90,8 @@ public class EndBucketCreationMessage extends PartitionMessage { } @Override - protected final boolean operateOnPartitionedRegion(DistributionManager dm, - PartitionedRegion region, long startTime) throws ForceReattemptException { + protected boolean operateOnPartitionedRegion(DistributionManager dm, PartitionedRegion region, + long startTime) throws ForceReattemptException { // this is executing in the WAITING_POOL_EXECUTOR http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchBulkEntriesMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchBulkEntriesMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchBulkEntriesMessage.java index 41186ff..b767f6c 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchBulkEntriesMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchBulkEntriesMessage.java @@ -63,7 +63,7 @@ import org.apache.geode.internal.logging.log4j.LogMarker; * * @since GemFire 8.0 */ -public final class FetchBulkEntriesMessage extends PartitionMessage { +public class FetchBulkEntriesMessage extends PartitionMessage { private static final Logger logger = LogService.getLogger(); private HashSet<Integer> bucketIds; @@ -174,7 +174,7 @@ public final class FetchBulkEntriesMessage extends PartitionMessage { DataSerializer.writePrimitiveBoolean(this.allowTombstones, out); } - public static final class FetchBulkEntriesReplyMessage extends ReplyMessage { + public static class FetchBulkEntriesReplyMessage extends ReplyMessage { /** Whether this message is the last of a series of chunk responses */ boolean lastInSeries; http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchEntriesMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchEntriesMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchEntriesMessage.java index c7ca279..489ffba 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchEntriesMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchEntriesMessage.java @@ -65,7 +65,7 @@ import org.apache.geode.internal.logging.log4j.LogMarker; import org.apache.geode.internal.offheap.OffHeapHelper; import org.apache.geode.internal.util.ObjectIntProcedure; -public final class FetchEntriesMessage extends PartitionMessage { +public class FetchEntriesMessage extends PartitionMessage { private static final Logger logger = LogService.getLogger(); private int bucketId; @@ -150,7 +150,7 @@ public final class FetchEntriesMessage extends PartitionMessage { out.writeInt(this.bucketId); } - public static final class FetchEntriesReplyMessage extends ReplyMessage { + public static class FetchEntriesReplyMessage extends ReplyMessage { /** The bucket id */ int bucketId; http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchEntryMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchEntryMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchEntryMessage.java index 301e154..664ebe7 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchEntryMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchEntryMessage.java @@ -58,7 +58,7 @@ import org.apache.geode.internal.logging.log4j.LogMarker; * * @since GemFire 5.1 */ -public final class FetchEntryMessage extends PartitionMessage { +public class FetchEntryMessage extends PartitionMessage { private static final Logger logger = LogService.getLogger(); private Object key; @@ -218,7 +218,7 @@ public final class FetchEntryMessage extends PartitionMessage { * * @since GemFire 5.0 */ - public static final class FetchEntryReplyMessage extends ReplyMessage { + public static class FetchEntryReplyMessage extends ReplyMessage { /** Propagated exception from remote node to operation initiator */ private EntrySnapshot value; http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchKeysMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchKeysMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchKeysMessage.java index e1c708a..67d81ef 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchKeysMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchKeysMessage.java @@ -52,7 +52,7 @@ import org.apache.geode.internal.logging.log4j.LogMarker; import org.apache.geode.internal.util.ObjectIntProcedure; -public final class FetchKeysMessage extends PartitionMessage { +public class FetchKeysMessage extends PartitionMessage { private static final Logger logger = LogService.getLogger(); private Integer bucketId; @@ -217,7 +217,7 @@ public final class FetchKeysMessage extends PartitionMessage { out.writeBoolean(this.allowTombstones); } - public static final class FetchKeysReplyMessage extends ReplyMessage { + public static class FetchKeysReplyMessage extends ReplyMessage { /** The number of the series */ int seriesNum; /** The message number in the series */ http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchPartitionDetailsMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchPartitionDetailsMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchPartitionDetailsMessage.java index 5f4dec1..21dfa8d 100755 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchPartitionDetailsMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchPartitionDetailsMessage.java @@ -145,7 +145,7 @@ public class FetchPartitionDetailsMessage extends PartitionMessage { DataSerializer.writeObject(loadProbe, out); } - public static final class FetchPartitionDetailsReplyMessage extends ReplyMessage { + public static class FetchPartitionDetailsReplyMessage extends ReplyMessage { static final byte NO_PARTITION = 0; static final byte OK = 1; http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FlushMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FlushMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FlushMessage.java index 96d838d..34d530b 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FlushMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FlushMessage.java @@ -48,7 +48,7 @@ import org.apache.geode.internal.logging.LogService; * * @since GemFire 5.1 */ -public final class FlushMessage extends SerialDistributionMessage implements MessageWithReply { +public class FlushMessage extends SerialDistributionMessage implements MessageWithReply { private static final Logger logger = LogService.getLogger(); private static final long serialVersionUID = 1L; http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/GetMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/GetMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/GetMessage.java index 1c2a6a7..d0cd938 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/GetMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/GetMessage.java @@ -64,7 +64,7 @@ import java.util.Set; * * @since GemFire 5.0 */ -public final class GetMessage extends PartitionMessageWithDirectReply { +public class GetMessage extends PartitionMessageWithDirectReply { private static final Logger logger = LogService.getLogger(); private Object key; @@ -102,7 +102,7 @@ public final class GetMessage extends PartitionMessageWithDirectReply { Boolean.getBoolean(DistributionConfig.GEMFIRE_PREFIX + "order-pr-gets"); @Override - final public int getProcessorType() { + public int getProcessorType() { if (!forceUseOfPRExecutor && !ORDER_PR_GETS && !isDirectAck()) { try { PartitionedRegion pr = PartitionedRegion.getPRFromId(this.regionId); @@ -145,8 +145,8 @@ public final class GetMessage extends PartitionMessageWithDirectReply { } @Override - protected final boolean operateOnPartitionedRegion(final DistributionManager dm, - PartitionedRegion r, long startTime) throws ForceReattemptException { + protected boolean operateOnPartitionedRegion(final DistributionManager dm, PartitionedRegion r, + long startTime) throws ForceReattemptException { if (logger.isTraceEnabled(LogMarker.DM)) { logger.trace(LogMarker.DM, "GetMessage operateOnRegion: {}", r.getFullPath()); } @@ -298,7 +298,7 @@ public final class GetMessage extends PartitionMessageWithDirectReply { * * @since GemFire 5.0 */ - public static final class GetReplyMessage extends ReplyMessage { + public static class GetReplyMessage extends ReplyMessage { /** * The raw value in the cache which may be serialized to the output stream, if it is NOT already * a byte array http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/IdentityRequestMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/IdentityRequestMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/IdentityRequestMessage.java index e8595fa..a99fd7a 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/IdentityRequestMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/IdentityRequestMessage.java @@ -42,7 +42,7 @@ import org.apache.geode.internal.logging.log4j.LogMarker; * * @since GemFire 5.0 */ -public final class IdentityRequestMessage extends DistributionMessage implements MessageWithReply { +public class IdentityRequestMessage extends DistributionMessage implements MessageWithReply { private static final Logger logger = LogService.getLogger(); private static final int UNINITIALIZED = -1; @@ -166,7 +166,7 @@ public final class IdentityRequestMessage extends DistributionMessage implements * * @since GemFire 5.0 */ - public static final class IdentityReplyMessage extends HighPriorityDistributionMessage { + public static class IdentityReplyMessage extends HighPriorityDistributionMessage { private int Id = UNINITIALIZED; /** The shared obj id of the ReplyProcessor */ http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/IdentityUpdateMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/IdentityUpdateMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/IdentityUpdateMessage.java index 3ac9ee0..419e083 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/IdentityUpdateMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/IdentityUpdateMessage.java @@ -34,7 +34,7 @@ import org.apache.geode.internal.logging.LogService; import org.apache.geode.internal.logging.log4j.LogMarker; -public final class IdentityUpdateMessage extends DistributionMessage implements MessageWithReply { +public class IdentityUpdateMessage extends DistributionMessage implements MessageWithReply { private static final Logger logger = LogService.getLogger(); private int processorId; http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/IndexCreationMsg.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/IndexCreationMsg.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/IndexCreationMsg.java index 86c47e7..dc76652 100755 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/IndexCreationMsg.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/IndexCreationMsg.java @@ -90,7 +90,7 @@ public class IndexCreationMsg extends PartitionMessage { * of the initialization */ @Override - protected final boolean failIfRegionMissing() { + protected boolean failIfRegionMissing() { return false; } @@ -179,7 +179,7 @@ public class IndexCreationMsg extends PartitionMessage { * Process this index creation message on the receiver. */ @Override - public final void process(final DistributionManager dm) { + public void process(final DistributionManager dm) { final boolean isDebugEnabled = logger.isDebugEnabled(); @@ -413,7 +413,7 @@ public class IndexCreationMsg extends PartitionMessage { } @Override - public final void fromData(DataInput in) throws IOException, ClassNotFoundException { + public void fromData(DataInput in) throws IOException, ClassNotFoundException { super.fromData(in); this.indexDefinitions = DataSerializer.readHashSet(in); } @@ -424,7 +424,7 @@ public class IndexCreationMsg extends PartitionMessage { } @Override - public final void toData(DataOutput out) throws IOException { + public void toData(DataOutput out) throws IOException { super.toData(out); DataSerializer.writeHashSet(this.indexDefinitions, out); } @@ -433,7 +433,7 @@ public class IndexCreationMsg extends PartitionMessage { * String representation of this message. */ @Override - public final String toString() { + public String toString() { StringBuffer sb = new StringBuffer(); for (IndexCreationData icd : indexDefinitions) { sb.append(icd.getIndexName()).append(" "); @@ -546,7 +546,7 @@ public class IndexCreationMsg extends PartitionMessage { * * */ - public static final class IndexCreationReplyMsg extends ReplyMessage { + public static class IndexCreationReplyMsg extends ReplyMessage { /** Index created or not. */ private boolean result; @@ -634,7 +634,7 @@ public class IndexCreationMsg extends PartitionMessage { * @param dm distribution manager */ @Override - public final void process(final DM dm, final ReplyProcessor21 p) { + public void process(final DM dm, final ReplyProcessor21 p) { if (logger.isDebugEnabled()) { logger.debug("Processor id is : {}", this.processorId); } http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/InterestEventMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/InterestEventMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/InterestEventMessage.java index 8259818..227c74e 100755 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/InterestEventMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/InterestEventMessage.java @@ -63,13 +63,13 @@ public class InterestEventMessage extends PartitionMessage { } @Override - final public int getProcessorType() { + public int getProcessorType() { return DistributionManager.STANDARD_EXECUTOR; } @Override - protected final boolean operateOnPartitionedRegion(final DistributionManager dm, - PartitionedRegion r, long startTime) throws ForceReattemptException { + protected boolean operateOnPartitionedRegion(final DistributionManager dm, PartitionedRegion r, + long startTime) throws ForceReattemptException { if (logger.isTraceEnabled(LogMarker.DM)) { logger.debug("InterestEventMessage operateOnPartitionedRegion: {}", r.getFullPath()); } http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/InvalidateMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/InvalidateMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/InvalidateMessage.java index 8db893a..00db87c 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/InvalidateMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/InvalidateMessage.java @@ -53,7 +53,7 @@ import org.apache.geode.internal.logging.LogService; import org.apache.geode.internal.logging.log4j.LogMarker; import org.apache.geode.internal.offheap.annotations.Released; -public final class InvalidateMessage extends DestroyMessage { +public class InvalidateMessage extends DestroyMessage { private static final Logger logger = LogService.getLogger(); /** @@ -247,7 +247,7 @@ public final class InvalidateMessage extends DestroyMessage { return PR_INVALIDATE_MESSAGE; } - public static final class InvalidateReplyMessage extends ReplyMessage { + public static class InvalidateReplyMessage extends ReplyMessage { VersionTag versionTag; /** http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/ManageBackupBucketMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/ManageBackupBucketMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/ManageBackupBucketMessage.java index 786006e..cca8953 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/ManageBackupBucketMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/ManageBackupBucketMessage.java @@ -48,7 +48,7 @@ import org.apache.geode.internal.logging.log4j.LogMarker; * @since GemFire 5.0 * */ -public final class ManageBackupBucketMessage extends PartitionMessage { +public class ManageBackupBucketMessage extends PartitionMessage { private static final Logger logger = LogService.getLogger(); /** The key associated with the value that must be sent */ @@ -85,7 +85,7 @@ public final class ManageBackupBucketMessage extends PartitionMessage { } @Override - final public int getProcessorType() { + public int getProcessorType() { return DistributionManager.WAITING_POOL_EXECUTOR; } @@ -217,7 +217,7 @@ public final class ManageBackupBucketMessage extends PartitionMessage { * * @since GemFire 5.0 */ - public static final class ManageBackupBucketReplyMessage extends ReplyMessage { + public static class ManageBackupBucketReplyMessage extends ReplyMessage { protected boolean acceptedBucket; http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/ManageBucketMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/ManageBucketMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/ManageBucketMessage.java index 1092145..7e84404 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/ManageBucketMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/ManageBucketMessage.java @@ -48,7 +48,7 @@ import org.apache.geode.internal.logging.log4j.LogMarker; * @since GemFire 5.0 * */ -public final class ManageBucketMessage extends PartitionMessage { +public class ManageBucketMessage extends PartitionMessage { private static final Logger logger = LogService.getLogger(); /** The key associated with the value that must be sent */ @@ -80,7 +80,7 @@ public final class ManageBucketMessage extends PartitionMessage { } @Override - final public int getProcessorType() { + public int getProcessorType() { return DistributionManager.WAITING_POOL_EXECUTOR; } @@ -211,7 +211,7 @@ public final class ManageBucketMessage extends PartitionMessage { * * @since GemFire 5.0 */ - public static final class ManageBucketReplyMessage extends ReplyMessage { + public static class ManageBucketReplyMessage extends ReplyMessage { protected boolean acceptedBucket; http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/MoveBucketMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/MoveBucketMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/MoveBucketMessage.java index 8a607c0..6f18013 100755 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/MoveBucketMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/MoveBucketMessage.java @@ -143,7 +143,7 @@ public class MoveBucketMessage extends PartitionMessage { DataSerializer.writeObject(this.source, out); } - public static final class MoveBucketReplyMessage extends ReplyMessage { + public static class MoveBucketReplyMessage extends ReplyMessage { private boolean moved; http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PRLoad.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PRLoad.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PRLoad.java index a125dbe..1cbad83 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PRLoad.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PRLoad.java @@ -27,7 +27,7 @@ import org.apache.geode.DataSerializer; * * @since GemFire 6.0 */ -public final class PRLoad implements DataSerializable { +public class PRLoad implements DataSerializable { private static final long serialVersionUID = 778886995284953922L; private final float weight; http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PRSanityCheckMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PRSanityCheckMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PRSanityCheckMessage.java index 5c5af24..e835fce 100755 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PRSanityCheckMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PRSanityCheckMessage.java @@ -39,7 +39,7 @@ import java.util.Set; * * */ -public final class PRSanityCheckMessage extends PartitionMessage { +public class PRSanityCheckMessage extends PartitionMessage { private String regionName; http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PRTombstoneMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PRTombstoneMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PRTombstoneMessage.java index 3552b5d..0e27621 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PRTombstoneMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PRTombstoneMessage.java @@ -50,7 +50,7 @@ import org.apache.geode.internal.logging.log4j.LogMarker; * * @since GemFire 7.0 */ -public final class PRTombstoneMessage extends PartitionMessageWithDirectReply +public class PRTombstoneMessage extends PartitionMessageWithDirectReply implements SerializationVersions { private static final Logger logger = LogService.getLogger(); @@ -93,8 +93,8 @@ public final class PRTombstoneMessage extends PartitionMessageWithDirectReply } @Override - protected final boolean operateOnPartitionedRegion(final DistributionManager dm, - PartitionedRegion r, long startTime) throws ForceReattemptException { + protected boolean operateOnPartitionedRegion(final DistributionManager dm, PartitionedRegion r, + long startTime) throws ForceReattemptException { if (logger.isTraceEnabled(LogMarker.DM)) { logger.debug("PRTombstoneMessage operateOnRegion: {}", r.getFullPath()); } http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PRUpdateEntryVersionMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PRUpdateEntryVersionMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PRUpdateEntryVersionMessage.java index eb7dcaf..b214075 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PRUpdateEntryVersionMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PRUpdateEntryVersionMessage.java @@ -221,7 +221,7 @@ public class PRUpdateEntryVersionMessage extends PartitionMessageWithDirectReply * Response for PartitionMessage {@link PRUpdateEntryVersionMessage}. * */ - public static final class UpdateEntryVersionResponse extends PartitionResponse { + public static class UpdateEntryVersionResponse extends PartitionResponse { private volatile boolean versionUpdated; private final Object key; http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PartitionMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PartitionMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PartitionMessage.java index 5129044..6b59f51 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PartitionMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PartitionMessage.java @@ -227,7 +227,7 @@ public abstract class PartitionMessage extends DistributionMessage * @return the compact value that will be sent which represents the PartitionedRegion * @see PartitionedRegion#getPRId() */ - public final int getRegionId() { + public int getRegionId() { return regionId; } @@ -236,7 +236,7 @@ public abstract class PartitionMessage extends DistributionMessage * is required. */ @Override - public final int getProcessorId() { + public int getProcessorId() { return this.processorId; } @@ -244,7 +244,7 @@ public abstract class PartitionMessage extends DistributionMessage * @param processorId1 the {@link org.apache.geode.distributed.internal.ReplyProcessor21} id * associated with the message, null if no acknowlegement is required. */ - public final void registerProcessor(int processorId1) { + public void registerProcessor(int processorId1) { this.processorId = processorId1; } @@ -677,7 +677,7 @@ public abstract class PartitionMessage extends DistributionMessage /** * @return the txUniqId */ - public final int getTXUniqId() { + public int getTXUniqId() { return txUniqId; } @@ -694,7 +694,7 @@ public abstract class PartitionMessage extends DistributionMessage return true; } - protected final boolean _mayAddToMultipleSerialGateways(DistributionManager dm) { + protected boolean _mayAddToMultipleSerialGateways(DistributionManager dm) { try { PartitionedRegion pr = PartitionedRegion.getPRFromId(this.regionId); if (pr == null) { @@ -786,7 +786,7 @@ public abstract class PartitionMessage extends DistributionMessage * @throws ForceReattemptException if the recipient left the distributed system before the * response was received. */ - final public void waitForCacheException() + public void waitForCacheException() throws CacheException, ForceReattemptException, PrimaryBucketException { try { waitForRepliesUninterruptibly(); http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PartitionedRegionFunctionStreamingMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PartitionedRegionFunctionStreamingMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PartitionedRegionFunctionStreamingMessage.java index f7ca7e6..2a37afc 100755 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PartitionedRegionFunctionStreamingMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PartitionedRegionFunctionStreamingMessage.java @@ -66,7 +66,7 @@ public class PartitionedRegionFunctionStreamingMessage extends PartitionMessage } @Override - final public int getProcessorType() { + public int getProcessorType() { return DistributionManager.REGION_FUNCTION_EXECUTION_EXECUTOR; } http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PartitionedRegionObserverHolder.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PartitionedRegionObserverHolder.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PartitionedRegionObserverHolder.java index 888809d..e8241db 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PartitionedRegionObserverHolder.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PartitionedRegionObserverHolder.java @@ -40,7 +40,7 @@ public class PartitionedRegionObserverHolder { /** * Set the given observer to be notified of events. Returns the current observer. */ - public static final PartitionedRegionObserver setInstance(PartitionedRegionObserver observer) { + public static PartitionedRegionObserver setInstance(PartitionedRegionObserver observer) { Support.assertArg(observer != null, "setInstance expects a non-null argument!"); PartitionedRegionObserver oldObserver = _instance; _instance = observer; @@ -48,7 +48,7 @@ public class PartitionedRegionObserverHolder { } /** Return the current ClientServerObserver instance */ - public static final PartitionedRegionObserver getInstance() { + public static PartitionedRegionObserver getInstance() { return _instance; } http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PrimaryRequestMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PrimaryRequestMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PrimaryRequestMessage.java index 75bd0b6..f053d5f 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PrimaryRequestMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PrimaryRequestMessage.java @@ -46,7 +46,7 @@ import org.apache.geode.internal.logging.log4j.LogMarker; * * */ -public final class PrimaryRequestMessage extends PartitionMessage { +public class PrimaryRequestMessage extends PartitionMessage { private static final Logger logger = LogService.getLogger(); private static final long serialVersionUID = 1L; @@ -136,7 +136,7 @@ public final class PrimaryRequestMessage extends PartitionMessage { /** * The reply to a PrimarRequestMessage, indicating if the sender is the primary */ - static public final class PrimaryRequestReplyMessage extends ReplyMessage { + static public class PrimaryRequestReplyMessage extends ReplyMessage { private static final long serialVersionUID = 1L; public volatile boolean isPrimary; http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PutMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PutMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PutMessage.java index 1c41e61..b43bfc4 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PutMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PutMessage.java @@ -75,7 +75,7 @@ import static org.apache.geode.internal.offheap.annotations.OffHeapIdentifier.EN * * @since GemFire 5.0 */ -public final class PutMessage extends PartitionMessageWithDirectReply implements NewValueImporter { +public class PutMessage extends PartitionMessageWithDirectReply implements NewValueImporter { private static final Logger logger = LogService.getLogger(); /** The key associated with the value that must be sent */ @@ -437,15 +437,15 @@ public final class PutMessage extends PartitionMessageWithDirectReply implements return e2; } - public final Object getKey() { + public Object getKey() { return this.key; } - public final void setKey(Object key) { + public void setKey(Object key) { this.key = key; } - public final byte[] getValBytes() { + public byte[] getValBytes() { return this.valBytes; } @@ -468,16 +468,16 @@ public final class PutMessage extends PartitionMessageWithDirectReply implements } } - public final Object getCallbackArg() { + public Object getCallbackArg() { return this.cbArg; } - protected final Operation getOperation() { + protected Operation getOperation() { return this.op; } @Override - public final void setOperation(Operation operation) { + public void setOperation(Operation operation) { this.op = operation; } @@ -509,7 +509,7 @@ public final class PutMessage extends PartitionMessageWithDirectReply implements } @Override - public final void fromData(DataInput in) throws IOException, ClassNotFoundException { + public void fromData(DataInput in) throws IOException, ClassNotFoundException { super.fromData(in); final int extraFlags = in.readUnsignedByte(); @@ -567,7 +567,7 @@ public final class PutMessage extends PartitionMessageWithDirectReply implements * buff.append("; oldvalue object="+this.oldValObj); buff.toString(); return buff.toString(); } */ @Override - public final void toData(DataOutput out) throws IOException { + public void toData(DataOutput out) throws IOException { PartitionedRegion region = null; try { boolean flag = internalDs.getConfig().getDeltaPropagation(); @@ -675,7 +675,7 @@ public final class PutMessage extends PartitionMessageWithDirectReply implements * indefinitely for the acknowledgement */ @Override - protected final boolean operateOnPartitionedRegion(DistributionManager dm, PartitionedRegion r, + protected boolean operateOnPartitionedRegion(DistributionManager dm, PartitionedRegion r, long startTime) throws EntryExistsException, DataLocationException, IOException { this.setInternalDs(r.getSystem());// set the internal DS. Required to // checked DS level delta-enabled property @@ -823,7 +823,7 @@ public final class PutMessage extends PartitionMessageWithDirectReply implements @Override - protected final void appendFields(StringBuilder buff) { + protected void appendFields(StringBuilder buff) { super.appendFields(buff); buff.append("; key=").append(getKey()).append("; value="); // buff.append(getValBytes()); @@ -864,11 +864,11 @@ public final class PutMessage extends PartitionMessageWithDirectReply implements } } - public final InternalDistributedSystem getInternalDs() { + public InternalDistributedSystem getInternalDs() { return internalDs; } - public final void setInternalDs(InternalDistributedSystem internalDs) { + public void setInternalDs(InternalDistributedSystem internalDs) { this.internalDs = internalDs; } @@ -877,7 +877,7 @@ public final class PutMessage extends PartitionMessageWithDirectReply implements return _mayAddToMultipleSerialGateways(dm); } - public static final class PutReplyMessage extends ReplyMessage implements OldValueImporter { + public static class PutReplyMessage extends ReplyMessage implements OldValueImporter { /** Result of the Put operation */ boolean result; http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/QueryMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/QueryMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/QueryMessage.java index b6028fe..bbd9d9c 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/QueryMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/QueryMessage.java @@ -54,7 +54,7 @@ import org.apache.geode.internal.logging.LogService; import org.apache.geode.internal.logging.log4j.LogMarker; import org.apache.geode.cache.query.Struct; -public final class QueryMessage extends StreamingPartitionOperation.StreamingPartitionMessage { +public class QueryMessage extends StreamingPartitionOperation.StreamingPartitionMessage { private static final Logger logger = LogService.getLogger(); private volatile String queryString; http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RegionAdvisor.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RegionAdvisor.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RegionAdvisor.java index 8f4c65c..c473d2d 100755 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RegionAdvisor.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RegionAdvisor.java @@ -515,7 +515,7 @@ public class RegionAdvisor extends CacheDistributionAdvisor { /** * Profile information for a remote counterpart. */ - public static final class PartitionProfile extends CacheProfile { + public static class PartitionProfile extends CacheProfile { /** * The number of Mb the VM is allowed to use for the PR @@ -568,7 +568,7 @@ public class RegionAdvisor extends CacheDistributionAdvisor { } @Override - protected final int getIntInfo() { + protected int getIntInfo() { int s = super.getIntInfo(); if (this.requiresNotification) s |= REQUIRES_NOTIFICATION_MASK; @@ -576,7 +576,7 @@ public class RegionAdvisor extends CacheDistributionAdvisor { } @Override - protected final void setIntInfo(int s) { + protected void setIntInfo(int s) { super.setIntInfo(s); this.requiresNotification = (s & REQUIRES_NOTIFICATION_MASK) != 0; } @@ -598,7 +598,7 @@ public class RegionAdvisor extends CacheDistributionAdvisor { out.writeInt(this.shutDownAllStatus); } - // public final StoppableReentrantReadWriteLock.StoppableReadLock + // public StoppableReentrantReadWriteLock.StoppableReadLock // getIsClosingReadLock(CancelCriterion stopper) { // synchronized (this) { // if (isClosingLock == null) { @@ -608,7 +608,7 @@ public class RegionAdvisor extends CacheDistributionAdvisor { // return this.isClosingLock.readLock(); // } - // public final Lock getIsClosingWriteLock() { + // public Lock getIsClosingWriteLock() { // return this.isClosingLock.writeLock(); // } @@ -1055,7 +1055,7 @@ public class RegionAdvisor extends CacheDistributionAdvisor { } @Override - final synchronized public boolean putProfile(Profile p) { + synchronized public boolean putProfile(Profile p) { assert p instanceof CacheProfile; CacheProfile profile = (CacheProfile) p; PartitionedRegion pr = getPartitionedRegion(); @@ -1072,7 +1072,7 @@ public class RegionAdvisor extends CacheDistributionAdvisor { return super.putProfile(profile); } - final public PartitionProfile getPartitionProfile(InternalDistributedMember id) { + public PartitionProfile getPartitionProfile(InternalDistributedMember id) { return (PartitionProfile) getProfile(id); } @@ -1209,7 +1209,7 @@ public class RegionAdvisor extends CacheDistributionAdvisor { * @param bucketId * @return the Node managing the primary copy of the bucket */ - final public InternalDistributedMember getPrimaryMemberForBucket(int bucketId) { + public InternalDistributedMember getPrimaryMemberForBucket(int bucketId) { Assert.assertTrue(this.buckets != null); Bucket b = this.buckets[bucketId]; return b.getBucketAdvisor().getPrimary(); http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RemoteSizeMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RemoteSizeMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RemoteSizeMessage.java index 6e4acff..fd0ebd4 100755 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RemoteSizeMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RemoteSizeMessage.java @@ -45,7 +45,7 @@ import org.apache.geode.internal.logging.log4j.LogMarker; * * @since GemFire 5.0 */ -public final class RemoteSizeMessage extends RemoteOperationMessage { +public class RemoteSizeMessage extends RemoteOperationMessage { private static final Logger logger = LogService.getLogger(); /** query type for Entries */ @@ -120,7 +120,7 @@ public final class RemoteSizeMessage extends RemoteOperationMessage { * of the initialization */ @Override - protected final boolean failIfRegionMissing() { + protected boolean failIfRegionMissing() { return false; } @@ -179,7 +179,7 @@ public final class RemoteSizeMessage extends RemoteOperationMessage { out.writeByte((byte) queryType); } - public static final class SizeReplyMessage extends ReplyMessage { + public static class SizeReplyMessage extends ReplyMessage { /** Propagated exception from remote node to operation initiator */ private int size; http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RemoveAllPRMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RemoveAllPRMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RemoveAllPRMessage.java index 5f05e4b..7ee54d8 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RemoveAllPRMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RemoveAllPRMessage.java @@ -77,7 +77,7 @@ import org.apache.geode.internal.offheap.annotations.Retained; * * @since GemFire 8.1 */ -public final class RemoveAllPRMessage extends PartitionMessageWithDirectReply { +public class RemoveAllPRMessage extends PartitionMessageWithDirectReply { private static final Logger logger = LogService.getLogger(); private RemoveAllEntryData[] removeAllPRData; @@ -307,7 +307,7 @@ public final class RemoveAllPRMessage extends PartitionMessageWithDirectReply { * indefinitely for the acknowledgement */ @Override - protected final boolean operateOnPartitionedRegion(DistributionManager dm, PartitionedRegion r, + protected boolean operateOnPartitionedRegion(DistributionManager dm, PartitionedRegion r, long startTime) throws EntryExistsException, ForceReattemptException, DataLocationException { boolean sendReply = true; @@ -358,7 +358,7 @@ public final class RemoveAllPRMessage extends PartitionMessageWithDirectReply { * @return If succeeds, return true, otherwise, throw exception */ @edu.umd.cs.findbugs.annotations.SuppressWarnings(value = "IMSE_DONT_CATCH_IMSE") - public final boolean doLocalRemoveAll(PartitionedRegion r, InternalDistributedMember eventSender, + public boolean doLocalRemoveAll(PartitionedRegion r, InternalDistributedMember eventSender, boolean cacheWrite) throws EntryExistsException, ForceReattemptException, DataLocationException { boolean didRemove = false; @@ -647,15 +647,15 @@ public final class RemoveAllPRMessage extends PartitionMessageWithDirectReply { } } - public final InternalDistributedSystem getInternalDs() { + public InternalDistributedSystem getInternalDs() { return internalDs; } - public final void setInternalDs(InternalDistributedSystem internalDs) { + public void setInternalDs(InternalDistributedSystem internalDs) { this.internalDs = internalDs; } - public final void setDirectAck(boolean directAck) { + public void setDirectAck(boolean directAck) { this.directAck = directAck; } @@ -664,7 +664,7 @@ public final class RemoveAllPRMessage extends PartitionMessageWithDirectReply { return _mayAddToMultipleSerialGateways(dm); } - public static final class RemoveAllReplyMessage extends ReplyMessage { + public static class RemoveAllReplyMessage extends ReplyMessage { /** Result of the RemoveAll operation */ boolean result; VersionedObjectList versions; http://git-wip-us.apache.org/repos/asf/geode/blob/a4458531/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RemoveBucketMessage.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RemoveBucketMessage.java b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RemoveBucketMessage.java index 6336841..a8ff068 100755 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RemoveBucketMessage.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RemoveBucketMessage.java @@ -139,7 +139,7 @@ public class RemoveBucketMessage extends PartitionMessage { out.writeBoolean(this.forceRemovePrimary); } - public static final class RemoveBucketReplyMessage extends ReplyMessage { + public static class RemoveBucketReplyMessage extends ReplyMessage { private boolean removed;
