GEODE-3050: prevent empty dat files Move creation of dat files to test methods to avoid overwriting full dat file from other test.
Project: http://git-wip-us.apache.org/repos/asf/geode/repo Commit: http://git-wip-us.apache.org/repos/asf/geode/commit/b0718f5d Tree: http://git-wip-us.apache.org/repos/asf/geode/tree/b0718f5d Diff: http://git-wip-us.apache.org/repos/asf/geode/diff/b0718f5d Branch: refs/heads/feature/GEODE-2558 Commit: b0718f5da6c70c35edbfa9104378ac63bb0a70c3 Parents: d73fa3c Author: Kirk Lund <[email protected]> Authored: Wed Jun 7 16:55:54 2017 -0700 Committer: Kirk Lund <[email protected]> Committed: Wed Jun 7 17:02:11 2017 -0700 ---------------------------------------------------------------------- .../codeAnalysis/AnalyzeSerializablesJUnitTest.java | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/geode/blob/b0718f5d/geode-core/src/test/java/org/apache/geode/codeAnalysis/AnalyzeSerializablesJUnitTest.java ---------------------------------------------------------------------- diff --git a/geode-core/src/test/java/org/apache/geode/codeAnalysis/AnalyzeSerializablesJUnitTest.java b/geode-core/src/test/java/org/apache/geode/codeAnalysis/AnalyzeSerializablesJUnitTest.java index dc73f04..2ba11a2 100644 --- a/geode-core/src/test/java/org/apache/geode/codeAnalysis/AnalyzeSerializablesJUnitTest.java +++ b/geode-core/src/test/java/org/apache/geode/codeAnalysis/AnalyzeSerializablesJUnitTest.java @@ -89,11 +89,6 @@ public class AnalyzeSerializablesJUnitTest { this.expectedSerializables = loadClassesAndVariables(expectedSerializablesFile); Collections.sort(this.expectedSerializables); - - // setup empty actual files - - this.actualDataSerializablesFile = createEmptyFile("actualDataSerializables.dat"); - this.actualSerializablesFile = createEmptyFile("actualSerializables.dat"); } /** @@ -107,6 +102,10 @@ public class AnalyzeSerializablesJUnitTest { public void testDataSerializables() throws Exception { System.out.println(this.testName.getMethodName() + " starting"); + this.actualDataSerializablesFile = createEmptyFile("actualDataSerializables.dat"); + System.out.println(this.testName.getMethodName() + " actualDataSerializablesFile=" + + this.actualDataSerializablesFile.getAbsolutePath()); + List<ClassAndMethods> actualDataSerializables = findToDatasAndFromDatas(); storeClassesAndMethods(actualDataSerializables, this.actualDataSerializablesFile); @@ -128,6 +127,10 @@ public class AnalyzeSerializablesJUnitTest { public void testSerializables() throws Exception { System.out.println(this.testName.getMethodName() + " starting"); + this.actualSerializablesFile = createEmptyFile("actualSerializables.dat"); + System.out.println(this.testName.getMethodName() + " actualSerializablesFile=" + + this.actualSerializablesFile.getAbsolutePath()); + List<ClassAndVariables> actualSerializables = findSerializables(); storeClassesAndVariables(actualSerializables, this.actualSerializablesFile);
