GEODE-2980: remove unnecessary explicit keywords from interfaces All the methods in an interface are implicitly public and abstract. All fields in the interface are implicitly public, static and final. Removing this from all the interface.
This closes #529 Project: http://git-wip-us.apache.org/repos/asf/geode/repo Commit: http://git-wip-us.apache.org/repos/asf/geode/commit/f7396e4c Tree: http://git-wip-us.apache.org/repos/asf/geode/tree/f7396e4c Diff: http://git-wip-us.apache.org/repos/asf/geode/diff/f7396e4c Branch: refs/heads/feature/GEODE-2980 Commit: f7396e4c72068b89549f92eee778e8e607b872e3 Parents: 65471c1 Author: Avinash <avin...@ampool.io> Authored: Tue May 23 09:25:02 2017 +0530 Committer: Kirk Lund <kl...@apache.org> Committed: Wed Jun 14 11:38:43 2017 -0700 ---------------------------------------------------------------------- .../session/internal/common/SessionCache.java | 12 +- .../session/internal/filter/SessionManager.java | 20 +- .../filter/attributes/SessionAttributes.java | 24 +- .../internal/jmx/SessionStatisticsMXBean.java | 6 +- .../modules/gatewaydelta/GatewayDelta.java | 6 +- .../modules/gatewaydelta/GatewayDeltaEvent.java | 2 +- .../modules/session/catalina/SessionCache.java | 36 +- .../session/catalina/SessionManager.java | 26 +- .../internal/DeltaSessionAttributeEvent.java | 2 +- .../apache/geode/modules/session/Callback.java | 2 +- .../annotations/ExperimentalJUnitTest.java | 4 +- .../java/org/apache/geode/DataSerializable.java | 8 +- .../main/java/org/apache/geode/LogWriter.java | 74 +- .../org/apache/geode/StatisticDescriptor.java | 14 +- .../main/java/org/apache/geode/Statistics.java | 98 +- .../org/apache/geode/StatisticsFactory.java | 18 +- .../java/org/apache/geode/StatisticsType.java | 10 +- .../org/apache/geode/StatisticsTypeFactory.java | 32 +- .../geode/admin/AdminDistributedSystem.java | 94 +- .../main/java/org/apache/geode/admin/Alert.java | 12 +- .../org/apache/geode/admin/AlertListener.java | 2 +- .../apache/geode/admin/CacheHealthConfig.java | 24 +- .../org/apache/geode/admin/CacheServer.java | 4 +- .../apache/geode/admin/CacheServerConfig.java | 8 +- .../java/org/apache/geode/admin/CacheVm.java | 2 +- .../org/apache/geode/admin/CacheVmConfig.java | 8 +- .../geode/admin/ConfigurationParameter.java | 24 +- .../geode/admin/DistributedSystemConfig.java | 142 +-- .../admin/DistributedSystemHealthConfig.java | 6 +- .../apache/geode/admin/DistributionLocator.java | 4 +- .../geode/admin/DistributionLocatorConfig.java | 12 +- .../org/apache/geode/admin/GemFireHealth.java | 30 +- .../apache/geode/admin/GemFireHealthConfig.java | 8 +- .../org/apache/geode/admin/ManagedEntity.java | 12 +- .../apache/geode/admin/ManagedEntityConfig.java | 20 +- .../apache/geode/admin/MemberHealthConfig.java | 24 +- .../java/org/apache/geode/admin/Statistic.java | 10 +- .../apache/geode/admin/StatisticResource.java | 14 +- .../org/apache/geode/admin/SystemMember.java | 36 +- .../geode/admin/SystemMemberBridgeServer.java | 60 +- .../apache/geode/admin/SystemMemberCache.java | 39 +- .../geode/admin/SystemMemberCacheEvent.java | 2 +- .../geode/admin/SystemMemberCacheListener.java | 8 +- .../geode/admin/SystemMemberCacheServer.java | 60 +- .../apache/geode/admin/SystemMemberRegion.java | 93 +- .../geode/admin/SystemMemberRegionEvent.java | 2 +- .../geode/admin/SystemMembershipEvent.java | 4 +- .../geode/admin/SystemMembershipListener.java | 6 +- .../ConfigurationParameterListener.java | 2 +- .../admin/internal/InternalManagedEntity.java | 26 +- .../admin/internal/ManagedEntityController.java | 12 +- .../java/org/apache/geode/admin/jmx/Agent.java | 26 +- .../org/apache/geode/admin/jmx/AgentConfig.java | 216 ++-- .../admin/jmx/internal/ManagedResource.java | 14 +- .../jmx/internal/RMIRegistryServiceMBean.java | 14 +- .../jmx/internal/StatAlertsAggregator.java | 20 +- .../admin/jmx/internal/SystemMemberJmx.java | 43 +- .../apache/geode/cache/AttributesMutator.java | 40 +- .../org/apache/geode/cache/CacheCallback.java | 2 +- .../java/org/apache/geode/cache/CacheEvent.java | 12 +- .../org/apache/geode/cache/CacheListener.java | 18 +- .../org/apache/geode/cache/CacheLoader.java | 2 +- .../org/apache/geode/cache/CacheStatistics.java | 12 +- .../geode/cache/CacheTransactionManager.java | 42 +- .../org/apache/geode/cache/CacheWriter.java | 10 +- .../org/apache/geode/cache/ClientSession.java | 18 +- .../org/apache/geode/cache/CustomExpiry.java | 2 +- .../java/org/apache/geode/cache/Declarable.java | 2 +- .../java/org/apache/geode/cache/DiskStore.java | 38 +- .../apache/geode/cache/DiskStoreFactory.java | 50 +- .../apache/geode/cache/DiskWriteAttributes.java | 12 +- .../geode/cache/DynamicRegionListener.java | 8 +- .../java/org/apache/geode/cache/EntryEvent.java | 16 +- .../org/apache/geode/cache/EntryOperation.java | 12 +- .../geode/cache/EvictionAttributesMutator.java | 2 +- .../geode/cache/FixedPartitionResolver.java | 3 +- .../org/apache/geode/cache/GemFireCache.java | 46 +- .../geode/cache/InterestRegistrationEvent.java | 16 +- .../cache/InterestRegistrationListener.java | 4 +- .../org/apache/geode/cache/LoaderHelper.java | 8 +- .../apache/geode/cache/PartitionAttributes.java | 26 +- .../apache/geode/cache/PartitionResolver.java | 4 +- .../java/org/apache/geode/cache/Region.java | 205 ++-- .../apache/geode/cache/RegionAttributes.java | 92 +- .../org/apache/geode/cache/RegionEvent.java | 2 +- .../geode/cache/RegionMembershipListener.java | 8 +- .../apache/geode/cache/RegionRoleListener.java | 4 +- .../org/apache/geode/cache/RegionService.java | 16 +- .../java/org/apache/geode/cache/RoleEvent.java | 2 +- .../geode/cache/SerializedCacheValue.java | 4 +- .../apache/geode/cache/TransactionEvent.java | 14 +- .../apache/geode/cache/TransactionListener.java | 6 +- .../apache/geode/cache/TransactionWriter.java | 2 +- .../geode/cache/asyncqueue/AsyncEvent.java | 4 +- .../cache/asyncqueue/AsyncEventListener.java | 2 +- .../geode/cache/asyncqueue/AsyncEventQueue.java | 34 +- .../asyncqueue/AsyncEventQueueFactory.java | 31 +- .../apache/geode/cache/client/ClientCache.java | 20 +- .../geode/cache/client/ClientRegionFactory.java | 47 +- .../org/apache/geode/cache/client/Pool.java | 56 +- .../apache/geode/cache/client/PoolFactory.java | 80 +- .../geode/cache/client/internal/AbstractOp.java | 2 +- .../cache/client/internal/ClientUpdater.java | 6 +- .../geode/cache/client/internal/Connection.java | 38 +- .../cache/client/internal/EndpointManager.java | 10 +- .../cache/client/internal/ExecutablePool.java | 29 +- .../cache/client/internal/QueueManager.java | 18 +- .../geode/cache/client/internal/QueueState.java | 14 +- .../cache/client/internal/ServerBlackList.java | 6 +- .../client/internal/ServerRegionDataAccess.java | 37 +- .../locator/wan/LocatorMembershipListener.java | 16 +- .../internal/pooling/ConnectionManager.java | 8 +- .../geode/cache/control/RebalanceFactory.java | 4 +- .../geode/cache/control/RebalanceOperation.java | 10 +- .../geode/cache/control/RebalanceResults.java | 20 +- .../geode/cache/control/ResourceManager.java | 24 +- .../apache/geode/cache/execute/Execution.java | 12 +- .../apache/geode/cache/execute/Function.java | 10 +- .../geode/cache/execute/FunctionContext.java | 8 +- .../cache/execute/RegionFunctionContext.java | 4 +- .../geode/cache/execute/ResultCollector.java | 10 +- .../geode/cache/execute/ResultSender.java | 6 +- .../cache/partition/PartitionListener.java | 10 +- .../cache/partition/PartitionMemberInfo.java | 10 +- .../cache/partition/PartitionRebalanceInfo.java | 30 +- .../cache/partition/PartitionRegionInfo.java | 16 +- .../geode/cache/persistence/PersistentID.java | 6 +- .../apache/geode/cache/query/Aggregator.java | 6 +- .../apache/geode/cache/query/CqAttributes.java | 4 +- .../geode/cache/query/CqAttributesMutator.java | 6 +- .../org/apache/geode/cache/query/CqEvent.java | 14 +- .../apache/geode/cache/query/CqListener.java | 4 +- .../org/apache/geode/cache/query/CqQuery.java | 30 +- .../geode/cache/query/CqServiceStatistics.java | 12 +- .../org/apache/geode/cache/query/CqState.java | 10 +- .../apache/geode/cache/query/CqStatistics.java | 8 +- .../geode/cache/query/CqStatusListener.java | 4 +- .../org/apache/geode/cache/query/Index.java | 20 +- .../geode/cache/query/IndexStatistics.java | 18 +- .../org/apache/geode/cache/query/Query.java | 21 +- .../apache/geode/cache/query/QueryService.java | 81 +- .../geode/cache/query/QueryStatistics.java | 4 +- .../apache/geode/cache/query/SelectResults.java | 12 +- .../org/apache/geode/cache/query/Struct.java | 6 +- .../geode/cache/query/internal/Filter.java | 27 +- .../cache/query/internal/HashingStrategy.java | 4 +- .../geode/cache/query/internal/Negatable.java | 2 +- .../cache/query/internal/QueryExecutor.java | 4 +- .../cache/query/internal/StructFields.java | 10 +- .../geode/cache/query/internal/cq/ClientCQ.java | 6 +- .../cache/query/internal/cq/CqService.java | 77 +- .../query/internal/cq/InternalCqQuery.java | 28 +- .../geode/cache/query/internal/cq/ServerCQ.java | 24 +- .../query/internal/index/IndexManager.java | 2 +- .../query/internal/index/IndexProtocol.java | 14 +- .../cache/query/internal/index/IndexStore.java | 42 +- .../index/IndexedExpressionEvaluator.java | 16 +- .../geode/cache/query/types/CollectionType.java | 6 +- .../apache/geode/cache/query/types/MapType.java | 4 +- .../geode/cache/query/types/ObjectType.java | 10 +- .../geode/cache/query/types/StructType.java | 2 +- .../apache/geode/cache/server/CacheServer.java | 104 +- .../cache/server/ClientSubscriptionConfig.java | 22 +- .../geode/cache/snapshot/SnapshotOptions.java | 2 +- .../geode/cache/util/GatewayConflictHelper.java | 4 +- .../cache/util/GatewayConflictResolver.java | 2 +- .../apache/geode/cache/util/GatewayEvent.java | 18 +- .../apache/geode/cache/util/ObjectSizer.java | 8 +- .../geode/cache/util/TimestampedEntryEvent.java | 8 +- .../geode/cache/wan/GatewayEventFilter.java | 6 +- .../wan/GatewayEventSubstitutionFilter.java | 2 +- .../geode/cache/wan/GatewayQueueEvent.java | 12 +- .../apache/geode/cache/wan/GatewayReceiver.java | 44 +- .../geode/cache/wan/GatewayReceiverFactory.java | 20 +- .../apache/geode/cache/wan/GatewaySender.java | 113 +- .../geode/cache/wan/GatewaySenderFactory.java | 43 +- .../geode/cache/wan/GatewayTransportFilter.java | 4 +- .../apache/geode/compression/Compressor.java | 4 +- .../geode/distributed/ClientSocketFactory.java | 2 +- .../geode/distributed/DistributedMember.java | 14 +- .../java/org/apache/geode/distributed/Role.java | 6 +- .../geode/distributed/internal/CacheTime.java | 2 +- .../apache/geode/distributed/internal/DM.java | 138 ++- .../geode/distributed/internal/DMStats.java | 352 +++--- .../geode/distributed/internal/DSClock.java | 8 +- .../internal/DistributionAdvisee.java | 20 +- .../internal/DistributionAdvisor.java | 8 +- .../distributed/internal/HealthMonitor.java | 8 +- .../internal/InternalDistributedSystem.java | 17 +- .../geode/distributed/internal/MQueue.java | 2 +- .../internal/MembershipListener.java | 8 +- .../distributed/internal/MessageWithReply.java | 4 +- .../distributed/internal/PoolStatHelper.java | 4 +- .../distributed/internal/QueueStatHelper.java | 6 +- .../geode/distributed/internal/ReplySender.java | 2 +- .../geode/distributed/internal/Sizeable.java | 2 +- .../internal/ThrottledMemQueueStatHelper.java | 8 +- .../internal/ThrottledQueueStatHelper.java | 4 +- .../internal/WanLocatorDiscoverer.java | 2 +- .../internal/deadlock/DependencyMonitor.java | 4 +- .../internal/direct/DirectChannelListener.java | 4 +- .../distributed/internal/locks/DLockBatch.java | 8 +- .../internal/locks/DLockBatchId.java | 2 +- .../locks/DLockLessorDepartureHandler.java | 2 +- .../locks/DLockRecoverGrantorProcessor.java | 4 +- .../internal/locks/DistributedLockStats.java | 204 ++-- .../internal/locks/DistributedMemberLock.java | 2 +- .../DistributedMembershipListener.java | 20 +- .../internal/membership/MemberServices.java | 14 +- .../internal/membership/MembershipManager.java | 77 +- .../internal/membership/MembershipTestHook.java | 4 +- .../internal/membership/NetMember.java | 62 +- .../internal/membership/QuorumChecker.java | 12 +- .../internal/membership/gms/NetLocator.java | 2 +- .../gms/interfaces/HealthMonitor.java | 10 +- .../membership/gms/interfaces/JoinLeave.java | 2 +- .../gms/interfaces/MessageHandler.java | 2 +- .../membership/gms/messages/HasMemberID.java | 2 +- .../org/apache/geode/i18n/LogWriterI18n.java | 114 +- .../apache/geode/internal/ByteBufferWriter.java | 2 +- .../geode/internal/ConnectionWatcher.java | 4 +- .../java/org/apache/geode/internal/DSCODE.java | 150 +-- .../geode/internal/DataSerializableFixedID.java | 1066 +++++++++--------- .../org/apache/geode/internal/NanoTimer.java | 2 +- .../internal/ObjToByteArraySerializer.java | 2 +- .../geode/internal/OneTaskOnlyExecutor.java | 2 +- .../geode/internal/SerializationVersions.java | 2 +- .../geode/internal/VersionedDataStream.java | 2 +- .../geode/internal/admin/AdminBridgeServer.java | 2 +- .../org/apache/geode/internal/admin/Alert.java | 34 +- .../geode/internal/admin/AlertListener.java | 2 +- .../geode/internal/admin/ApplicationVM.java | 2 +- .../apache/geode/internal/admin/CacheInfo.java | 24 +- .../geode/internal/admin/CacheSnapshot.java | 14 +- .../apache/geode/internal/admin/DLockInfo.java | 14 +- .../geode/internal/admin/EntrySnapshot.java | 2 +- .../geode/internal/admin/EntryValueNode.java | 10 +- .../apache/geode/internal/admin/GemFireVM.java | 93 +- .../geode/internal/admin/GfManagerAgent.java | 24 +- .../apache/geode/internal/admin/GfObject.java | 8 +- .../geode/internal/admin/HealthListener.java | 2 +- .../geode/internal/admin/JoinLeaveListener.java | 6 +- .../geode/internal/admin/RegionSnapshot.java | 2 +- .../geode/internal/admin/SnapshotClient.java | 2 +- .../org/apache/geode/internal/admin/Stat.java | 6 +- .../internal/admin/StatAlertDefinition.java | 30 +- .../geode/internal/admin/StatListener.java | 4 +- .../geode/internal/admin/StatResource.java | 16 +- .../internal/admin/remote/Cancellable.java | 2 +- .../admin/statalerts/StatisticInfo.java | 18 +- .../geode/internal/cache/AbstractRegionMap.java | 18 +- .../cache/CacheDistributionAdvisee.java | 12 +- .../geode/internal/cache/CacheObserver.java | 36 +- .../geode/internal/cache/CacheService.java | 6 +- .../internal/cache/CachedDeserializable.java | 22 +- .../internal/cache/ClientServerObserver.java | 24 +- .../geode/internal/cache/CompactableOplog.java | 9 +- .../geode/internal/cache/Conflatable.java | 12 +- .../apache/geode/internal/cache/DiskEntry.java | 46 +- .../geode/internal/cache/DiskStoreTask.java | 2 +- .../cache/DistTXCoordinatorInterface.java | 23 +- .../apache/geode/internal/cache/EntriesMap.java | 8 +- .../apache/geode/internal/cache/ExpiryTask.java | 10 +- .../geode/internal/cache/ExportDiskRegion.java | 4 +- .../geode/internal/cache/FilterProfile.java | 4 +- .../geode/internal/cache/HasCachePerfStats.java | 2 +- .../apache/geode/internal/cache/ImageState.java | 62 +- .../geode/internal/cache/InterestFilter.java | 10 +- .../internal/cache/InternalCacheEvent.java | 20 +- .../geode/internal/cache/InternalDataView.java | 10 +- .../internal/cache/LoaderHelperFactory.java | 4 +- .../internal/cache/OffHeapRegionEntry.java | 4 +- .../org/apache/geode/internal/cache/Oplog.java | 26 +- .../apache/geode/internal/cache/OplogSet.java | 8 +- .../internal/cache/PRHARedundancyProvider.java | 6 +- .../cache/PartitionedRegionQueryEvaluator.java | 2 +- .../geode/internal/cache/RegionEntry.java | 129 ++- .../internal/cache/RegionEntryContext.java | 7 +- .../internal/cache/RegionEntryFactory.java | 8 +- .../geode/internal/cache/RegionListener.java | 4 +- .../apache/geode/internal/cache/RegionMap.java | 94 +- .../geode/internal/cache/RegionQueue.java | 28 +- .../internal/cache/SerializationHelper.java | 4 +- .../internal/cache/TXEntryStateFactory.java | 4 +- .../geode/internal/cache/TXStateInterface.java | 79 +- .../geode/internal/cache/TXStateProxy.java | 40 +- .../internal/cache/TransactionMessage.java | 14 +- .../geode/internal/cache/TxEntryFactory.java | 4 +- .../cache/control/InternalResourceManager.java | 16 +- .../internal/cache/control/MemoryMonitor.java | 12 +- .../cache/control/OffHeapMemoryMonitor.java | 16 +- .../internal/cache/control/ResourceEvent.java | 6 +- .../cache/control/ResourceListener.java | 2 +- .../internal/cache/control/ResourceMonitor.java | 6 +- .../cache/execute/AbstractExecution.java | 6 +- .../cache/execute/InternalExecution.java | 10 +- .../execute/InternalRegionFunctionContext.java | 6 +- .../cache/execute/InternalResultSender.java | 8 +- .../execute/MultiRegionFunctionContext.java | 4 +- .../internal/cache/extension/Extensible.java | 2 +- .../internal/cache/ha/HAContainerWrapper.java | 18 +- .../geode/internal/cache/locks/TXLockId.java | 8 +- .../cache/locks/TXRegionLockRequest.java | 8 +- .../geode/internal/cache/lru/EnableLRU.java | 36 +- .../geode/internal/cache/lru/LRUClockNode.java | 26 +- .../geode/internal/cache/lru/LRUEntry.java | 4 +- .../internal/cache/lru/LRUMapCallbacks.java | 16 +- .../geode/internal/cache/lru/Sizeable.java | 6 +- .../internal/cache/partitioned/Bucket.java | 18 +- .../cache/partitioned/InternalPRInfo.java | 4 +- .../partitioned/InternalPartitionDetails.java | 4 +- .../cache/partitioned/OfflineMemberDetails.java | 4 +- .../cache/partitioned/PREntriesIterator.java | 4 +- .../partitioned/PartitionedRegionObserver.java | 6 +- .../cache/partitioned/RegionAdvisor.java | 2 +- .../partitioned/rebalance/BucketOperator.java | 8 +- .../rebalance/PartitionedRegionLoadModel.java | 7 +- .../rebalance/RebalanceDirector.java | 8 +- .../persistence/DiskInitFileInterpreter.java | 10 +- .../cache/persistence/DiskRecoveryStore.java | 43 +- .../cache/persistence/DiskRegionView.java | 124 +- .../cache/persistence/PersistenceAdvisor.java | 31 +- .../persistence/PersistenceObserverHolder.java | 14 +- .../persistence/PersistentMemberManager.java | 12 +- .../cache/persistence/PersistentMemberView.java | 40 +- .../persistence/PersistentStateListener.java | 8 +- .../cache/persistence/RestoreScript.java | 2 +- .../UninterruptibleRandomAccessFile.java | 4 +- .../cache/persistence/query/IndexMap.java | 2 +- .../cache/persistence/query/ResultBag.java | 2 +- .../cache/persistence/query/ResultList.java | 2 +- .../cache/persistence/query/ResultMap.java | 2 +- .../cache/persistence/query/ResultSet.java | 2 +- .../internal/cache/tier/ClientHandShake.java | 14 +- .../internal/cache/tier/ConnectionProxy.java | 2 +- .../cache/tier/sockets/CacheClientProxy.java | 2 +- .../cache/tier/sockets/ClientMessage.java | 2 +- .../cache/tier/sockets/ClientUpdateMessage.java | 42 +- .../tier/sockets/ClientUpdateMessageImpl.java | 14 +- .../cache/tier/sockets/MessageStats.java | 8 +- .../tier/sockets/OldClientSupportService.java | 8 +- .../internal/cache/versions/VersionHolder.java | 4 +- .../internal/cache/versions/VersionSource.java | 2 +- .../internal/cache/versions/VersionStamp.java | 6 +- .../internal/cache/vmotion/VMotionObserver.java | 6 +- .../cache/wan/DistributedSystemListener.java | 4 +- .../cache/wan/GatewaySenderEventDispatcher.java | 8 +- .../cache/wan/InternalGatewaySenderFactory.java | 13 +- .../internal/cache/xmlcache/Declarable2.java | 2 +- .../cache/xmlcache/PropertyResolver.java | 15 +- .../apache/geode/internal/concurrent/AL.java | 24 +- .../geode/internal/concurrent/MapCallback.java | 31 +- .../geode/internal/concurrent/MapResult.java | 4 +- .../datasource/ConnectionPoolCache.java | 8 +- .../internal/datasource/ConnectionProvider.java | 8 +- .../datasource/DataSourceResources.java | 14 +- .../apache/geode/internal/i18n/StringId.java | 10 +- .../org/apache/geode/internal/lang/Filter.java | 2 +- .../apache/geode/internal/lang/Initable.java | 2 +- .../internal/lang/MutableIdentifiable.java | 2 +- .../apache/geode/internal/lang/Orderable.java | 2 +- .../org/apache/geode/internal/lang/Ordered.java | 4 +- .../internal/logging/InternalLogWriter.java | 40 +- .../geode/internal/logging/MergeLogFiles.java | 12 +- .../internal/logging/log4j/GemFireLogger.java | 168 +-- .../geode/internal/logging/log4j/LogMarker.java | 123 +- .../internal/memcached/CommandProcessor.java | 2 +- .../geode/internal/offheap/FreeListManager.java | 2 +- .../internal/offheap/LifecycleListener.java | 13 +- .../geode/internal/offheap/MemoryAllocator.java | 23 +- .../geode/internal/offheap/MemoryBlock.java | 24 +- .../geode/internal/offheap/MemoryInspector.java | 14 +- .../internal/offheap/MemoryUsageListener.java | 2 +- .../internal/offheap/OffHeapMemoryStats.java | 48 +- .../offheap/OutOfOffHeapMemoryListener.java | 4 +- .../geode/internal/offheap/Releasable.java | 2 +- .../org/apache/geode/internal/offheap/Slab.java | 6 +- .../geode/internal/offheap/SlabFactory.java | 2 +- .../geode/internal/offheap/StoredObject.java | 46 +- .../internal/process/ControlFileWatchdog.java | 2 +- .../process/ControlNotificationHandler.java | 4 +- .../process/FileControllerParameters.java | 4 +- .../process/MBeanControllerParameters.java | 12 +- .../internal/process/ProcessController.java | 16 +- .../internal/process/ProcessStreamReader.java | 4 +- .../geode/internal/process/ProcessUtils.java | 8 +- .../internal/process/StartupStatusListener.java | 2 +- .../internal/process/signal/SignalListener.java | 2 +- .../internal/sequencelog/SequenceLogger.java | 8 +- .../geode/internal/sequencelog/io/Filter.java | 5 +- .../sequencelog/model/GraphReaderCallback.java | 6 +- .../geode/internal/shared/NativeCalls.java | 4 +- .../internal/shared/NativeCallsJNAImpl.java | 2 +- .../geode/internal/size/ObjectGraphSizer.java | 2 +- .../internal/statistics/LocalStatListener.java | 2 +- .../internal/statistics/SampleHandler.java | 8 +- .../internal/statistics/StatArchiveFormat.java | 74 +- .../statistics/StatArchiveHandlerConfig.java | 14 +- .../internal/statistics/StatArchiveReader.java | 64 +- .../geode/internal/statistics/StatisticId.java | 4 +- .../internal/statistics/StatisticsListener.java | 2 +- .../internal/statistics/StatisticsManager.java | 20 +- .../statistics/StatisticsNotification.java | 16 +- .../internal/statistics/StatisticsSampler.java | 8 +- .../internal/statistics/VMStatsContract.java | 4 +- .../platform/OsStatisticsFactory.java | 2 +- .../geode/internal/tcp/BaseMsgStreamer.java | 10 +- .../internal/tcp/ByteBufferInputStream.java | 2 +- .../geode/internal/tcp/ServerDelegate.java | 6 +- .../geode/internal/util/ObjectIntProcedure.java | 2 +- .../apache/geode/internal/util/Transformer.java | 2 +- .../apache/geode/internal/util/Versionable.java | 8 +- .../CustomEntryConcurrentHashMap.java | 16 +- .../org/apache/geode/lang/Identifiable.java | 2 +- .../geode/management/AsyncEventQueueMXBean.java | 28 +- .../geode/management/CacheServerMXBean.java | 104 +- .../geode/management/DiskStoreMXBean.java | 52 +- .../DistributedLockServiceMXBean.java | 12 +- .../management/DistributedRegionMXBean.java | 98 +- .../management/DistributedSystemMXBean.java | 157 ++- .../geode/management/GatewayReceiverMXBean.java | 68 +- .../geode/management/GatewaySenderMXBean.java | 72 +- .../geode/management/JMXNotificationType.java | 55 +- .../management/JMXNotificationUserData.java | 6 +- .../apache/geode/management/LocatorMXBean.java | 16 +- .../geode/management/LockServiceMXBean.java | 18 +- .../apache/geode/management/ManagerMXBean.java | 14 +- .../apache/geode/management/MemberMXBean.java | 242 ++-- .../apache/geode/management/RegionMXBean.java | 104 +- .../geode/management/cli/CliMetaData.java | 6 +- .../geode/management/cli/CommandStatement.java | 8 +- .../geode/management/cli/ConverterHint.java | 33 +- .../org/apache/geode/management/cli/Result.java | 18 +- .../internal/ManagementConstants.java | 132 ++- .../internal/NotificationBroadCasterProxy.java | 2 +- .../management/internal/ProxyInterface.java | 4 +- .../management/internal/ProxyListener.java | 6 +- .../internal/beans/AggregateHandler.java | 10 +- .../internal/beans/CacheServiceMBeanBase.java | 4 +- .../internal/cli/multistep/CLIStep.java | 4 +- .../internal/cli/result/ResultData.java | 4 +- .../internal/cli/shell/OperationInvoker.java | 21 +- .../internal/security/AccessControlMXBean.java | 2 +- .../membership/ClientMembershipEvent.java | 6 +- .../membership/ClientMembershipListener.java | 6 +- .../management/membership/MembershipEvent.java | 4 +- .../membership/MembershipListener.java | 6 +- .../java/org/apache/geode/pdx/PdxInstance.java | 22 +- .../apache/geode/pdx/PdxInstanceFactory.java | 57 +- .../java/org/apache/geode/pdx/PdxReader.java | 52 +- .../org/apache/geode/pdx/PdxSerializable.java | 4 +- .../org/apache/geode/pdx/PdxSerializer.java | 4 +- .../java/org/apache/geode/pdx/PdxWriter.java | 59 +- .../apache/geode/pdx/WritablePdxInstance.java | 2 +- .../geode/pdx/internal/ComparableEnum.java | 6 +- .../geode/pdx/internal/ConvertableToBytes.java | 2 +- .../geode/pdx/internal/InternalPdxReader.java | 94 +- .../geode/pdx/internal/TypeRegistration.java | 36 +- .../java/org/apache/geode/ra/GFConnection.java | 2 +- .../apache/geode/ra/GFConnectionFactory.java | 2 +- .../apache/geode/redis/internal/Executor.java | 2 +- .../apache/geode/redis/internal/Extendable.java | 2 +- .../apache/geode/security/AuthInitialize.java | 9 +- .../management/ResourceManagerDUnitTest.java | 4 +- .../query/functional/GroupByTestInterface.java | 38 +- .../ClassNotFoundExceptionDUnitTest.java | 4 +- .../internal/cache/DeltaSizingDUnitTest.java | 2 +- .../geode/internal/cache/MockCacheService.java | 2 +- .../control/RebalanceOperationDUnitTest.java | 2 +- .../SimpleExtensionPointJUnitTest.java | 2 +- .../internal/cache/lru/LRUClockJUnitTest.java | 2 +- .../logging/LoggingPerformanceTestCase.java | 6 +- .../internal/process/mbean/ProcessMBean.java | 6 +- .../apache/geode/internal/util/Valuable.java | 4 +- .../geode/management/CompositeTestMXBean.java | 10 +- .../apache/geode/management/CustomMXBean.java | 12 +- .../security/ClientAuthorizationTestCase.java | 6 +- .../org/apache/geode/sequence/LineMapper.java | 2 +- .../geode/sequence/SelectGraphDialog.java | 2 +- .../geode/test/dunit/RepeatableRunnable.java | 2 +- .../test/dunit/SerializableRunnableIF.java | 2 +- .../test/dunit/StoppableWaitCriterion.java | 2 +- .../apache/geode/test/dunit/WaitCriterion.java | 4 +- .../dunit/cache/internal/CacheTestFixture.java | 4 +- .../dunit/internal/DistributedTestFixture.java | 16 +- .../test/dunit/standalone/DUnitLauncher.java | 10 +- .../geode/test/golden/ExecutableProcess.java | 2 +- .../src/main/java/org/json/JSONString.java | 2 +- .../org/apache/geode/test/junit/Repeat.java | 2 +- .../java/org/apache/geode/test/junit/Retry.java | 2 +- .../serializable/FieldsOfTemporaryFolder.java | 6 +- .../rules/serializable/FieldsOfTestName.java | 2 +- .../rules/serializable/FieldsOfTimeout.java | 6 +- .../apache/geode/cache/lucene/LuceneIndex.java | 8 +- .../apache/geode/cache/lucene/LuceneQuery.java | 12 +- .../geode/cache/lucene/LuceneQueryFactory.java | 8 +- .../geode/cache/lucene/LuceneQueryProvider.java | 2 +- .../geode/cache/lucene/LuceneResultStruct.java | 6 +- .../geode/cache/lucene/LuceneService.java | 18 +- .../lucene/PageableLuceneQueryResults.java | 8 +- .../cache/lucene/internal/IndexListener.java | 8 +- .../lucene/internal/InternalLuceneIndex.java | 6 +- .../internal/repository/IndexRepository.java | 4 +- .../repository/IndexResultCollector.java | 4 +- .../lucene/management/LuceneServiceMXBean.java | 6 +- .../IndexRepositoryImplPerformanceTest.java | 12 +- ...stomMappingJackson2HttpMessageConverter.java | 4 +- .../web/http/ClientHttpRequestJUnitTest.java | 14 +- 508 files changed, 5504 insertions(+), 5590 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/common/SessionCache.java ---------------------------------------------------------------------- diff --git a/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/common/SessionCache.java b/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/common/SessionCache.java index 9b03bc0..ff2151d 100644 --- a/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/common/SessionCache.java +++ b/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/common/SessionCache.java @@ -28,26 +28,26 @@ public interface SessionCache { /** * Initialize the cache and create the appropriate region. */ - public void initialize(); + void initialize(); /** * Stop the cache. */ - public void stop(); + void stop(); /** * Retrieve the cache reference. * * @return a {@code GemFireCache} reference */ - public GemFireCache getCache(); + GemFireCache getCache(); /** * Get the {@code Region} being used by client code to put attributes. * * @return a {@code Region<String, HttpSession>} reference */ - public Region<String, HttpSession> getOperatingRegion(); + Region<String, HttpSession> getOperatingRegion(); /** * Get the backing {@code Region} being used. This may not be the same as the region being used by @@ -55,12 +55,12 @@ public interface SessionCache { * * @return a {@code Region<String, HttpSession>} reference */ - public Region<String, HttpSession> getSessionRegion(); + Region<String, HttpSession> getSessionRegion(); /** * Is this cache client-server? The only other alternative is peer-to-peer. * * @return true if this cache is client-server. */ - public boolean isClientServer(); + boolean isClientServer(); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/SessionManager.java ---------------------------------------------------------------------- diff --git a/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/SessionManager.java b/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/SessionManager.java index 642c287..f6e9a52 100644 --- a/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/SessionManager.java +++ b/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/SessionManager.java @@ -31,19 +31,19 @@ public interface SessionManager { * the same classloader. This is so that during shutdown, the manager can decide whether or * not to also stop the cache. This option allows the filter's classloader to be passed in. */ - public void start(Object config, ClassLoader loader); + void start(Object config, ClassLoader loader); /** * Stop the session manager and free up any resources. */ - public void stop(); + void stop(); /** * Write the session to the region * * @param session the session to write */ - public void putSession(HttpSession session); + void putSession(HttpSession session); /** * Return a session if it exists or null otherwise @@ -51,7 +51,7 @@ public interface SessionManager { * @param id The session id to attempt to retrieve * @return a HttpSession object if a session was found otherwise null. */ - public HttpSession getSession(String id); + HttpSession getSession(String id); /** * Create a new session, wrapping a container session. @@ -59,7 +59,7 @@ public interface SessionManager { * @param nativeSession * @return the HttpSession object */ - public HttpSession wrapSession(HttpSession nativeSession); + HttpSession wrapSession(HttpSession nativeSession); /** * Get the wrapped (GemFire) session from a native session id. This method would typically be used @@ -68,14 +68,14 @@ public interface SessionManager { * @param nativeId * @return the wrapped GemFire session which maps the native session */ - public HttpSession getWrappingSession(String nativeId); + HttpSession getWrappingSession(String nativeId); /** * Destroy the session associated with the given id. * * @param id The id of the session to destroy. */ - public void destroySession(String id); + void destroySession(String id); /** * Destroy the session associated with a given native session @@ -83,14 +83,14 @@ public interface SessionManager { * @param id the id of the native session * @return the corresponding Gemfire session which wrapped the native session and was destroyed. */ - public String destroyNativeSession(String id); + String destroyNativeSession(String id); /** * Returns the cookie name used to hold the session id. By default this is JSESSIONID. * * @return the name of the cookie which contains the session id */ - public String getSessionCookieName(); + String getSessionCookieName(); /** * Get the JVM Id - this is a unique string used internally to identify who last touched a @@ -98,5 +98,5 @@ public interface SessionManager { * * @return the jvm id */ - public String getJvmId(); + String getJvmId(); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/attributes/SessionAttributes.java ---------------------------------------------------------------------- diff --git a/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/attributes/SessionAttributes.java b/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/attributes/SessionAttributes.java index 4f4a2f8..87160d4 100644 --- a/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/attributes/SessionAttributes.java +++ b/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/attributes/SessionAttributes.java @@ -32,7 +32,7 @@ public interface SessionAttributes extends DataSerializable { * * @param session the session to set */ - public void setSession(GemfireHttpSession session); + void setSession(GemfireHttpSession session); /** * Set an attribute value. @@ -41,7 +41,7 @@ public interface SessionAttributes extends DataSerializable { * @param value the value for the attribute * @return the value object */ - public Object putAttribute(String attr, Object value); + Object putAttribute(String attr, Object value); /** * Retrieve an attribute's value. @@ -49,7 +49,7 @@ public interface SessionAttributes extends DataSerializable { * @param attr the name of the attribute * @return the object associated with the attribute or null if none exists. */ - public Object getAttribute(String attr); + Object getAttribute(String attr); /** * Remove the named attribute. @@ -57,59 +57,59 @@ public interface SessionAttributes extends DataSerializable { * @param attr the name of the attribute to remove * @return the value of the attribute removed or null if the named attribute did not exist. */ - public Object removeAttribute(String attr); + Object removeAttribute(String attr); /** * Return a set of all attribute names. * * @return a set of all attribute names */ - public Set<String> getAttributeNames(); + Set<String> getAttributeNames(); /** * Set the max inactive interval for replication to other systems * * @param interval the time interval in seconds */ - public void setMaxInactiveInterval(int interval); + void setMaxInactiveInterval(int interval); /** * Retrieve the max inactive interval * * @return the max inactive interval in seconds */ - public int getMaxIntactiveInterval(); + int getMaxIntactiveInterval(); /** * Set the last accessed time for replication to other systems * * @param time the last accessed time in milliseconds */ - public void setLastAccessedTime(long time); + void setLastAccessedTime(long time); /** * Return the last accessed time in milliseconds * * @return the last accessed time */ - public long getLastAccessedTime(); + long getLastAccessedTime(); /** * Explicitly flush the attributes to backing store. */ - public void flush(); + void flush(); /** * Return the last jvm which 'owned' these attributes * * @return the jvmId */ - public String getJvmOwnerId(); + String getJvmOwnerId(); /** * Set the jvmId. This is set every time the attributes are flushed to the cache. * * @param jvmId */ - public void setJvmOwnerId(String jvmId); + void setJvmOwnerId(String jvmId); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/jmx/SessionStatisticsMXBean.java ---------------------------------------------------------------------- diff --git a/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/jmx/SessionStatisticsMXBean.java b/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/jmx/SessionStatisticsMXBean.java index 1821f62..6676f09 100644 --- a/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/jmx/SessionStatisticsMXBean.java +++ b/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/jmx/SessionStatisticsMXBean.java @@ -20,9 +20,9 @@ package org.apache.geode.modules.session.internal.jmx; */ public interface SessionStatisticsMXBean { - public int getActiveSessions(); + int getActiveSessions(); - public int getTotalSessions(); + int getTotalSessions(); - public long getRegionUpdates(); + long getRegionUpdates(); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/extensions/geode-modules/src/main/java/org/apache/geode/modules/gatewaydelta/GatewayDelta.java ---------------------------------------------------------------------- diff --git a/extensions/geode-modules/src/main/java/org/apache/geode/modules/gatewaydelta/GatewayDelta.java b/extensions/geode-modules/src/main/java/org/apache/geode/modules/gatewaydelta/GatewayDelta.java index 92cde0a..88c3fd9 100644 --- a/extensions/geode-modules/src/main/java/org/apache/geode/modules/gatewaydelta/GatewayDelta.java +++ b/extensions/geode-modules/src/main/java/org/apache/geode/modules/gatewaydelta/GatewayDelta.java @@ -16,9 +16,9 @@ package org.apache.geode.modules.gatewaydelta; public interface GatewayDelta { - public static final String GATEWAY_DELTA_REGION_NAME = "__gatewayDelta"; + String GATEWAY_DELTA_REGION_NAME = "__gatewayDelta"; - public GatewayDeltaEvent getCurrentGatewayDeltaEvent(); + GatewayDeltaEvent getCurrentGatewayDeltaEvent(); - public void setCurrentGatewayDeltaEvent(GatewayDeltaEvent currentGatewayDeltaEvent); + void setCurrentGatewayDeltaEvent(GatewayDeltaEvent currentGatewayDeltaEvent); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/extensions/geode-modules/src/main/java/org/apache/geode/modules/gatewaydelta/GatewayDeltaEvent.java ---------------------------------------------------------------------- diff --git a/extensions/geode-modules/src/main/java/org/apache/geode/modules/gatewaydelta/GatewayDeltaEvent.java b/extensions/geode-modules/src/main/java/org/apache/geode/modules/gatewaydelta/GatewayDeltaEvent.java index d54e90b..134e4f1 100644 --- a/extensions/geode-modules/src/main/java/org/apache/geode/modules/gatewaydelta/GatewayDeltaEvent.java +++ b/extensions/geode-modules/src/main/java/org/apache/geode/modules/gatewaydelta/GatewayDeltaEvent.java @@ -18,5 +18,5 @@ import org.apache.geode.cache.Cache; public interface GatewayDeltaEvent { - public void apply(Cache cache); + void apply(Cache cache); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/SessionCache.java ---------------------------------------------------------------------- diff --git a/extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/SessionCache.java b/extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/SessionCache.java index 5c0fecd..6cf1782 100644 --- a/extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/SessionCache.java +++ b/extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/SessionCache.java @@ -24,39 +24,39 @@ import java.util.Set; public interface SessionCache { - public void initialize(); + void initialize(); - public String getDefaultRegionAttributesId(); + String getDefaultRegionAttributesId(); - public boolean getDefaultEnableLocalCache(); + boolean getDefaultEnableLocalCache(); - public String getSessionRegionName(); + String getSessionRegionName(); - public String getOperatingRegionName(); + String getOperatingRegionName(); - public void putSession(Session session); + void putSession(Session session); - public HttpSession getSession(String sessionId); + HttpSession getSession(String sessionId); - public void destroySession(String sessionId); + void destroySession(String sessionId); - public void touchSessions(Set<String> sessionIds); + void touchSessions(Set<String> sessionIds); - public DeltaSessionStatistics getStatistics(); + DeltaSessionStatistics getStatistics(); - public GemFireCache getCache(); + GemFireCache getCache(); - public Region<String, HttpSession> getSessionRegion(); + Region<String, HttpSession> getSessionRegion(); - public Region<String, HttpSession> getOperatingRegion(); + Region<String, HttpSession> getOperatingRegion(); - public boolean isPeerToPeer(); + boolean isPeerToPeer(); - public boolean isClientServer(); + boolean isClientServer(); - public Set<String> keySet(); + Set<String> keySet(); - public int size(); + int size(); - public boolean isBackingCacheAvailable(); + boolean isBackingCacheAvailable(); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/SessionManager.java ---------------------------------------------------------------------- diff --git a/extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/SessionManager.java b/extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/SessionManager.java index e739fa4..52337c1 100644 --- a/extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/SessionManager.java +++ b/extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/SessionManager.java @@ -18,29 +18,29 @@ import org.apache.juli.logging.Log; public interface SessionManager { - public String getRegionName(); + String getRegionName(); - public String getRegionAttributesId(); + String getRegionAttributesId(); - public int getMaxInactiveInterval(); + int getMaxInactiveInterval(); - public boolean getEnableGatewayReplication(); + boolean getEnableGatewayReplication(); - public boolean getEnableGatewayDeltaReplication(); + boolean getEnableGatewayDeltaReplication(); - public boolean getEnableDebugListener(); + boolean getEnableDebugListener(); - public boolean getEnableLocalCache(); + boolean getEnableLocalCache(); - public boolean isCommitValveEnabled(); + boolean isCommitValveEnabled(); - public boolean isCommitValveFailfastEnabled(); + boolean isCommitValveFailfastEnabled(); - public boolean isBackingCacheAvailable(); + boolean isBackingCacheAvailable(); - public boolean getPreferDeserializedForm(); + boolean getPreferDeserializedForm(); - public String getStatisticsName(); + String getStatisticsName(); - public Log getLogger(); + Log getLogger(); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/internal/DeltaSessionAttributeEvent.java ---------------------------------------------------------------------- diff --git a/extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/internal/DeltaSessionAttributeEvent.java b/extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/internal/DeltaSessionAttributeEvent.java index 896eb86..5f75594 100644 --- a/extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/internal/DeltaSessionAttributeEvent.java +++ b/extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/internal/DeltaSessionAttributeEvent.java @@ -20,5 +20,5 @@ import org.apache.geode.modules.session.catalina.DeltaSessionInterface; public interface DeltaSessionAttributeEvent extends DataSerializable { - public void apply(DeltaSessionInterface session); + void apply(DeltaSessionInterface session); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/extensions/geode-modules/src/test/java/org/apache/geode/modules/session/Callback.java ---------------------------------------------------------------------- diff --git a/extensions/geode-modules/src/test/java/org/apache/geode/modules/session/Callback.java b/extensions/geode-modules/src/test/java/org/apache/geode/modules/session/Callback.java index 46b4a25..690355d 100644 --- a/extensions/geode-modules/src/test/java/org/apache/geode/modules/session/Callback.java +++ b/extensions/geode-modules/src/test/java/org/apache/geode/modules/session/Callback.java @@ -24,6 +24,6 @@ import java.io.IOException; */ public interface Callback { - public void call(HttpServletRequest request, HttpServletResponse response) + void call(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException; } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-common/src/test/java/org/apache/geode/annotations/ExperimentalJUnitTest.java ---------------------------------------------------------------------- diff --git a/geode-common/src/test/java/org/apache/geode/annotations/ExperimentalJUnitTest.java b/geode-common/src/test/java/org/apache/geode/annotations/ExperimentalJUnitTest.java index ea6008e..01b5844 100755 --- a/geode-common/src/test/java/org/apache/geode/annotations/ExperimentalJUnitTest.java +++ b/geode-common/src/test/java/org/apache/geode/annotations/ExperimentalJUnitTest.java @@ -111,10 +111,10 @@ public class ExperimentalJUnitTest { return element.getAnnotation(Experimental.class) != null; } - public static interface RegularInterface { + public interface RegularInterface { } @Experimental("This is an experimental interface") - public static interface ExperimentalInterface { + public interface ExperimentalInterface { } public static class RegularClass { http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/DataSerializable.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/DataSerializable.java b/geode-core/src/main/java/org/apache/geode/DataSerializable.java index 4c35c31..749746c 100644 --- a/geode-core/src/main/java/org/apache/geode/DataSerializable.java +++ b/geode-core/src/main/java/org/apache/geode/DataSerializable.java @@ -79,7 +79,7 @@ public interface DataSerializable extends Serializable { * * @throws IOException A problem occurs while writing to <code>out</code> */ - public void toData(DataOutput out) throws IOException; + void toData(DataOutput out) throws IOException; /** * Reads the state of this object as primitive data from the given <code>DataInput</code>. @@ -87,7 +87,7 @@ public interface DataSerializable extends Serializable { * @throws IOException A problem occurs while reading from <code>in</code> * @throws ClassNotFoundException A class could not be loaded while reading from <code>in</code> */ - public void fromData(DataInput in) throws IOException, ClassNotFoundException; + void fromData(DataInput in) throws IOException, ClassNotFoundException; //////////////////////// Inner Classes //////////////////////// @@ -104,13 +104,13 @@ public interface DataSerializable extends Serializable { * * @see DataSerializer#writeObject(Object, DataOutput) */ - public interface Replaceable { + interface Replaceable { /** * Replaces this object with another in the "output stream" written by * {@link DataSerializer#writeObject(Object, DataOutput)}. */ - public Object replace() throws IOException; + Object replace() throws IOException; } } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/LogWriter.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/LogWriter.java b/geode-core/src/main/java/org/apache/geode/LogWriter.java index 4a2e473..cb309d4 100644 --- a/geode-core/src/main/java/org/apache/geode/LogWriter.java +++ b/geode-core/src/main/java/org/apache/geode/LogWriter.java @@ -81,148 +81,148 @@ public interface LogWriter { * Returns true if "severe" log messages are enabled. Returns false if "severe" log messages are * disabled. */ - public boolean severeEnabled(); + boolean severeEnabled(); /** * Writes both a message and exception to this writer. The message level is "severe". */ - public void severe(String msg, Throwable ex); + void severe(String msg, Throwable ex); /** * Writes a message to this writer. The message level is "severe". */ - public void severe(String msg); + void severe(String msg); /** * Writes an exception to this writer. The exception level is "severe". */ - public void severe(Throwable ex); + void severe(Throwable ex); /** * Returns true if "error" log messages are enabled. Returns false if "error" log messages are * disabled. */ - public boolean errorEnabled(); + boolean errorEnabled(); /** * Writes both a message and exception to this writer. The message level is "error". */ - public void error(String msg, Throwable ex); + void error(String msg, Throwable ex); /** * Writes a message to this writer. The message level is "error". */ - public void error(String msg); + void error(String msg); /** * Writes an exception to this writer. The exception level is "error". */ - public void error(Throwable ex); + void error(Throwable ex); /** * Returns true if "warning" log messages are enabled. Returns false if "warning" log messages are * disabled. */ - public boolean warningEnabled(); + boolean warningEnabled(); /** * Writes both a message and exception to this writer. The message level is "warning". */ - public void warning(String msg, Throwable ex); + void warning(String msg, Throwable ex); /** * Writes a message to this writer. The message level is "warning". */ - public void warning(String msg); + void warning(String msg); /** * Writes an exception to this writer. The exception level is "warning". */ - public void warning(Throwable ex); + void warning(Throwable ex); /** * Returns true if "info" log messages are enabled. Returns false if "info" log messages are * disabled. */ - public boolean infoEnabled(); + boolean infoEnabled(); /** * Writes both a message and exception to this writer. The message level is "information". */ - public void info(String msg, Throwable ex); + void info(String msg, Throwable ex); /** * Writes a message to this writer. The message level is "information". */ - public void info(String msg); + void info(String msg); /** * Writes an exception to this writer. The exception level is "information". */ - public void info(Throwable ex); + void info(Throwable ex); /** * Returns true if "config" log messages are enabled. Returns false if "config" log messages are * disabled. */ - public boolean configEnabled(); + boolean configEnabled(); /** * Writes both a message and exception to this writer. The message level is "config". */ - public void config(String msg, Throwable ex); + void config(String msg, Throwable ex); /** * Writes a message to this writer. The message level is "config". */ - public void config(String msg); + void config(String msg); /** * Writes an exception to this writer. The exception level is "config". */ - public void config(Throwable ex); + void config(Throwable ex); /** * Returns true if "fine" log messages are enabled. Returns false if "fine" log messages are * disabled. */ - public boolean fineEnabled(); + boolean fineEnabled(); /** * Writes both a message and exception to this writer. The message level is "fine". */ - public void fine(String msg, Throwable ex); + void fine(String msg, Throwable ex); /** * Writes a message to this writer. The message level is "fine". */ - public void fine(String msg); + void fine(String msg); /** * Writes an exception to this writer. The exception level is "fine". */ - public void fine(Throwable ex); + void fine(Throwable ex); /** * Returns true if "finer" log messages are enabled. Returns false if "finer" log messages are * disabled. */ - public boolean finerEnabled(); + boolean finerEnabled(); /** * Writes both a message and exception to this writer. The message level is "finer". */ - public void finer(String msg, Throwable ex); + void finer(String msg, Throwable ex); /** * Writes a message to this writer. The message level is "finer". */ - public void finer(String msg); + void finer(String msg); /** * Writes an exception to this writer. The exception level is "finer". */ - public void finer(Throwable ex); + void finer(Throwable ex); /** * Log a method entry. @@ -233,7 +233,7 @@ public interface LogWriter { * @param sourceClass Name of class that issued the logging request. * @param sourceMethod Name of the method that issued the logging request. */ - public void entering(String sourceClass, String sourceMethod); + void entering(String sourceClass, String sourceMethod); /** * Log a method return. @@ -244,7 +244,7 @@ public interface LogWriter { * @param sourceClass Name of class that issued the logging request. * @param sourceMethod Name of the method that issued the logging request. */ - public void exiting(String sourceClass, String sourceMethod); + void exiting(String sourceClass, String sourceMethod); /** * Log throwing an exception. @@ -260,40 +260,40 @@ public interface LogWriter { * @param sourceMethod Name of the method that issued the logging request. * @param thrown The Throwable that is being thrown. */ - public void throwing(String sourceClass, String sourceMethod, Throwable thrown); + void throwing(String sourceClass, String sourceMethod, Throwable thrown); /** * Returns true if "finest" log messages are enabled. Returns false if "finest" log messages are * disabled. */ - public boolean finestEnabled(); + boolean finestEnabled(); /** * Writes both a message and exception to this writer. The message level is "finest". */ - public void finest(String msg, Throwable ex); + void finest(String msg, Throwable ex); /** * Writes a message to this writer. The message level is "finest". */ - public void finest(String msg); + void finest(String msg); /** * Writes an exception to this writer. The exception level is "finest". */ - public void finest(Throwable ex); + void finest(Throwable ex); /** * Returns a 1.4 logging handler that can be used to direct application output to this GemFire * logger using the standard JDK logger APIs. Each time this method is called it creates a new * instance of a Handler so care should be taken to not call this method too often. */ - public Handler getHandler(); + Handler getHandler(); /** * A mechanism for accessing the abstraction layer used for internationalization. * * @return LogWriterI18n */ - public LogWriterI18n convertToLogWriterI18n(); + LogWriterI18n convertToLogWriterI18n(); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/StatisticDescriptor.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/StatisticDescriptor.java b/geode-core/src/main/java/org/apache/geode/StatisticDescriptor.java index fba2878..f2c3a25 100644 --- a/geode-core/src/main/java/org/apache/geode/StatisticDescriptor.java +++ b/geode-core/src/main/java/org/apache/geode/StatisticDescriptor.java @@ -39,36 +39,36 @@ public interface StatisticDescriptor extends Comparable<StatisticDescriptor> { * * @throws IllegalStateException The id has not been initialized yet */ - public int getId(); + int getId(); /** * Returns the name of this statistic */ - public String getName(); + String getName(); /** * Returns a description of this statistic */ - public String getDescription(); + String getDescription(); /** * Returns the type of this statistic */ - public Class<?> getType(); + Class<?> getType(); /** * Returns true if this statistic is a counter; false if its a gauge. Counter statistics have * values that always increase. Gauge statistics have unconstrained values. */ - public boolean isCounter(); + boolean isCounter(); /** * Returns true if a larger statistic value indicates better performance. */ - public boolean isLargerBetter(); + boolean isLargerBetter(); /** * Returns the unit in which this statistic is measured */ - public String getUnit(); + String getUnit(); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/Statistics.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/Statistics.java b/geode-core/src/main/java/org/apache/geode/Statistics.java index cd37648..f573a91 100644 --- a/geode-core/src/main/java/org/apache/geode/Statistics.java +++ b/geode-core/src/main/java/org/apache/geode/Statistics.java @@ -55,7 +55,7 @@ public interface Statistics { * value access on a closed statistics always results in zero. A value modification on a closed * statistics is ignored. */ - public void close(); + void close(); //////////////////////// accessor Methods /////////////////////// @@ -67,7 +67,7 @@ public interface Statistics { * * @see StatisticsType#nameToId */ - public int nameToId(String name); + int nameToId(String name); /** @@ -78,27 +78,27 @@ public interface Statistics { * * @see StatisticsType#nameToDescriptor */ - public StatisticDescriptor nameToDescriptor(String name); + StatisticDescriptor nameToDescriptor(String name); /** * Gets a value that uniquely identifies this statistics. */ - public long getUniqueId(); + long getUniqueId(); /** * Gets the {@link StatisticsType} of this instance. */ - public StatisticsType getType(); + StatisticsType getType(); /** * Gets the text associated with this instance that helps identify it. */ - public String getTextId(); + String getTextId(); /** * Gets the number associated with this instance that helps identify it. */ - public long getNumericId(); + long getNumericId(); /** * Returns true if modifications are atomic. This means that multiple threads, can safely modify @@ -107,12 +107,12 @@ public interface Statistics { * Returns false if modifications are not atomic. This means that modifications to this instance * are cheaper but not thread safe. */ - public boolean isAtomic(); + boolean isAtomic(); /** * Returns true if the instance has been {@link #close closed}. */ - public boolean isClosed(); + boolean isClosed(); //////////////////////// set() Methods /////////////////////// @@ -123,7 +123,7 @@ public interface Statistics { * * @throws ArrayIndexOutOfBoundsException If the id is invalid. */ - public void setInt(int id, int value); + void setInt(int id, int value); /** * Sets the value of a named statistic of type <code>int</code> @@ -131,7 +131,7 @@ public interface Statistics { * @throws IllegalArgumentException If no statistic exists named <code>name</code> or if the * statistic with name <code>name</code> is not of type <code>int</code>. */ - public void setInt(String name, int value); + void setInt(String name, int value); /** * Sets the value of a described statistic of type <code>int</code> @@ -139,7 +139,7 @@ public interface Statistics { * @throws IllegalArgumentException If no statistic exists for the given <code>descriptor</code> * or if the described statistic is not of type <code>int</code>. */ - public void setInt(StatisticDescriptor descriptor, int value); + void setInt(StatisticDescriptor descriptor, int value); /** * Sets the value of a statistic with the given <code>id</code> whose type is <code>long</code>. @@ -148,7 +148,7 @@ public interface Statistics { * * @throws ArrayIndexOutOfBoundsException If the id is invalid. */ - public void setLong(int id, long value); + void setLong(int id, long value); /** * Sets the value of a described statistic of type <code>long</code> @@ -156,7 +156,7 @@ public interface Statistics { * @throws IllegalArgumentException If no statistic exists for the given <code>descriptor</code> * or if the described statistic is not of type <code>long</code>. */ - public void setLong(StatisticDescriptor descriptor, long value); + void setLong(StatisticDescriptor descriptor, long value); /** * Sets the value of a named statistic of type <code>long</code>. @@ -164,7 +164,7 @@ public interface Statistics { * @throws IllegalArgumentException If no statistic exists named <code>name</code> or if the * statistic with name <code>name</code> is not of type <code>long</code>. */ - public void setLong(String name, long value); + void setLong(String name, long value); /** * Sets the value of a statistic with the given <code>id</code> whose type is <code>double</code>. @@ -173,7 +173,7 @@ public interface Statistics { * * @throws ArrayIndexOutOfBoundsException If the id is invalid. */ - public void setDouble(int id, double value); + void setDouble(int id, double value); /** * Sets the value of a described statistic of type <code>double</code> @@ -181,7 +181,7 @@ public interface Statistics { * @throws IllegalArgumentException If no statistic exists for the given <code>descriptor</code> * or if the described statistic is not of type <code>double</code>. */ - public void setDouble(StatisticDescriptor descriptor, double value); + void setDouble(StatisticDescriptor descriptor, double value); /** * Sets the value of a named statistic of type <code>double</code>. @@ -189,7 +189,7 @@ public interface Statistics { * @throws IllegalArgumentException If no statistic exists named <code>name</code> or if the * statistic with name <code>name</code> is not of type <code>double</code>. */ - public void setDouble(String name, double value); + void setDouble(String name, double value); /////////////////////// get() Methods /////////////////////// @@ -199,7 +199,7 @@ public interface Statistics { * @param id a statistic id obtained with {@link #nameToId} or {@link StatisticsType#nameToId}. * @throws ArrayIndexOutOfBoundsException If the id is invalid. */ - public int getInt(int id); + int getInt(int id); /** * Returns the value of the described statistic of type <code>int</code>. @@ -207,7 +207,7 @@ public interface Statistics { * @throws IllegalArgumentException If no statistic exists with the specified * <code>descriptor</code> or if the described statistic is not of type <code>int</code>. */ - public int getInt(StatisticDescriptor descriptor); + int getInt(StatisticDescriptor descriptor); /** * Returns the value of the statistic of type <code>int</code> at the given name. @@ -215,7 +215,7 @@ public interface Statistics { * @throws IllegalArgumentException If no statistic exists with name <code>name</code> or if the * statistic named <code>name</code> is not of type <code>int</code>. */ - public int getInt(String name); + int getInt(String name); /** * Returns the value of the identified statistic of type <code>long</code>. @@ -223,7 +223,7 @@ public interface Statistics { * @param id a statistic id obtained with {@link #nameToId} or {@link StatisticsType#nameToId}. * @throws ArrayIndexOutOfBoundsException If the id is invalid. */ - public long getLong(int id); + long getLong(int id); /** @@ -232,7 +232,7 @@ public interface Statistics { * @throws IllegalArgumentException If no statistic exists with the specified * <code>descriptor</code> or if the described statistic is not of type <code>long</code>. */ - public long getLong(StatisticDescriptor descriptor); + long getLong(StatisticDescriptor descriptor); /** * Returns the value of the statistic of type <code>long</code> at the given name. @@ -240,7 +240,7 @@ public interface Statistics { * @throws IllegalArgumentException If no statistic exists with name <code>name</code> or if the * statistic named <code>name</code> is not of type <code>long</code>. */ - public long getLong(String name); + long getLong(String name); /** * Returns the value of the identified statistic of type <code>double</code>. @@ -248,7 +248,7 @@ public interface Statistics { * @param id a statistic id obtained with {@link #nameToId} or {@link StatisticsType#nameToId}. * @throws ArrayIndexOutOfBoundsException If the id is invalid. */ - public double getDouble(int id); + double getDouble(int id); /** * Returns the value of the described statistic of type <code>double</code>. @@ -257,7 +257,7 @@ public interface Statistics { * <code>descriptor</code> or if the described statistic is not of type * <code>double</code>. */ - public double getDouble(StatisticDescriptor descriptor); + double getDouble(StatisticDescriptor descriptor); /** * Returns the value of the statistic of type <code>double</code> at the given name. @@ -265,7 +265,7 @@ public interface Statistics { * @throws IllegalArgumentException If no statistic exists with name <code>name</code> or if the * statistic named <code>name</code> is not of type <code>double</code>. */ - public double getDouble(String name); + double getDouble(String name); /** * Returns the value of the identified statistic. @@ -274,14 +274,14 @@ public interface Statistics { * {@link StatisticsType#nameToDescriptor}. * @throws IllegalArgumentException If the described statistic does not exist */ - public Number get(StatisticDescriptor descriptor); + Number get(StatisticDescriptor descriptor); /** * Returns the value of the named statistic. * * @throws IllegalArgumentException If the named statistic does not exist */ - public Number get(String name); + Number get(String name); /** * Returns the bits that represent the raw value of the described statistic. @@ -290,14 +290,14 @@ public interface Statistics { * {@link StatisticsType#nameToDescriptor}. * @throws IllegalArgumentException If the described statistic does not exist */ - public long getRawBits(StatisticDescriptor descriptor); + long getRawBits(StatisticDescriptor descriptor); /** * Returns the bits that represent the raw value of the named statistic. * * @throws IllegalArgumentException If the named statistic does not exist */ - public long getRawBits(String name); + long getRawBits(String name); //////////////////////// inc() Methods //////////////////////// @@ -308,7 +308,7 @@ public interface Statistics { * * @throws ArrayIndexOutOfBoundsException If the id is invalid. */ - public void incInt(int id, int delta); + void incInt(int id, int delta); /** * Increments the value of the described statistic of type <code>int</code> by the given amount. @@ -316,7 +316,7 @@ public interface Statistics { * @throws IllegalArgumentException If no statistic exists with the given <code>descriptor</code> * or if the described statistic is not of type <code>int</code>. */ - public void incInt(StatisticDescriptor descriptor, int delta); + void incInt(StatisticDescriptor descriptor, int delta); /** * Increments the value of the statistic of type <code>int</code> with the given name by a given @@ -325,7 +325,7 @@ public interface Statistics { * @throws IllegalArgumentException If no statistic exists with name <code>name</code> or if the * statistic named <code>name</code> is not of type <code>int</code>. */ - public void incInt(String name, int delta); + void incInt(String name, int delta); /** * Increments the value of the identified statistic of type <code>long</code> by the given amount. @@ -334,7 +334,7 @@ public interface Statistics { * * @throws ArrayIndexOutOfBoundsException If the id is invalid. */ - public void incLong(int id, long delta); + void incLong(int id, long delta); /** * Increments the value of the described statistic of type <code>long</code> by the given amount. @@ -342,7 +342,7 @@ public interface Statistics { * @throws IllegalArgumentException If no statistic exists with the given <code>descriptor</code> * or if the described statistic is not of type <code>long</code>. */ - public void incLong(StatisticDescriptor descriptor, long delta); + void incLong(StatisticDescriptor descriptor, long delta); /** * Increments the value of the statistic of type <code>long</code> with the given name by a given @@ -351,7 +351,7 @@ public interface Statistics { * @throws IllegalArgumentException If no statistic exists with name <code>name</code> or if the * statistic named <code>name</code> is not of type <code>long</code>. */ - public void incLong(String name, long delta); + void incLong(String name, long delta); /** * Increments the value of the identified statistic of type <code>double</code> by the given @@ -361,7 +361,7 @@ public interface Statistics { * * @throws ArrayIndexOutOfBoundsException If the id is invalid. */ - public void incDouble(int id, double delta); + void incDouble(int id, double delta); /** * Increments the value of the described statistic of type <code>double</code> by the given @@ -370,7 +370,7 @@ public interface Statistics { * @throws IllegalArgumentException If no statistic exists with the given <code>descriptor</code> * or if the described statistic is not of type <code>double</code>. */ - public void incDouble(StatisticDescriptor descriptor, double delta); + void incDouble(StatisticDescriptor descriptor, double delta); /** * Increments the value of the statistic of type <code>double</code> with the given name by a @@ -379,7 +379,7 @@ public interface Statistics { * @throws IllegalArgumentException If no statistic exists with name <code>name</code> or if the * statistic named <code>name</code> is not of type <code>double</code>. */ - public void incDouble(String name, double delta); + void incDouble(String name, double delta); /** * Provide a callback to compute the value of this statistic every sample interval and use that as @@ -404,7 +404,7 @@ public interface Statistics { * @throws IllegalArgumentException If the id is invalid. * @since Geode 1.0 */ - public IntSupplier setIntSupplier(int id, IntSupplier supplier); + IntSupplier setIntSupplier(int id, IntSupplier supplier); /** * Provide a callback to compute the value of this statistic every sample interval and use that as @@ -430,7 +430,7 @@ public interface Statistics { * statistic named <code>name</code> is not of type <code>int</code>. * @since Geode 1.0 */ - public IntSupplier setIntSupplier(String name, IntSupplier supplier); + IntSupplier setIntSupplier(String name, IntSupplier supplier); /** @@ -457,7 +457,7 @@ public interface Statistics { * or if the described statistic is not of type <code>int</code>. * @since Geode 1.0 */ - public IntSupplier setIntSupplier(StatisticDescriptor descriptor, IntSupplier supplier); + IntSupplier setIntSupplier(StatisticDescriptor descriptor, IntSupplier supplier); /** * Provide a callback to compute the value of this statistic every sample interval and use that as @@ -482,7 +482,7 @@ public interface Statistics { * @throws IllegalArgumentException If the id is invalid. * @since Geode 1.0 */ - public LongSupplier setLongSupplier(int id, LongSupplier supplier); + LongSupplier setLongSupplier(int id, LongSupplier supplier); /** * Provide a callback to compute the value of this statistic every sample interval and use that as @@ -507,7 +507,7 @@ public interface Statistics { * @throws IllegalArgumentException If no statistic exists with name <code>name</code> or if the * statistic named <code>name</code> is not of type <code>long</code>. */ - public LongSupplier setLongSupplier(String name, LongSupplier supplier); + LongSupplier setLongSupplier(String name, LongSupplier supplier); /** @@ -534,7 +534,7 @@ public interface Statistics { * or if the described statistic is not of type <code>long</code>. * @since Geode 1.0 */ - public LongSupplier setLongSupplier(StatisticDescriptor descriptor, LongSupplier supplier); + LongSupplier setLongSupplier(StatisticDescriptor descriptor, LongSupplier supplier); /** * Provide a callback to compute the value of this statistic every sample interval and use that as @@ -559,7 +559,7 @@ public interface Statistics { * @throws IllegalArgumentException If the id is invalid. * @since Geode 1.0 */ - public DoubleSupplier setDoubleSupplier(int id, DoubleSupplier supplier); + DoubleSupplier setDoubleSupplier(int id, DoubleSupplier supplier); /** * Provide a callback to compute the value of this statistic every sample interval and use that as @@ -585,7 +585,7 @@ public interface Statistics { * statistic named <code>name</code> is not of type <code>double</code>. * @since Geode 1.0 */ - public DoubleSupplier setDoubleSupplier(String name, DoubleSupplier supplier); + DoubleSupplier setDoubleSupplier(String name, DoubleSupplier supplier); /** @@ -612,5 +612,5 @@ public interface Statistics { * or if the described statistic is not of type <code>double</code>. * @since Geode 1.0 */ - public DoubleSupplier setDoubleSupplier(StatisticDescriptor descriptor, DoubleSupplier supplier); + DoubleSupplier setDoubleSupplier(StatisticDescriptor descriptor, DoubleSupplier supplier); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/StatisticsFactory.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/StatisticsFactory.java b/geode-core/src/main/java/org/apache/geode/StatisticsFactory.java index 8056b73..e0cdfff 100644 --- a/geode-core/src/main/java/org/apache/geode/StatisticsFactory.java +++ b/geode-core/src/main/java/org/apache/geode/StatisticsFactory.java @@ -107,7 +107,7 @@ public interface StatisticsFactory extends StatisticsTypeFactory { * <p> * The created instance may not be {@link Statistics#isAtomic atomic}. */ - public Statistics createStatistics(StatisticsType type); + Statistics createStatistics(StatisticsType type); /** * Creates and returns a {@link Statistics} instance of the given {@link StatisticsType type}, @@ -115,7 +115,7 @@ public interface StatisticsFactory extends StatisticsTypeFactory { * <p> * The created instance may not be {@link Statistics#isAtomic atomic}. */ - public Statistics createStatistics(StatisticsType type, String textId); + Statistics createStatistics(StatisticsType type, String textId); /** * Creates and returns a {@link Statistics} instance of the given {@link StatisticsType type}, @@ -123,7 +123,7 @@ public interface StatisticsFactory extends StatisticsTypeFactory { * <p> * The created instance may not be {@link Statistics#isAtomic atomic}. */ - public Statistics createStatistics(StatisticsType type, String textId, long numericId); + Statistics createStatistics(StatisticsType type, String textId, long numericId); /** * Creates and returns a {@link Statistics} instance of the given {@link StatisticsType type} with @@ -131,7 +131,7 @@ public interface StatisticsFactory extends StatisticsTypeFactory { * <p> * The created instance will be {@link Statistics#isAtomic atomic}. */ - public Statistics createAtomicStatistics(StatisticsType type); + Statistics createAtomicStatistics(StatisticsType type); /** * Creates and returns a {@link Statistics} instance of the given {@link StatisticsType type}, @@ -139,7 +139,7 @@ public interface StatisticsFactory extends StatisticsTypeFactory { * <p> * The created instance will be {@link Statistics#isAtomic atomic}. */ - public Statistics createAtomicStatistics(StatisticsType type, String textId); + Statistics createAtomicStatistics(StatisticsType type, String textId); /** * Creates and returns a {@link Statistics} instance of the given {@link StatisticsType type}, @@ -147,20 +147,20 @@ public interface StatisticsFactory extends StatisticsTypeFactory { * <p> * The created instance will be {@link Statistics#isAtomic atomic}. */ - public Statistics createAtomicStatistics(StatisticsType type, String textId, long numericId); + Statistics createAtomicStatistics(StatisticsType type, String textId, long numericId); /** * Returns an array of all the existing statistics of the given type. */ - public Statistics[] findStatisticsByType(StatisticsType type); + Statistics[] findStatisticsByType(StatisticsType type); /** * Returns an array of all the existing statistics with the given textId. */ - public Statistics[] findStatisticsByTextId(String textId); + Statistics[] findStatisticsByTextId(String textId); /** * Returns an array of all the existing statistics with the given numericId. */ - public Statistics[] findStatisticsByNumericId(long numericId); + Statistics[] findStatisticsByNumericId(long numericId); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/StatisticsType.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/StatisticsType.java b/geode-core/src/main/java/org/apache/geode/StatisticsType.java index fab47bf..7718c47 100644 --- a/geode-core/src/main/java/org/apache/geode/StatisticsType.java +++ b/geode-core/src/main/java/org/apache/geode/StatisticsType.java @@ -33,17 +33,17 @@ public interface StatisticsType { /** * Returns the name of this statistics type */ - public String getName(); + String getName(); /** * Returns a description of this statistics type */ - public String getDescription(); + String getDescription(); /** * Returns descriptions of the statistics that this statistics type gathers together */ - public StatisticDescriptor[] getStatistics(); + StatisticDescriptor[] getStatistics(); /** * Returns the id of the statistic with the given name in this statistics instance. @@ -51,7 +51,7 @@ public interface StatisticsType { * @throws IllegalArgumentException No statistic named <code>name</code> exists in this statistics * instance. */ - public int nameToId(String name); + int nameToId(String name); /** * Returns the descriptor of the statistic with the given name in this statistics instance. @@ -59,6 +59,6 @@ public interface StatisticsType { * @throws IllegalArgumentException No statistic named <code>name</code> exists in this statistics * instance. */ - public StatisticDescriptor nameToDescriptor(String name); + StatisticDescriptor nameToDescriptor(String name); }
