addressing review comments
Project: http://git-wip-us.apache.org/repos/asf/geode/repo Commit: http://git-wip-us.apache.org/repos/asf/geode/commit/495d788a Tree: http://git-wip-us.apache.org/repos/asf/geode/tree/495d788a Diff: http://git-wip-us.apache.org/repos/asf/geode/diff/495d788a Branch: refs/heads/feature/GEODE-3447 Commit: 495d788abd1935dea27b00ccc16e822eaf690b38 Parents: a2b678a Author: Bruce Schuchardt <[email protected]> Authored: Tue Aug 22 14:34:36 2017 -0700 Committer: Bruce Schuchardt <[email protected]> Committed: Tue Aug 22 14:46:13 2017 -0700 ---------------------------------------------------------------------- .../apache/geode/security/StreamAuthorizer.java | 17 ++++++++++++++--- .../protobuf/ProtobufSimpleAuthenticator.java | 1 + 2 files changed, 15 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/geode/blob/495d788a/geode-core/src/main/java/org/apache/geode/security/StreamAuthorizer.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/security/StreamAuthorizer.java b/geode-core/src/main/java/org/apache/geode/security/StreamAuthorizer.java index c6cef33..fdb6b17 100644 --- a/geode-core/src/main/java/org/apache/geode/security/StreamAuthorizer.java +++ b/geode-core/src/main/java/org/apache/geode/security/StreamAuthorizer.java @@ -1,8 +1,19 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ package org.apache.geode.security; -/** - * Created by bschuchardt on 8/17/17. - */ public interface StreamAuthorizer { boolean authorize(ResourcePermission permissionRequested); } http://git-wip-us.apache.org/repos/asf/geode/blob/495d788a/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSimpleAuthenticator.java ---------------------------------------------------------------------- diff --git a/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSimpleAuthenticator.java b/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSimpleAuthenticator.java index 4b702ea..77d473a 100644 --- a/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSimpleAuthenticator.java +++ b/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSimpleAuthenticator.java @@ -59,6 +59,7 @@ public class ProtobufSimpleAuthenticator implements StreamAuthenticator { @Override public boolean isAuthenticated() { + // note: an authorizer is only created if the user has been authenticated return authorizer != null; }
