This is an automated email from the ASF dual-hosted git repository.
udo pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git
The following commit(s) were added to refs/heads/develop by this push:
new 5df9016 GEODE-3733: Added Flaky test to the test
5df9016 is described below
commit 5df901673a77e9b1bf5f9545a3b27341e4aad489
Author: kohlmu-pivotal <[email protected]>
AuthorDate: Thu Oct 5 10:16:51 2017 -0700
GEODE-3733: Added Flaky test to the test
---
.../internal/protocol/protobuf/ProtobufStreamProcessor.java | 2 +-
.../protocol/acceptance/CacheMaxConnectionJUnitTest.java | 12 +++++-------
2 files changed, 6 insertions(+), 8 deletions(-)
diff --git
a/geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/ProtobufStreamProcessor.java
b/geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/ProtobufStreamProcessor.java
index de34a4a..5e06875 100644
---
a/geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/ProtobufStreamProcessor.java
+++
b/geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/ProtobufStreamProcessor.java
@@ -78,7 +78,7 @@ public class ProtobufStreamProcessor implements
ClientProtocolMessageHandler {
ClientProtocol.Message message =
protobufProtocolSerializer.deserialize(inputStream);
if (message == null) {
String errorMessage = "Tried to deserialize protobuf message at EOF";
- logger.warn(errorMessage);
+ logger.debug(errorMessage);
throw new EOFException(errorMessage);
}
statistics.messageReceived(message.getSerializedSize());
diff --git
a/geode-protobuf/src/test/java/org/apache/geode/internal/protocol/acceptance/CacheMaxConnectionJUnitTest.java
b/geode-protobuf/src/test/java/org/apache/geode/internal/protocol/acceptance/CacheMaxConnectionJUnitTest.java
index d1789ad..4607fab 100644
---
a/geode-protobuf/src/test/java/org/apache/geode/internal/protocol/acceptance/CacheMaxConnectionJUnitTest.java
+++
b/geode-protobuf/src/test/java/org/apache/geode/internal/protocol/acceptance/CacheMaxConnectionJUnitTest.java
@@ -57,23 +57,21 @@ import
org.apache.geode.internal.protocol.exception.InvalidProtocolMessageExcept
import
org.apache.geode.internal.protocol.protobuf.ProtobufSerializationService;
import
org.apache.geode.internal.protocol.protobuf.serializer.ProtobufProtocolSerializer;
import org.apache.geode.internal.protocol.protobuf.utilities.ProtobufUtilities;
+import org.apache.geode.test.junit.categories.FlakyTest;
import org.apache.geode.test.junit.categories.IntegrationTest;
/**
* Test that using the magic byte to indicate intend ot use ProtoBuf messages
works
*/
-@Category(IntegrationTest.class)
+@Category({IntegrationTest.class, FlakyTest.class})
public class CacheMaxConnectionJUnitTest {
private static final String TEST_KEY = "testKey";
private static final String TEST_VALUE = "testValue";
private static final int TEST_PUT_CORRELATION_ID = 12355;
- private final String TEST_REGION = "testRegion";
-
+ private static final String TEST_REGION = "testRegion";
private Cache cache;
- private int cacheServerPort;
private Socket socket;
- private OutputStream outputStream;
@Rule
public final RestoreSystemProperties restoreSystemProperties = new
RestoreSystemProperties();
@@ -94,7 +92,7 @@ public class CacheMaxConnectionJUnitTest {
cache = cacheFactory.create();
CacheServer cacheServer = cache.addCacheServer();
- cacheServerPort = AvailablePortHelper.getRandomAvailableTCPPort();
+ int cacheServerPort = AvailablePortHelper.getRandomAvailableTCPPort();
cacheServer.setPort(cacheServerPort);
cacheServer.start();
@@ -105,7 +103,7 @@ public class CacheMaxConnectionJUnitTest {
socket = new Socket("localhost", cacheServerPort);
Awaitility.await().atMost(5, TimeUnit.SECONDS).until(socket::isConnected);
- outputStream = socket.getOutputStream();
+ OutputStream outputStream = socket.getOutputStream();
outputStream.write(110);
serializationService = new ProtobufSerializationService();
--
To stop receiving notification emails like this one, please contact
['"[email protected]" <[email protected]>'].
