This is an automated email from the ASF dual-hosted git repository.

upthewaterspout pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/develop by this push:
     new 678f8d0  GEODE-3743: Deprecating manual-start of senders
678f8d0 is described below

commit 678f8d01c3be9dde1510010477cbe13164b9a151
Author: Dan Smith <[email protected]>
AuthorDate: Mon Oct 9 12:19:35 2017 -0700

    GEODE-3743: Deprecating manual-start of senders
---
 .../src/main/java/org/apache/geode/cache/wan/GatewaySender.java    | 7 ++++++-
 .../main/java/org/apache/geode/cache/wan/GatewaySenderFactory.java | 2 ++
 .../org/apache/geode/management/internal/cli/i18n/CliStrings.java  | 3 ++-
 .../META-INF/schemas/geode.apache.org/schema/cache/cache-1.0.xsd   | 7 ++++++-
 4 files changed, 16 insertions(+), 3 deletions(-)

diff --git 
a/geode-core/src/main/java/org/apache/geode/cache/wan/GatewaySender.java 
b/geode-core/src/main/java/org/apache/geode/cache/wan/GatewaySender.java
index 1dc1fb1..9bbbfbf 100644
--- a/geode-core/src/main/java/org/apache/geode/cache/wan/GatewaySender.java
+++ b/geode-core/src/main/java/org/apache/geode/cache/wan/GatewaySender.java
@@ -27,7 +27,10 @@ public interface GatewaySender {
 
   /**
    * The default value (false) for manually starting a 
<code>GatewaySender</code>.
+   * 
+   * @deprecated - Manual start of senders is deprecated and will be removed 
in a later release.
    */
+  @Deprecated
   public static final boolean DEFAULT_MANUAL_START = false;
 
   /**
@@ -368,8 +371,10 @@ public interface GatewaySender {
    * GatewaySender will automatically start once created.
    * 
    * @return the manual start boolean property for this GatewaySender
-   * 
+   *
+   * @deprecated - Manual start of senders is deprecated and will be removed 
in a later release.
    */
+  @Deprecated
   public boolean isManualStart();
 
   /**
diff --git 
a/geode-core/src/main/java/org/apache/geode/cache/wan/GatewaySenderFactory.java 
b/geode-core/src/main/java/org/apache/geode/cache/wan/GatewaySenderFactory.java
index 415ec3a..2967229 100644
--- 
a/geode-core/src/main/java/org/apache/geode/cache/wan/GatewaySenderFactory.java
+++ 
b/geode-core/src/main/java/org/apache/geode/cache/wan/GatewaySenderFactory.java
@@ -145,7 +145,9 @@ public interface GatewaySenderFactory {
    * i.e. the <code>GatewaySender</code> will automatically start once created.
    * 
    * @param start the manual start boolean property for this 
<code>GatewaySender</code>
+   * @deprecated - Manual start of senders is deprecated and will be removed 
in a later release.
    */
+  @Deprecated
   public GatewaySenderFactory setManualStart(boolean start);
 
   /**
diff --git 
a/geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
 
b/geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
index 07d1a19..db0b08c 100644
--- 
a/geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
+++ 
b/geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
@@ -2151,7 +2151,8 @@ public class CliStrings {
       "Whether this is Parallel GatewaySender.";
   public static final String CREATE_GATEWAYSENDER__MANUALSTART = 
"manual-start";
   public static final String CREATE_GATEWAYSENDER__MANUALSTART__HELP =
-      "Whether manual start is to be enabled or the sender will start 
automatically after creation.";
+      "Whether manual start is to be enabled or the sender will start 
automatically after creation.\n"
+          + "Deprecated: Manual start of senders is deprecated and will be 
removed in a later release.";
   public static final String CREATE_GATEWAYSENDER__SOCKETBUFFERSIZE = 
SOCKET_BUFFER_SIZE;
   public static final String CREATE_GATEWAYSENDER__SOCKETBUFFERSIZE__HELP =
       "The buffer size of the socket connection between this GatewaySender and 
its receiving GatewayReceiver.";
diff --git 
a/geode-core/src/main/resources/META-INF/schemas/geode.apache.org/schema/cache/cache-1.0.xsd
 
b/geode-core/src/main/resources/META-INF/schemas/geode.apache.org/schema/cache/cache-1.0.xsd
index 1bcd83a..f212490 100755
--- 
a/geode-core/src/main/resources/META-INF/schemas/geode.apache.org/schema/cache/cache-1.0.xsd
+++ 
b/geode-core/src/main/resources/META-INF/schemas/geode.apache.org/schema/cache/cache-1.0.xsd
@@ -184,7 +184,12 @@ declarative caching XML file elements unless indicated 
otherwise.
             <xsd:attribute name="id" type="xsd:string" use="required" />
             <xsd:attribute name="remote-distributed-system-id" 
type="xsd:string" use="required" />
             <xsd:attribute name="parallel" type="xsd:boolean" use="optional" />
-            <xsd:attribute name="manual-start" type="xsd:boolean" 
use="optional" />
+            <xsd:attribute name="manual-start" type="xsd:boolean" 
use="optional" >
+              <xsd:annotation>
+                <xsd:appinfo>deprecated</xsd:appinfo>
+                <xsd:documentation>Manual start of senders is deprecated and 
will be removed in a later release.</xsd:documentation>
+              </xsd:annotation>
+            </xsd:attribute>
             <xsd:attribute name="socket-buffer-size" type="xsd:string" 
use="optional" />
             <xsd:attribute name="socket-read-timeout" type="xsd:string" 
use="optional" />
             <xsd:attribute name="enable-batch-conflation" type="xsd:boolean" 
use="optional" />

-- 
To stop receiving notification emails like this one, please contact
['"[email protected]" <[email protected]>'].

Reply via email to