This is an automated email from the ASF dual-hosted git repository.
nreich pushed a commit to branch feature/GEODE-4017
in repository https://gitbox.apache.org/repos/asf/geode.git
The following commit(s) were added to refs/heads/feature/GEODE-4017 by this
push:
new 38d184d GEODE-4017: Fix access level of gfsh command
38d184d is described below
commit 38d184d6be6d731ae31f0bf8647ed2e300ff5a38
Author: Nick Reich <[email protected]>
AuthorDate: Thu Dec 7 17:53:47 2017 -0800
GEODE-4017: Fix access level of gfsh command
---
.../jdbc/internal/cli/AlterConnectionCommand.java | 2 +-
.../cli/AlterConnectionCommandDUnitTest.java | 20 +++++++++-----------
2 files changed, 10 insertions(+), 12 deletions(-)
diff --git
a/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/internal/cli/AlterConnectionCommand.java
b/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/internal/cli/AlterConnectionCommand.java
index 6b652e4..bace38d 100644
---
a/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/internal/cli/AlterConnectionCommand.java
+++
b/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/internal/cli/AlterConnectionCommand.java
@@ -60,7 +60,7 @@ public class AlterConnectionCommand implements GfshCommand {
@CliMetaData(relatedTopic = CliStrings.DEFAULT_TOPIC_GEODE)
@ResourceOperation(resource = ResourcePermission.Resource.CLUSTER,
operation = ResourcePermission.Operation.MANAGE)
- Result alterConnection(
+ public Result alterConnection(
@CliOption(key = ALTER_CONNECTION__NAME, mandatory = true,
help = ALTER_CONNECTION__NAME__HELP) String name,
@CliOption(key = ALTER_CONNECTION__URL, specifiedDefaultValue = "",
diff --git
a/geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/internal/cli/AlterConnectionCommandDUnitTest.java
b/geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/internal/cli/AlterConnectionCommandDUnitTest.java
index bf6618f..836029c 100644
---
a/geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/internal/cli/AlterConnectionCommandDUnitTest.java
+++
b/geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/internal/cli/AlterConnectionCommandDUnitTest.java
@@ -103,17 +103,15 @@ public class AlterConnectionCommandDUnitTest {
}
@Test
- public void altersConnectionByRemovingValues() throws Exception {
- /*
- * CommandStringBuilder csb = new
CommandStringBuilder(ALTER_JDBC_CONNECTION);
- * csb.addOption(ALTER_CONNECTION__NAME, "name");
csb.addOption(ALTER_CONNECTION__URL, "");
- * csb.addOption(ALTER_CONNECTION__USER, "");
csb.addOption(ALTER_CONNECTION__PASSWORD, "");
- * csb.addOption(ALTER_CONNECTION__PARAMS, "");
- *
- * gfsh.executeAndAssertThat(csb.toString()).statusIsSuccess();
- */
- String command = "alter jdbc-connection --name=name --url= --user=
--password= --params=";
- gfsh.executeAndAssertThat(command).statusIsSuccess();
+ public void altersConnectionByRemovingValues() {
+ CommandStringBuilder csb = new CommandStringBuilder(ALTER_JDBC_CONNECTION);
+ csb.addOption(ALTER_CONNECTION__NAME, "name");
+ csb.addOption(ALTER_CONNECTION__URL, "");
+ csb.addOption(ALTER_CONNECTION__USER, "");
+ csb.addOption(ALTER_CONNECTION__PASSWORD, "");
+ csb.addOption(ALTER_CONNECTION__PARAMS, "");
+
+ gfsh.executeAndAssertThat(csb.toString()).statusIsSuccess();
locator.invoke(() -> {
String xml =
InternalLocator.getLocator().getSharedConfiguration().getConfiguration("cluster")
--
To stop receiving notification emails like this one, please contact
['"[email protected]" <[email protected]>'].
