[geode] 02/02: GEODE-4085 The cache server thinks that all protobuf clients have a 10 second read timeout

[bschuchardt]

This is an automated email from the ASF dual-hosted git repository.

bschuchardt pushed a commit to branch feature/GEODE-4085
in repository https://gitbox.apache.org/repos/asf/geode.git

commit de013cf783e8558c73af4db5e4cf373faf92cf1f
Author: Bruce Schuchardt <bschucha...@pivotal.io>
AuthorDate: Tue Dec 12 15:17:09 2017 -0800

    GEODE-4085 The cache server thinks that all protobuf clients have a 10 
second read timeout
    
    Set the operation timeout to zero in order to keep in-process operations
    from having their connection timed out.
---
 .../cache/tier/sockets/GenericProtocolServerConnection.java         | 2 +-
 .../apache/geode/internal/cache/tier/sockets/ServerConnection.java  | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git 
a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
 
b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
index 736c7ad..374d54b 100644
--- 
a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
+++ 
b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
@@ -116,7 +116,7 @@ public class GenericProtocolServerConnection extends 
ServerConnection {
 
   @Override
   protected int getClientReadTimeout() {
-    return PoolFactory.DEFAULT_READ_TIMEOUT;
+    return 0;
   }
 
   @Override
diff --git 
a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
 
b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
index 368a2f8..5466922 100644
--- 
a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
+++ 
b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
@@ -1269,6 +1269,12 @@ public abstract class ServerConnection implements 
Runnable {
     this.requestSpecificTimeout = -1;
   }
 
+  /**
+   * Returns the client's read-timeout setting. This is used in the client 
health monitor to timeout
+   * connections that have taken too long & the client will have already given 
up waiting for a
+   * response. Certain messages also may include an override to the normal 
read-timeout, such as a
+   * query or a putAll.
+   */
   protected int getClientReadTimeout() {
     if (this.requestSpecificTimeout == -1) {
       return this.handshake.getClientReadTimeout();

-- 
To stop receiving notification emails like this one, please contact
"commits@geode.apache.org" <commits@geode.apache.org>.