This is an automated email from the ASF dual-hosted git repository.

eshu11 pushed a commit to branch feature/GEODE-551
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/feature/GEODE-551 by this push:
     new 240072a  remove a redundant check.
240072a is described below

commit 240072a43de6a48d726a4f6706cd7b8868f473c4
Author: eshu <[email protected]>
AuthorDate: Mon Dec 18 16:24:22 2017 -0800

    remove a redundant check.
---
 .../cache/management/MemoryThresholdsOffHeapDUnitTest.java  | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git 
a/geode-core/src/test/java/org/apache/geode/cache/management/MemoryThresholdsOffHeapDUnitTest.java
 
b/geode-core/src/test/java/org/apache/geode/cache/management/MemoryThresholdsOffHeapDUnitTest.java
index 3512b8c..ff195e0 100644
--- 
a/geode-core/src/test/java/org/apache/geode/cache/management/MemoryThresholdsOffHeapDUnitTest.java
+++ 
b/geode-core/src/test/java/org/apache/geode/cache/management/MemoryThresholdsOffHeapDUnitTest.java
@@ -1075,6 +1075,8 @@ public class MemoryThresholdsOffHeapDUnitTest extends 
ClientServerTestCase {
         new SerializableCallable("Set safe state on datastore, assert local 
load behavior") {
           public Object call() throws Exception {
             final PartitionedRegion r = (PartitionedRegion) 
getCache().getRegion(rName);
+            final OffHeapMemoryMonitor ohmm =
+                ((InternalResourceManager) 
getCache().getResourceManager()).getOffHeapMonitor();
 
             r.destroy("oh3");
             WaitCriterion wc = new WaitCriterion() {
@@ -1083,7 +1085,7 @@ public class MemoryThresholdsOffHeapDUnitTest extends 
ClientServerTestCase {
               }
 
               public boolean done() {
-                return !r.memoryThresholdReached.get();
+                return !ohmm.getState().isCritical();
               }
             };
             Wait.waitForCriterion(wc, 30 * 1000, 10, true);
@@ -1097,15 +1099,6 @@ public class MemoryThresholdsOffHeapDUnitTest extends 
ClientServerTestCase {
         });
     expectedInvocations.set(ex.intValue());
 
-    ds1.invoke(new SerializableCallable() {
-      public Object call() throws Exception {
-        final OffHeapMemoryMonitor ohmm =
-            ((InternalResourceManager) 
getCache().getResourceManager()).getOffHeapMonitor();
-        assertFalse(ohmm.getState().isCritical());
-        return null;
-      }
-    });
-
     accessor.invoke(new SerializableCallable(
         "Data store in safe state, assert load behavior, accessor sets 
critical state, assert load behavior") {
       public Object call() throws Exception {

-- 
To stop receiving notification emails like this one, please contact
['"[email protected]" <[email protected]>'].

Reply via email to