[geode] branch develop updated: GEODE-2569: Avoid unhelpful log message via a null check. (#1404)

[pivotalsarge]

This is an automated email from the ASF dual-hosted git repository.

pivotalsarge pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/develop by this push:
     new 17654b9  GEODE-2569: Avoid unhelpful log message via a null check. 
(#1404)
17654b9 is described below

commit 17654b9be859c59a7d26362d4a53851d3515a3ef
Author: Michael "Sarge" Dodge <mdo...@pivotal.io>
AuthorDate: Thu Feb 8 12:42:28 2018 -0800

    GEODE-2569: Avoid unhelpful log message via a null check. (#1404)
    
    - Since the default for "ack-severe-alert-threshold"
      is zero, there is a code path where the target member
      is null at the point of logging. So check for null.
---
 .../main/java/org/apache/geode/internal/tcp/ConnectionTable.java  | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git 
a/geode-core/src/main/java/org/apache/geode/internal/tcp/ConnectionTable.java 
b/geode-core/src/main/java/org/apache/geode/internal/tcp/ConnectionTable.java
index f7d104c..693e4f1 100644
--- 
a/geode-core/src/main/java/org/apache/geode/internal/tcp/ConnectionTable.java
+++ 
b/geode-core/src/main/java/org/apache/geode/internal/tcp/ConnectionTable.java
@@ -1255,9 +1255,11 @@ public class ConnectionTable {
         long now = System.currentTimeMillis();
         if (!severeAlertIssued && ackSATimeout > 0 && startTime + ackTimeout < 
now) {
           if (startTime + ackTimeout + ackSATimeout < now) {
-            logger.fatal(LocalizedMessage.create(
-                
LocalizedStrings.ConnectionTable_UNABLE_TO_FORM_A_TCPIP_CONNECTION_TO_0_IN_OVER_1_SECONDS,
-                new Object[] {targetMember, (ackSATimeout + ackTimeout) / 
1000}));
+            if (targetMember != null) {
+              logger.fatal(LocalizedMessage.create(
+                  
LocalizedStrings.ConnectionTable_UNABLE_TO_FORM_A_TCPIP_CONNECTION_TO_0_IN_OVER_1_SECONDS,
+                  new Object[] {targetMember, (ackSATimeout + ackTimeout) / 
1000}));
+            }
             severeAlertIssued = true;
           } else if (!suspected) {
             logger.warn(LocalizedMessage.create(

-- 
To stop receiving notification emails like this one, please contact
pivotalsa...@apache.org.