This is an automated email from the ASF dual-hosted git repository.

bschuchardt pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/develop by this push:
     new e44bf9e  GEODE-4377: Don't catch encoding exceptions in 
OperationHandlers
e44bf9e is described below

commit e44bf9e7bdbd9684c3194fc56468fdcd4b910b80
Author: Bruce Schuchardt <bschucha...@pivotal.io>
AuthorDate: Wed Feb 14 14:22:05 2018 -0800

    GEODE-4377: Don't catch encoding exceptions in OperationHandlers
    
    Galen pointed out that the changes for this ticket changed behavior when
    we get an encoding error.  The changes cause the connection to be closed
    but we used to leave it open.
    
    This commit reverts to the old behavior.  The connection will remain open
    and the client can continue to do goofy things and get error responses.
---
 .../geode/internal/protocol/protobuf/v1/ProtobufOpsProcessor.java    | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git 
a/geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/v1/ProtobufOpsProcessor.java
 
b/geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/v1/ProtobufOpsProcessor.java
index ff1aa1d..716288e 100644
--- 
a/geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/v1/ProtobufOpsProcessor.java
+++ 
b/geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/v1/ProtobufOpsProcessor.java
@@ -60,7 +60,10 @@ public class ProtobufOpsProcessor {
       // Don't move to a terminating state for authorization state failures
       logger.warn(e.getMessage());
       result = Failure.of(ProtobufResponseUtilities.makeErrorResponse(e));
-    } catch (EncodingException | DecodingException | ConnectionStateException 
e) {
+    } catch (EncodingException | DecodingException e) {
+      logger.warn(e.getMessage());
+      result = Failure.of(ProtobufResponseUtilities.makeErrorResponse(e));
+    } catch (ConnectionStateException e) {
       logger.warn(e.getMessage());
       messageExecutionContext
           .setConnectionStateProcessor(new 
ProtobufConnectionTerminatingStateProcessor());

-- 
To stop receiving notification emails like this one, please contact
bschucha...@apache.org.

Reply via email to