[geode] branch develop updated: GEODE-5044: Correctly log stack trace on the protobuf server

[upthewaterspout]

This is an automated email from the ASF dual-hosted git repository.

upthewaterspout pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/develop by this push:
     new 757e8f9  GEODE-5044: Correctly log stack trace on the protobuf server
757e8f9 is described below

commit 757e8f915b4fc7c6c3d637426c7015b9ade486f2
Author: Dan Smith <upthewatersp...@apache.org>
AuthorDate: Fri Apr 6 14:35:45 2018 -0700

    GEODE-5044: Correctly log stack trace on the protobuf server
    
    We were just logging the exception message, not the stack trace.
---
 .../geode/internal/protocol/protobuf/v1/ProtobufOpsProcessor.java   | 6 ++----
 .../internal/protocol/protobuf/v1/ProtobufStreamProcessor.java      | 2 +-
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git 
a/geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/v1/ProtobufOpsProcessor.java
 
b/geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/v1/ProtobufOpsProcessor.java
index ae0c122..189e89e 100644
--- 
a/geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/v1/ProtobufOpsProcessor.java
+++ 
b/geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/v1/ProtobufOpsProcessor.java
@@ -77,13 +77,11 @@ public class ProtobufOpsProcessor {
       return 
operationContext.getOperationHandler().process(context.getSerializationService(),
           operationContext.getFromRequest().apply(request), context);
     } catch (InvalidExecutionContextException exception) {
-      logger.error("Invalid execution context found for operation {}", 
requestType);
-      logger.error(exception);
+      logger.error("Invalid execution context found for operation {}", 
requestType, exception);
       return Failure.of(BasicTypes.ErrorCode.INVALID_REQUEST,
           "Invalid execution context found for operation.");
     } catch (UnsupportedOperationException exception) {
-      logger.error("Unsupported operation exception for request {}", 
requestType);
-      logger.error(exception);
+      logger.error("Unsupported operation exception for request {}", 
requestType, exception);
       return Failure.of(BasicTypes.ErrorCode.UNSUPPORTED_OPERATION,
           "Unsupported operation:" + exception.getMessage());
     } catch (NotAuthorizedException e) {
diff --git 
a/geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/v1/ProtobufStreamProcessor.java
 
b/geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/v1/ProtobufStreamProcessor.java
index dc4ea7d..0960e33 100644
--- 
a/geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/v1/ProtobufStreamProcessor.java
+++ 
b/geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/v1/ProtobufStreamProcessor.java
@@ -49,7 +49,7 @@ public class ProtobufStreamProcessor {
     try {
       processOneMessage(inputStream, outputStream, executionContext);
     } catch (InvalidProtocolMessageException e) {
-      logger.info(e);
+      logger.info("Invalid message", e);
       throw new IOException(e);
     }
   }

-- 
To stop receiving notification emails like this one, please contact
upthewatersp...@apache.org.