This is an automated email from the ASF dual-hosted git repository. prhomberg pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/geode.git
The following commit(s) were added to refs/heads/develop by this push: new ca98d86 GEODE-4954, GEODE-4955: Remove trivial javadoc stubs and empty blocks: non geode-core modules (#1787) ca98d86 is described below commit ca98d86c12a3b3d28d859bbced8f7a5dd9730cc4 Author: Patrick Rhomberg <prhomb...@pivotal.io> AuthorDate: Fri Apr 13 13:09:08 2018 -0700 GEODE-4954, GEODE-4955: Remove trivial javadoc stubs and empty blocks: non geode-core modules (#1787) --- .../session/internal/common/ClientServerSessionCache.java | 2 -- .../modules/session/internal/common/PeerToPeerSessionCache.java | 3 --- .../modules/session/internal/filter/GemfireHttpSession.java | 1 - .../modules/session/internal/filter/GemfireSessionManager.java | 1 - .../session/internal/filter/attributes/SessionAttributes.java | 1 - .../geode/modules/session/internal/filter/util/TypeAwareMap.java | 3 --- .../geode/modules/session/filter/SessionCachingFilter.java | 2 -- .../org/apache/geode/modules/session/installer/Installer.java | 3 --- .../apache/geode/modules/session/installer/args/Argument.java | 1 - .../java/org/apache/geode/modules/session/CommandServlet.java | 7 ------- .../org/apache/geode/internal/ra/GFConnectionFactoryImpl.java | 4 ---- .../jca/java/org/apache/geode/internal/ra/GFConnectionImpl.java | 4 ---- .../geode/internal/ra/spi/JCAManagedConnectionFactory.java | 4 ---- .../geode/internal/ra/spi/JCAManagedConnectionMetaData.java | 4 ---- .../org/apache/geode/cache/query/internal/cq/ServerCQImpl.java | 1 - .../main/java/org/apache/geode/experimental/driver/Driver.java | 1 - .../java/org/apache/geode/experimental/driver/DriverFactory.java | 1 - .../org/apache/geode/experimental/driver/ProtobufDriver.java | 1 - .../org/apache/geode/experimental/driver/ProtobufRegion.java | 1 - .../main/java/org/apache/geode/experimental/driver/Region.java | 9 --------- .../org/apache/geode/experimental/driver/ValueSerializer.java | 1 - .../main/java/org/apache/geode/test/compiler/ClassBuilder.java | 1 - .../java/org/apache/geode/cache/lucene/LuceneQueryFactory.java | 4 ---- .../main/java/org/apache/geode/cache/lucene/LuceneService.java | 1 - .../geode/cache/lucene/internal/distributed/TopEntries.java | 1 - .../cache/lucene/internal/filesystem/SeekableInputStream.java | 1 - .../geode/cache/lucene/internal/repository/IndexRepository.java | 6 ------ .../com/gemstone/gemfire/cache/execute/FunctionException.java | 5 ----- .../org/apache/geode/protocol/serialization/ValueSerializer.java | 2 -- .../geode/tools/pulse/internal/controllers/PulseController.java | 3 --- .../java/org/apache/geode/tools/pulse/internal/data/Cluster.java | 4 ---- .../org/apache/geode/tools/pulse/internal/data/DataBrowser.java | 1 - .../pulse/internal/service/ClusterMembersRGraphService.java | 5 ----- .../geode/tools/pulse/internal/service/ClusterRegionService.java | 1 - .../tools/pulse/internal/service/ClusterRegionsService.java | 1 - .../pulse/internal/service/ClusterSelectedRegionService.java | 1 - .../geode/tools/pulse/internal/service/SystemAlertsService.java | 1 - .../apache/geode/tools/pulse/internal/util/ConnectionUtil.java | 4 ---- .../org/apache/geode/tools/pulse/internal/util/TimeUtils.java | 2 -- .../geode/cache/client/internal/locator/wan/LocatorHelper.java | 9 --------- .../internal/locator/wan/LocatorMembershipListenerImpl.java | 2 -- .../client/internal/locator/wan/RemoteLocatorPingRequest.java | 5 ----- .../client/internal/locator/wan/RemoteLocatorPingResponse.java | 3 --- .../cache/client/internal/locator/wan/RemoteLocatorRequest.java | 4 ---- .../cache/client/internal/locator/wan/RemoteLocatorResponse.java | 4 ---- .../client/internal/locator/wan/WanLocatorDiscovererImpl.java | 4 ---- .../internal/cache/wan/GatewaySenderEventRemoteDispatcher.java | 2 -- .../wan/parallel/RemoteParallelGatewaySenderEventProcessor.java | 1 - 48 files changed, 133 deletions(-) diff --git a/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/common/ClientServerSessionCache.java b/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/common/ClientServerSessionCache.java index 53d1368..6d906e6 100644 --- a/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/common/ClientServerSessionCache.java +++ b/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/common/ClientServerSessionCache.java @@ -55,8 +55,6 @@ public class ClientServerSessionCache extends AbstractSessionCache { /** * Constructor * - * @param cache - * @param properties */ public ClientServerSessionCache(ClientCache cache, Map<CacheProperty, Object> properties) { super(); diff --git a/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/common/PeerToPeerSessionCache.java b/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/common/PeerToPeerSessionCache.java index d4ee064..4f1d4da 100644 --- a/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/common/PeerToPeerSessionCache.java +++ b/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/common/PeerToPeerSessionCache.java @@ -51,8 +51,6 @@ public class PeerToPeerSessionCache extends AbstractSessionCache { /** * Constructor * - * @param cache - * @param properties */ public PeerToPeerSessionCache(Cache cache, Map<CacheProperty, Object> properties) { super(); @@ -138,7 +136,6 @@ public class PeerToPeerSessionCache extends AbstractSessionCache { /** * Create a local region fronting the main region. * - * @return */ private Region<String, HttpSession> createOrRetrieveLocalRegion() { // Attempt to retrieve the fronting region diff --git a/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/GemfireHttpSession.java b/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/GemfireHttpSession.java index 1c9857d..9db83a3 100644 --- a/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/GemfireHttpSession.java +++ b/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/GemfireHttpSession.java @@ -432,7 +432,6 @@ public class GemfireHttpSession implements HttpSession, DataSerializable, Delta /** * The {@code SessionManager} injects this when creating a new session. * - * @param attributes */ public void setAttributes(AbstractSessionAttributes attributes) { this.attributes = attributes; diff --git a/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/GemfireSessionManager.java b/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/GemfireSessionManager.java index 2990c8f..af46283 100644 --- a/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/GemfireSessionManager.java +++ b/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/GemfireSessionManager.java @@ -300,7 +300,6 @@ public class GemfireSessionManager implements SessionManager { /** * Start the underlying distributed system * - * @param config */ private void startDistributedSystem(FilterConfig config) { // Get the distributedCache type diff --git a/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/attributes/SessionAttributes.java b/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/attributes/SessionAttributes.java index 6daed5e..e928eda 100644 --- a/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/attributes/SessionAttributes.java +++ b/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/attributes/SessionAttributes.java @@ -109,7 +109,6 @@ public interface SessionAttributes extends DataSerializable { /** * Set the jvmId. This is set every time the attributes are flushed to the cache. * - * @param jvmId */ void setJvmOwnerId(String jvmId); diff --git a/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/util/TypeAwareMap.java b/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/util/TypeAwareMap.java index 184a86d..ee45208 100644 --- a/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/util/TypeAwareMap.java +++ b/extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/util/TypeAwareMap.java @@ -19,9 +19,6 @@ import java.util.HashMap; import org.apache.geode.modules.session.internal.common.CacheProperty; -/** - * - */ public class TypeAwareMap<K extends CacheProperty, Object> extends HashMap { private Class<K> keyType; diff --git a/extensions/geode-modules-session/src/main/java/org/apache/geode/modules/session/filter/SessionCachingFilter.java b/extensions/geode-modules-session/src/main/java/org/apache/geode/modules/session/filter/SessionCachingFilter.java index 3494ff1..6a2bb59 100644 --- a/extensions/geode-modules-session/src/main/java/org/apache/geode/modules/session/filter/SessionCachingFilter.java +++ b/extensions/geode-modules-session/src/main/java/org/apache/geode/modules/session/filter/SessionCachingFilter.java @@ -472,8 +472,6 @@ public class SessionCachingFilter implements Filter { /** * This is where all the initialization happens. * - * @param config - * @throws ServletException */ @Override public void init(final FilterConfig config) { diff --git a/extensions/geode-modules-session/src/main/java/org/apache/geode/modules/session/installer/Installer.java b/extensions/geode-modules-session/src/main/java/org/apache/geode/modules/session/installer/Installer.java index 44ca043..a9885fc 100644 --- a/extensions/geode-modules-session/src/main/java/org/apache/geode/modules/session/installer/Installer.java +++ b/extensions/geode-modules-session/src/main/java/org/apache/geode/modules/session/installer/Installer.java @@ -40,9 +40,6 @@ import org.apache.geode.modules.session.installer.args.ArgumentValues; import org.apache.geode.modules.session.installer.args.UnknownArgumentHandler; import org.apache.geode.modules.session.installer.args.UsageException; -/** - * - */ public class Installer { private static final String GEMFIRE_FILTER_CLASS = diff --git a/extensions/geode-modules-session/src/main/java/org/apache/geode/modules/session/installer/args/Argument.java b/extensions/geode-modules-session/src/main/java/org/apache/geode/modules/session/installer/args/Argument.java index 53a6f77..fc2ca4e 100644 --- a/extensions/geode-modules-session/src/main/java/org/apache/geode/modules/session/installer/args/Argument.java +++ b/extensions/geode-modules-session/src/main/java/org/apache/geode/modules/session/installer/args/Argument.java @@ -187,7 +187,6 @@ public class Argument { /** * Returns a usage description of this argument. * - * @return description */ public String getDescription() { return description; diff --git a/extensions/session-testing-war/src/main/java/org/apache/geode/modules/session/CommandServlet.java b/extensions/session-testing-war/src/main/java/org/apache/geode/modules/session/CommandServlet.java index ba65cc6..820f91b5 100644 --- a/extensions/session-testing-war/src/main/java/org/apache/geode/modules/session/CommandServlet.java +++ b/extensions/session-testing-war/src/main/java/org/apache/geode/modules/session/CommandServlet.java @@ -27,9 +27,6 @@ import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpSession; -/** - * - */ public class CommandServlet extends HttpServlet { private ServletContext context; @@ -37,9 +34,6 @@ public class CommandServlet extends HttpServlet { /** * The standard servlet method overridden. * - * @param request - * @param response - * @throws IOException */ @Override protected void doGet(HttpServletRequest request, HttpServletResponse response) @@ -102,7 +96,6 @@ public class CommandServlet extends HttpServlet { /** * Save a reference to the ServletContext for later use. * - * @param config */ @Override public void init(ServletConfig config) { diff --git a/geode-core/src/jca/java/org/apache/geode/internal/ra/GFConnectionFactoryImpl.java b/geode-core/src/jca/java/org/apache/geode/internal/ra/GFConnectionFactoryImpl.java index 5e99790..6e2b6d0 100644 --- a/geode-core/src/jca/java/org/apache/geode/internal/ra/GFConnectionFactoryImpl.java +++ b/geode-core/src/jca/java/org/apache/geode/internal/ra/GFConnectionFactoryImpl.java @@ -22,10 +22,6 @@ import javax.resource.spi.ManagedConnectionFactory; import org.apache.geode.ra.GFConnectionFactory; -/** - * - * - */ public class GFConnectionFactoryImpl implements GFConnectionFactory { private final ConnectionManager cm; diff --git a/geode-core/src/jca/java/org/apache/geode/internal/ra/GFConnectionImpl.java b/geode-core/src/jca/java/org/apache/geode/internal/ra/GFConnectionImpl.java index af239b4..dcd9f45 100644 --- a/geode-core/src/jca/java/org/apache/geode/internal/ra/GFConnectionImpl.java +++ b/geode-core/src/jca/java/org/apache/geode/internal/ra/GFConnectionImpl.java @@ -21,10 +21,6 @@ import javax.resource.ResourceException; import org.apache.geode.internal.ra.spi.JCAManagedConnection; import org.apache.geode.ra.GFConnection; -/** - * - * - */ public class GFConnectionImpl implements GFConnection { private JCAManagedConnection mc; diff --git a/geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCAManagedConnectionFactory.java b/geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCAManagedConnectionFactory.java index 4313070..68e8065 100644 --- a/geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCAManagedConnectionFactory.java +++ b/geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCAManagedConnectionFactory.java @@ -26,10 +26,6 @@ import javax.security.auth.Subject; import org.apache.geode.internal.ra.GFConnectionFactoryImpl; -/** - * - * - */ public class JCAManagedConnectionFactory implements ManagedConnectionFactory { private String productName; diff --git a/geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCAManagedConnectionMetaData.java b/geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCAManagedConnectionMetaData.java index 46ae8f7..48f09f0 100644 --- a/geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCAManagedConnectionMetaData.java +++ b/geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCAManagedConnectionMetaData.java @@ -17,10 +17,6 @@ package org.apache.geode.internal.ra.spi; import javax.resource.ResourceException; import javax.resource.spi.ManagedConnectionMetaData; -/** - * - * - */ public class JCAManagedConnectionMetaData implements ManagedConnectionMetaData { private final String prodName; diff --git a/geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/ServerCQImpl.java b/geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/ServerCQImpl.java index 83e6bb8..35c3c5d 100644 --- a/geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/ServerCQImpl.java +++ b/geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/ServerCQImpl.java @@ -482,7 +482,6 @@ public class ServerCQImpl extends CqQueryImpl implements DataSerializable, Serve /** * Get CacheClientNotifier of this CqQuery. * - * @return CacheClientNotifier */ public CacheClientNotifier getCacheClientNotifier() { return this.ccn; diff --git a/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/Driver.java b/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/Driver.java index 57a4d05..400656f 100644 --- a/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/Driver.java +++ b/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/Driver.java @@ -33,7 +33,6 @@ public interface Driver { * connected. * * @return Set of strings of names that uniquely identify regions. - * @throws IOException */ Set<String> getRegionNames() throws IOException; diff --git a/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/DriverFactory.java b/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/DriverFactory.java index 537539f..acf92fe 100644 --- a/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/DriverFactory.java +++ b/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/DriverFactory.java @@ -149,7 +149,6 @@ public class DriverFactory { * Creates a driver configured to use all the locators about which this driver factory knows. * * @return New driver. - * @throws Exception */ public Driver create() throws Exception { return new ProtobufDriver(locators, username, password, keyStorePath, trustStorePath, protocols, diff --git a/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/ProtobufDriver.java b/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/ProtobufDriver.java index eb91c42..0698ece 100644 --- a/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/ProtobufDriver.java +++ b/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/ProtobufDriver.java @@ -53,7 +53,6 @@ public class ProtobufDriver implements Driver { * @param trustStorePath Path to SSL trust store; SSL is <em>not</em> used if <code>null</code>. * @param protocols Space-separated list of the SSL protocols to enable. * @param ciphers Space-separated list of the SSL cipher suites to enable. - * @throws IOException */ ProtobufDriver(Set<InetSocketAddress> locators, String username, String password, String keyStorePath, String trustStorePath, String protocols, String ciphers, diff --git a/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/ProtobufRegion.java b/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/ProtobufRegion.java index d69150a..e805596 100644 --- a/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/ProtobufRegion.java +++ b/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/ProtobufRegion.java @@ -55,7 +55,6 @@ public class ProtobufRegion<K, V> implements Region<K, V> { * <code>socket</code> to a GemFire server. * * @param name String that uniquely identifies the region. - * @param valueEncoder */ ProtobufRegion(String name, ProtobufChannel channel, ValueEncoder valueEncoder) { this.name = name; diff --git a/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/Region.java b/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/Region.java index 32cb381..2c9403d 100644 --- a/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/Region.java +++ b/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/Region.java @@ -38,7 +38,6 @@ public interface Region<K, V> { * Gets the number of entries in this region. * * @return Non-negative integer count. - * @throws IOException */ int size() throws IOException; @@ -47,7 +46,6 @@ public interface Region<K, V> { * * @param key Unique key associated with a value. * @return Value, if any, associated with <code>key</code>. - * @throws IOException */ V get(K key) throws IOException; @@ -56,7 +54,6 @@ public interface Region<K, V> { * * @param keys Collection of unique keys associated with values. * @return Map from <code>keys</code> to their associated values. - * @throws IOException */ Map<K, V> getAll(Collection<K> keys) throws IOException; @@ -65,7 +62,6 @@ public interface Region<K, V> { * * @param key Unique key to associate with the <code>value</code>. * @param value Value to associate with the <code>key</code>. - * @throws IOException */ void put(K key, V value) throws IOException; @@ -74,14 +70,12 @@ public interface Region<K, V> { * not be inserted, the remaining pair insertions will be attempted. * * @param values Map from <code>keys</code> to their associated values. - * @throws IOException */ void putAll(Map<K, V> values) throws IOException; /** * Removes all keys and values associated from this region. * - * @throws IOException */ void clear() throws IOException; @@ -92,7 +86,6 @@ public interface Region<K, V> { * @return null if the value was set; the current value otherwise. * NOTE that if the value in the region was set to null, this method will return null * without setting a new value. - * @throws IOException */ V putIfAbsent(K key, V value) throws IOException; @@ -100,7 +93,6 @@ public interface Region<K, V> { * Removes any value associated with the <code>key</code> from this region. * * @param key Unique key associated with a value. - * @throws IOException */ void remove(K key) throws IOException; @@ -108,7 +100,6 @@ public interface Region<K, V> { * Gets all the keys for which this region has entries * * @return Set of keys in this region - * @throws IOException */ Set<K> keySet() throws IOException; } diff --git a/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/ValueSerializer.java b/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/ValueSerializer.java index 801ab54..3bbbc65 100644 --- a/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/ValueSerializer.java +++ b/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/ValueSerializer.java @@ -51,7 +51,6 @@ public interface ValueSerializer { * True if this serializer wants to serialize all values, including primitives like * numbers and strings that can be sent as one of the options in EncodedValue. * - * @return */ boolean supportsPrimitives(); } diff --git a/geode-junit/src/main/java/org/apache/geode/test/compiler/ClassBuilder.java b/geode-junit/src/main/java/org/apache/geode/test/compiler/ClassBuilder.java index a3291e7..58167ae 100644 --- a/geode-junit/src/main/java/org/apache/geode/test/compiler/ClassBuilder.java +++ b/geode-junit/src/main/java/org/apache/geode/test/compiler/ClassBuilder.java @@ -178,7 +178,6 @@ public class ClassBuilder implements Serializable { * @param className Name of the class to compile. * @param classCode Plain text contents of the class * @return The byte contents of the compiled class. - * @throws IOException */ public byte[] compileClass(final String className, final String classCode) throws IOException { ByteArrayOutputStream byteArrayOutputStream = new ByteArrayOutputStream(); diff --git a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQueryFactory.java b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQueryFactory.java index 9663d18..8cf29bc 100644 --- a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQueryFactory.java +++ b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQueryFactory.java @@ -44,8 +44,6 @@ public interface LuceneQueryFactory { /** * Set page size for a query result. The default page size is 0 which means no pagination. * - * @param pageSize - * @return itself * @throws IllegalArgumentException if the value is less than 0 */ LuceneQueryFactory setPageSize(int pageSize); @@ -54,8 +52,6 @@ public interface LuceneQueryFactory { * Set maximum number of results for a query. By default, the limit is set to * {@link #DEFAULT_LIMIT} which is 100. * - * @param limit - * @return itself * @throws IllegalArgumentException if the value is less than or equal to zero. */ LuceneQueryFactory setLimit(int limit); diff --git a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneService.java b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneService.java index 8fd9789..23f2c28 100644 --- a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneService.java +++ b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneService.java @@ -147,7 +147,6 @@ public interface LuceneService { /** * returns the cache to which the LuceneService belongs * - * @return Cache */ Cache getCache(); diff --git a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/TopEntries.java b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/TopEntries.java index 724f5a8..88417c3 100644 --- a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/TopEntries.java +++ b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/TopEntries.java @@ -57,7 +57,6 @@ public class TopEntries<K> implements DataSerializableFixedID { * Adds an entry to the collection. The new entry must have a lower score than all previous * entries added to the collection. The new entry will be ignored if the limit is already reached. * - * @param entry */ public void addHit(EntryScore<K> entry) { if (hits.size() > 0) { diff --git a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/filesystem/SeekableInputStream.java b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/filesystem/SeekableInputStream.java index 5db7e56..3f93583 100644 --- a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/filesystem/SeekableInputStream.java +++ b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/filesystem/SeekableInputStream.java @@ -27,7 +27,6 @@ public abstract class SeekableInputStream extends InputStream { * Seek to a position in the stream. The position is relative to the beginning of the stream (in * other words, just before the first byte that was ever read). * - * @param position * @throws IOException if the seek goes past the end of the stream */ public abstract void seek(long position) throws IOException; diff --git a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepository.java b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepository.java index a4b7e1b..04393d2 100644 --- a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepository.java +++ b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepository.java @@ -30,21 +30,18 @@ public interface IndexRepository { /** * Create a new entry in the lucene index * - * @throws IOException */ void create(Object key, Object value) throws IOException; /** * Update the entries in the lucene index * - * @throws IOException */ void update(Object key, Object value) throws IOException; /** * Delete the entries in the lucene index * - * @throws IOException */ void delete(Object key) throws IOException; @@ -52,18 +49,15 @@ public interface IndexRepository { * Query the index index repository, passing the results to the collector Only the documents with * the top scores, up to the limit, will be passed to the collector, in order of score. * - * @param query * @param limit the maximum number of hits to return * @param collector the class to aggregate the hits * - * @throws IOException */ void query(Query query, int limit, IndexResultCollector collector) throws IOException; /** * Commit the changes to all lucene index * - * @throws IOException */ void commit() throws IOException; diff --git a/geode-old-client-support/src/main/java/com/gemstone/gemfire/cache/execute/FunctionException.java b/geode-old-client-support/src/main/java/com/gemstone/gemfire/cache/execute/FunctionException.java index ea2fcf8..eebf9ce 100644 --- a/geode-old-client-support/src/main/java/com/gemstone/gemfire/cache/execute/FunctionException.java +++ b/geode-old-client-support/src/main/java/com/gemstone/gemfire/cache/execute/FunctionException.java @@ -59,7 +59,6 @@ public class FunctionException extends GemFireException { /** * Creates new function exception with given error message. * - * @param msg * @since GemFire 6.0 */ public FunctionException(String msg) { @@ -69,8 +68,6 @@ public class FunctionException extends GemFireException { /** * Creates new function exception with given error message and optional nested exception. * - * @param msg - * @param cause * @since GemFire 6.0 */ public FunctionException(String msg, Throwable cause) { @@ -80,7 +77,6 @@ public class FunctionException extends GemFireException { /** * Creates new function exception given throwable as a cause and source of error message. * - * @param cause * @since GemFire 6.0 */ public FunctionException(Throwable cause) { @@ -90,7 +86,6 @@ public class FunctionException extends GemFireException { /** * Adds exceptions thrown from different nodes to a ds * - * @param cause * @since GemFire 6.5 */ public void addException(Throwable cause) { diff --git a/geode-protobuf/src/main/java/org/apache/geode/protocol/serialization/ValueSerializer.java b/geode-protobuf/src/main/java/org/apache/geode/protocol/serialization/ValueSerializer.java index 192d0c6..6afaa99 100644 --- a/geode-protobuf/src/main/java/org/apache/geode/protocol/serialization/ValueSerializer.java +++ b/geode-protobuf/src/main/java/org/apache/geode/protocol/serialization/ValueSerializer.java @@ -76,7 +76,6 @@ public interface ValueSerializer { * Initialize this serializer. This method is called when a new connection is established that * requests this format. * - * @param cache */ void init(Cache cache); @@ -90,7 +89,6 @@ public interface ValueSerializer { * True if this serializer wants to serialize all values, including primitives like * numbers and strings that can be sent as one of the options in EncodedValue. * - * @return */ default boolean supportsPrimitives() { return false; diff --git a/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/controllers/PulseController.java b/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/controllers/PulseController.java index 2af8b56..b74c243 100644 --- a/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/controllers/PulseController.java +++ b/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/controllers/PulseController.java @@ -136,8 +136,6 @@ public class PulseController { /** * Method isUserLoggedIn Check whether user is logged in or not. * - * @param request - * @return boolean */ protected boolean isUserLoggedIn(HttpServletRequest request) { return null != request.getUserPrincipal(); @@ -265,7 +263,6 @@ public class PulseController { /** * This method creates json for list of cluster regions * - * @param cluster * @return ArrayNode JSON array */ private ArrayNode getRegionsJson(Cluster cluster) { diff --git a/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Cluster.java b/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Cluster.java index ee5a665..c531b1d 100644 --- a/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Cluster.java +++ b/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Cluster.java @@ -1298,9 +1298,6 @@ public class Cluster extends Thread { return this.localMaxMemory; } - /** - * @param localMaxMemory - */ public void setLocalMaxMemory(int localMaxMemory) { this.localMaxMemory = localMaxMemory; } @@ -2873,7 +2870,6 @@ public class Cluster extends Thread { * '-' * * - * @param memberKey * @return the Member for a given key */ public Cluster.Member getMember(String memberKey) { diff --git a/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/DataBrowser.java b/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/DataBrowser.java index 3a7e7d7..8796440 100644 --- a/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/DataBrowser.java +++ b/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/DataBrowser.java @@ -87,7 +87,6 @@ public class DataBrowser { * * @param userId Logged in user's Unique Id * @param queryId Unique Id of Query to be deleted - * @return boolean */ public boolean deleteQueryById(String userId, String queryId) { diff --git a/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterMembersRGraphService.java b/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterMembersRGraphService.java index 73648da..3968120 100644 --- a/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterMembersRGraphService.java +++ b/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterMembersRGraphService.java @@ -107,9 +107,6 @@ public class ClusterMembersRGraphService implements PulseService { * cluster. This function create json based on the relation of physical host and members related * to it. * - * @param cluster - * @param host - * @param port * @return Array list of JSON objects for required fields of members in cluster */ private ObjectNode getPhysicalServerJson(Cluster cluster, String host, String port) { @@ -264,7 +261,6 @@ public class ClusterMembersRGraphService implements PulseService { * * @param member Member * @param memberState i.e Severe, Error, Warning or Normal - * @return */ private String getMemberNodeType(Cluster.Member member, String memberState) { String memberNodeType = ""; @@ -293,7 +289,6 @@ public class ClusterMembersRGraphService implements PulseService { * function used for getting list of all the alerts and save the member names in respective error, * warning and severe alert lists * - * @param cluster */ private void updateAlertLists(Cluster cluster) { diff --git a/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterRegionService.java b/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterRegionService.java index 5457f76..fe13eb9 100644 --- a/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterRegionService.java +++ b/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterRegionService.java @@ -93,7 +93,6 @@ public class ClusterRegionService implements PulseService { * This method is used to get various regions associated with the given cluster and create json * for each region fields and returns Array List for all the regions associated with given cluster * - * @param cluster * @return ArrayNode Array List */ private ArrayNode getRegionJson(Cluster cluster) { diff --git a/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterRegionsService.java b/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterRegionsService.java index f68cf0b..81c5345 100644 --- a/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterRegionsService.java +++ b/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterRegionsService.java @@ -87,7 +87,6 @@ public class ClusterRegionsService implements PulseService { * This method is used to get various regions associated with the given cluster and create json * for each region fields and returns Array List for all the regions associated with given cluster * - * @param cluster * @return JSONObject Array List */ private ArrayNode getRegionJson(Cluster cluster) { diff --git a/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterSelectedRegionService.java b/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterSelectedRegionService.java index 5163553..23158c2 100644 --- a/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterSelectedRegionService.java +++ b/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterSelectedRegionService.java @@ -101,7 +101,6 @@ public class ClusterSelectedRegionService implements PulseService { /** * Create JSON for selected cluster region * - * @param cluster * @return ObjectNode Array List */ private ObjectNode getSelectedRegionJson(Cluster cluster, String selectedRegionFullPath) { diff --git a/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/SystemAlertsService.java b/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/SystemAlertsService.java index 4e2754b..0a1c59f 100644 --- a/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/SystemAlertsService.java +++ b/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/SystemAlertsService.java @@ -79,7 +79,6 @@ public class SystemAlertsService implements PulseService { * function used for getting all members details in format of JSON Object array defined under a * cluster * - * @param cluster * @return JSONObject Array list */ public static ObjectNode getAlertsJson(Cluster cluster, int pageNumber) { diff --git a/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/util/ConnectionUtil.java b/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/util/ConnectionUtil.java index 445df92..e8af849 100644 --- a/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/util/ConnectionUtil.java +++ b/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/util/ConnectionUtil.java @@ -22,10 +22,6 @@ import javax.net.SocketFactory; import javax.net.ssl.SSLSocketFactory; -/** - * - * - */ public class ConnectionUtil { diff --git a/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/util/TimeUtils.java b/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/util/TimeUtils.java index 701fba3..5546863 100644 --- a/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/util/TimeUtils.java +++ b/geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/util/TimeUtils.java @@ -32,7 +32,6 @@ public class TimeUtils { * and seconds * * @param longMilliSecs Time in milliseconds. - * @return String */ public static String convertTimeMillisecondsToHMS(long longMilliSecs) { @@ -75,7 +74,6 @@ public class TimeUtils { * seconds * * @param longSecs Time in seconds. - * @return String */ public static String convertTimeSecondsToHMS(long longSecs) { diff --git a/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorHelper.java b/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorHelper.java index f5830c7..17f9c47 100644 --- a/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorHelper.java +++ b/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorHelper.java @@ -35,10 +35,6 @@ public class LocatorHelper { * This methods add the given locator to allLocatorInfoMap. It also invokes a locatorlistener to * inform other locators in allLocatorInfoMap about this newly added locator. * - * @param distributedSystemId - * @param locator - * @param locatorListener - * @param sourceLocator */ public static boolean addLocator(int distributedSystemId, DistributionLocatorId locator, LocatorMembershipListener locatorListener, DistributionLocatorId sourceLocator) { @@ -68,9 +64,6 @@ public class LocatorHelper { * This methods decides whether the given locator is server locator, if so then add this locator * in allServerLocatorsInfo map. * - * @param distributedSystemId - * @param locatorListener - * @param locator */ private static void addServerLocator(Integer distributedSystemId, LocatorMembershipListener locatorListener, DistributionLocatorId locator) { @@ -90,8 +83,6 @@ public class LocatorHelper { /** * This method adds the map of locatorsinfo sent by other locator to this locator's allLocatorInfo * - * @param locators - * @param locatorListener */ public static boolean addExchangedLocators(Map<Integer, Set<DistributionLocatorId>> locators, LocatorMembershipListener locatorListener) { diff --git a/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java b/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java index e227d6e..29e4bd3 100644 --- a/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java +++ b/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java @@ -69,7 +69,6 @@ public class LocatorMembershipListenerImpl implements LocatorMembershipListener * When the new locator is added to remote locator metadata, inform all other locators in remote * locator metadata about the new locator so that they can update their remote locator metadata. * - * @param locator */ public void locatorJoined(final int distributedSystemId, final DistributionLocatorId locator, @@ -155,7 +154,6 @@ public class LocatorMembershipListenerImpl implements LocatorMembershipListener * invoked to inform about the this newly added locator to all other locators available in remote * locator metadata. As a response, remote locator metadata is sent. * - * @param request */ private synchronized Object updateAllLocatorInfo(RemoteLocatorJoinRequest request) { int distributedSystemId = request.getDistributedSystemId(); diff --git a/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/RemoteLocatorPingRequest.java b/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/RemoteLocatorPingRequest.java index 904af94..ecc8edf 100644 --- a/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/RemoteLocatorPingRequest.java +++ b/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/RemoteLocatorPingRequest.java @@ -21,11 +21,6 @@ import java.io.IOException; import org.apache.geode.internal.DataSerializableFixedID; import org.apache.geode.internal.Version; -/** - * - * - */ - public class RemoteLocatorPingRequest implements DataSerializableFixedID { public RemoteLocatorPingRequest() { diff --git a/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/RemoteLocatorPingResponse.java b/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/RemoteLocatorPingResponse.java index cd04142..6b100a8 100644 --- a/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/RemoteLocatorPingResponse.java +++ b/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/RemoteLocatorPingResponse.java @@ -21,9 +21,6 @@ import java.io.IOException; import org.apache.geode.internal.DataSerializableFixedID; import org.apache.geode.internal.Version; -/** - * - */ public class RemoteLocatorPingResponse implements DataSerializableFixedID { diff --git a/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/RemoteLocatorRequest.java b/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/RemoteLocatorRequest.java index 75209da..3041d66 100644 --- a/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/RemoteLocatorRequest.java +++ b/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/RemoteLocatorRequest.java @@ -21,10 +21,6 @@ import java.io.IOException; import org.apache.geode.internal.DataSerializableFixedID; import org.apache.geode.internal.Version; -/** - * - * - */ public class RemoteLocatorRequest implements DataSerializableFixedID { private int distributedSystemId; diff --git a/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/RemoteLocatorResponse.java b/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/RemoteLocatorResponse.java index a57e69d..9d15273 100644 --- a/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/RemoteLocatorResponse.java +++ b/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/RemoteLocatorResponse.java @@ -23,10 +23,6 @@ import org.apache.geode.DataSerializer; import org.apache.geode.internal.DataSerializableFixedID; import org.apache.geode.internal.Version; -/** - * - * - */ public class RemoteLocatorResponse implements DataSerializableFixedID { private Set<String> locators; diff --git a/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/WanLocatorDiscovererImpl.java b/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/WanLocatorDiscovererImpl.java index 768428e..dab6e8c 100644 --- a/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/WanLocatorDiscovererImpl.java +++ b/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/WanLocatorDiscovererImpl.java @@ -73,8 +73,6 @@ public class WanLocatorDiscovererImpl implements WanLocatorDiscoverer { /** * For WAN 70 Exchange the locator information within the distributed system * - * @param config - * @param hostnameForClients */ private void exchangeLocalLocators(int port, DistributionConfigImpl config, LocatorMembershipListener locatorListener, final String hostnameForClients) { @@ -105,8 +103,6 @@ public class WanLocatorDiscovererImpl implements WanLocatorDiscoverer { /** * For WAN 70 Exchange the locator information across the distributed systems (sites) * - * @param config - * @param hostnameForClients */ private void exchangeRemoteLocators(int port, DistributionConfigImpl config, LocatorMembershipListener locatorListener, final String hostnameForClients) { diff --git a/geode-wan/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderEventRemoteDispatcher.java b/geode-wan/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderEventRemoteDispatcher.java index 8357669..8ae7fb0 100644 --- a/geode-wan/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderEventRemoteDispatcher.java +++ b/geode-wan/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderEventRemoteDispatcher.java @@ -304,7 +304,6 @@ public class GatewaySenderEventRemoteDispatcher implements GatewaySenderEventDis * * @return the <code>Connection</code> * - * @throws GatewaySenderException */ public Connection getConnection(boolean startAckReaderThread) throws GatewaySenderException { if (this.processor.isStopped()) { @@ -370,7 +369,6 @@ public class GatewaySenderEventRemoteDispatcher implements GatewaySenderEventDis /** * Initializes the <code>Connection</code>. * - * @throws GatewaySenderException */ private void initializeConnection() throws GatewaySenderException, GemFireSecurityException { if (ackReaderThread != null) { diff --git a/geode-wan/src/main/java/org/apache/geode/internal/cache/wan/parallel/RemoteParallelGatewaySenderEventProcessor.java b/geode-wan/src/main/java/org/apache/geode/internal/cache/wan/parallel/RemoteParallelGatewaySenderEventProcessor.java index 4cad04f..e431ce3 100644 --- a/geode-wan/src/main/java/org/apache/geode/internal/cache/wan/parallel/RemoteParallelGatewaySenderEventProcessor.java +++ b/geode-wan/src/main/java/org/apache/geode/internal/cache/wan/parallel/RemoteParallelGatewaySenderEventProcessor.java @@ -77,7 +77,6 @@ public class RemoteParallelGatewaySenderEventProcessor extends ParallelGatewaySe /** * Returns if corresponding receiver WAN site of this GatewaySender has GemfireVersion > 7.0.1 * - * @param disp * @return true if remote site Gemfire Version is >= 7.0.1 */ private boolean shouldSendVersionEvents(GatewaySenderEventDispatcher disp) -- To stop receiving notification emails like this one, please contact prhomb...@apache.org.