This is an automated email from the ASF dual-hosted git repository.
sai_boorlagadda pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git
The following commit(s) were added to refs/heads/develop by this push:
new 530c66d GEODE-5245: Unit tests fail on windows due to assertions on
paths (#1981)
530c66d is described below
commit 530c66d85ff7dd250c4e0c4cf81190ae7b460eb2
Author: Sai Boorlagadda <[email protected]>
AuthorDate: Wed May 23 09:34:42 2018 -0700
GEODE-5245: Unit tests fail on windows due to assertions on paths (#1981)
---
.../test/java/org/apache/geode/test/junit/rules/GfshRuleTest.java | 6 ++++--
.../management/internal/cli/commands/ExportConfigCommandTest.java | 2 +-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git
a/geode-assembly/src/test/java/org/apache/geode/test/junit/rules/GfshRuleTest.java
b/geode-assembly/src/test/java/org/apache/geode/test/junit/rules/GfshRuleTest.java
index 8b17e2e..d380c6a 100644
---
a/geode-assembly/src/test/java/org/apache/geode/test/junit/rules/GfshRuleTest.java
+++
b/geode-assembly/src/test/java/org/apache/geode/test/junit/rules/GfshRuleTest.java
@@ -17,6 +17,8 @@ package org.apache.geode.test.junit.rules;
import static org.assertj.core.api.Assertions.assertThat;
+import java.nio.file.Paths;
+
import org.junit.Rule;
import org.junit.Test;
import org.junit.experimental.categories.Category;
@@ -38,13 +40,13 @@ public class GfshRuleTest {
@Test
public void checkGfshDefault() {
assertThat(gfshDefault.getGfshPath().toString())
- .contains("geode-assembly/build/install/apache-geode/bin/gfsh");
+
.contains(Paths.get("geode-assembly/build/install/apache-geode/bin/gfsh").toString());
}
@Test
public void checkGfsh130() {
assertThat(gfsh130.getGfshPath().toString())
- .contains("geode-old-versions/build/apache-geode-1.3.0/bin/gfsh");
+
.contains(Paths.get("geode-old-versions/build/apache-geode-1.3.0/bin/gfsh").toString());
}
}
diff --git
a/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportConfigCommandTest.java
b/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportConfigCommandTest.java
index abc21c3..cae1902 100644
---
a/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportConfigCommandTest.java
+++
b/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportConfigCommandTest.java
@@ -47,6 +47,6 @@ public class ExportConfigCommandTest {
public void incorrectDirectoryShowsError() throws Exception {
String wrongDir = temp.newFile().getAbsolutePath();
gfsh.executeAndAssertThat(command, "export config --dir=" +
wrongDir).statusIsError()
- .containsOutput(wrongDir + " is not a directory");
+ .containsOutput(wrongDir.replace("\\", "\\\\") + " is not a
directory");
}
}
--
To stop receiving notification emails like this one, please contact
[email protected].
