[geode] branch develop updated: GEODE-5341: Improve debug logging in BackupTask

[klund]

This is an automated email from the ASF dual-hosted git repository.

klund pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/develop by this push:
     new 377529c  GEODE-5341: Improve debug logging in BackupTask
377529c is described below

commit 377529c0c1a5b9cd162e22d73154b388755ee8f5
Author: Kirk Lund <kl...@apache.org>
AuthorDate: Thu Jun 21 13:23:00 2018 -0700

    GEODE-5341: Improve debug logging in BackupTask
---
 .../apache/geode/internal/cache/backup/BackupTask.java    | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git 
a/geode-core/src/main/java/org/apache/geode/internal/cache/backup/BackupTask.java
 
b/geode-core/src/main/java/org/apache/geode/internal/cache/backup/BackupTask.java
index 781e76a..651dc02 100644
--- 
a/geode-core/src/main/java/org/apache/geode/internal/cache/backup/BackupTask.java
+++ 
b/geode-core/src/main/java/org/apache/geode/internal/cache/backup/BackupTask.java
@@ -87,6 +87,9 @@ public class BackupTask {
       DiskStoreImpl storeImpl = (DiskStoreImpl) store;
 
       storeImpl.lockStoreBeforeBackup();
+      if (logger.isDebugEnabled()) {
+        logger.debug("Acquired lock for backup on disk store {}", 
store.getName());
+      }
       if (storeImpl.hasPersistedData()) {
         diskStoresWithData.add(storeImpl.getPersistentID());
         storeImpl.getStats().startBackup();
@@ -148,6 +151,9 @@ public class BackupTask {
         }
       } finally {
         diskStore.releaseBackupLock();
+        if (logger.isDebugEnabled()) {
+          logger.debug("Released lock for backup on disk store {}", 
store.getName());
+        }
       }
     }
     return backupByDiskStore;
@@ -246,12 +252,17 @@ public class BackupTask {
         // This ensures that all writing to disk is blocked while we are
         // creating the snapshot
         synchronized (childLock) {
+          if (logger.isDebugEnabled()) {
+            logger.debug("Synchronized on lock for oplog {} on disk store {}",
+                childOplog.getOplogId(), diskStore.getName());
+          }
+
           if (diskStore.getPersistentOplogSet().getChild() != childOplog) {
             continue;
           }
 
           if (logger.isDebugEnabled()) {
-            logger.debug("snapshotting oplogs for disk store {}", 
diskStore.getName());
+            logger.debug("Creating snapshot of oplogs for disk store {}", 
diskStore.getName());
           }
 
           
restoreScript.addExistenceTest(diskStore.getDiskInitFile().getIFFile());
@@ -265,7 +276,7 @@ public class BackupTask {
           diskStore.getPersistentOplogSet().forceRoll(null);
 
           if (logger.isDebugEnabled()) {
-            logger.debug("done backing up disk store {}", diskStore.getName());
+            logger.debug("Finished backup of disk store {}", 
diskStore.getName());
           }
           break;
         }