This is an automated email from the ASF dual-hosted git repository.

udo pushed a commit to branch feature/Micrometer
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/feature/Micrometer by this 
push:
     new 19b939b  More clean up. Hopefully cleaner implementation
19b939b is described below

commit 19b939b025c5c9dc84151698a8097886d4b214b7
Author: Udo Kohlmeyer <[email protected]>
AuthorDate: Wed Sep 12 15:01:39 2018 -0700

    More clean up. Hopefully cleaner implementation
---
 .../execute/FunctionServiceStatsDUnitTest.java     | 22 +++++++++++-----------
 .../distributed/internal/InternalLocator.java      |  3 ++-
 .../distributed/internal/LocatorStatsImpl.java     | 16 ++++++++--------
 .../geode/internal/cache/CachePerfStatsImpl.java   | 11 +++++++----
 .../geode/internal/cache/DiskStoreStatsImpl.java   | 14 +++++++++++---
 ...ava~d2263ebc2... Create HasDiskRegion interface | 22 ----------------------
 .../cache/tier/sockets/CacheServerStatsImpl.java   |  1 -
 .../statistics/InternalDistributedSystemStats.java | 13 ++++++-------
 .../internal/beans/MemberMBeanBridge.java          |  1 -
 .../common/distributed/internal/LocatorStats.java  |  1 -
 .../common/statistics/factory/StatsFactory.java    | 16 ++++++++--------
 11 files changed, 53 insertions(+), 67 deletions(-)

diff --git 
a/geode-core/src/distributedTest/java/org/apache/geode/internal/cache/execute/FunctionServiceStatsDUnitTest.java
 
b/geode-core/src/distributedTest/java/org/apache/geode/internal/cache/execute/FunctionServiceStatsDUnitTest.java
index 8696716..a88d434 100644
--- 
a/geode-core/src/distributedTest/java/org/apache/geode/internal/cache/execute/FunctionServiceStatsDUnitTest.java
+++ 
b/geode-core/src/distributedTest/java/org/apache/geode/internal/cache/execute/FunctionServiceStatsDUnitTest.java
@@ -169,7 +169,7 @@ public class FunctionServiceStatsDUnitTest extends 
PRClientServerTestBase {
    * functions this is true, however, at this point the function stats may not 
have been updated yet
    * thus any code which checks stats after calling getResult() may get wrong 
data.
    */
-  private void waitNoFunctionsRunning(FunctionServiceStatsImpl stats) {
+  private void waitNoFunctionsRunning(FunctionServiceStats stats) {
     int count = 100;
     while (stats.getFunctionExecutionsRunning() > 0 && count > 0) {
       count--;
@@ -271,7 +271,7 @@ public class FunctionServiceStatsDUnitTest extends 
PRClientServerTestBase {
         // checks for the aggregate stats
         InternalDistributedSystem internalDistributedSystem =
             (InternalDistributedSystem) cache.getDistributedSystem();
-        FunctionServiceStatsImpl functionServiceStats =
+        FunctionServiceStats functionServiceStats =
             
internalDistributedSystem.getInternalDistributedSystemStats().getFunctionServiceStats();
         waitNoFunctionsRunning(functionServiceStats);
 
@@ -310,7 +310,7 @@ public class FunctionServiceStatsDUnitTest extends 
PRClientServerTestBase {
         // checks for the aggregate stats
         InternalDistributedSystem internalDistributedSystem =
             (InternalDistributedSystem) cache.getDistributedSystem();
-        FunctionServiceStatsImpl functionServiceStats =
+        FunctionServiceStats functionServiceStats =
             
internalDistributedSystem.getInternalDistributedSystemStats().getFunctionServiceStats();
         waitNoFunctionsRunning(functionServiceStats);
 
@@ -517,7 +517,7 @@ public class FunctionServiceStatsDUnitTest extends 
PRClientServerTestBase {
         // checks for the aggregate stats
         InternalDistributedSystem internalDistributedSystem =
             (InternalDistributedSystem) cache.getDistributedSystem();
-        FunctionServiceStatsImpl functionServiceStats =
+        FunctionServiceStats functionServiceStats =
             
internalDistributedSystem.getInternalDistributedSystemStats().getFunctionServiceStats();
         waitNoFunctionsRunning(functionServiceStats);
 
@@ -612,7 +612,7 @@ public class FunctionServiceStatsDUnitTest extends 
PRClientServerTestBase {
         // checks for the aggregate stats
         InternalDistributedSystem internalDistributedSystem =
             (InternalDistributedSystem) cache.getDistributedSystem();
-        FunctionServiceStatsImpl functionServiceStats =
+        FunctionServiceStats functionServiceStats =
             
internalDistributedSystem.getInternalDistributedSystemStats().getFunctionServiceStats();
         waitNoFunctionsRunning(functionServiceStats);
 
@@ -649,7 +649,7 @@ public class FunctionServiceStatsDUnitTest extends 
PRClientServerTestBase {
         // checks for the aggregate stats
         InternalDistributedSystem internalDistributedSystem =
             (InternalDistributedSystem) cache.getDistributedSystem();
-        FunctionServiceStatsImpl functionServiceStats =
+        FunctionServiceStats functionServiceStats =
             
internalDistributedSystem.getInternalDistributedSystemStats().getFunctionServiceStats();
         waitNoFunctionsRunning(functionServiceStats);
 
@@ -827,7 +827,7 @@ public class FunctionServiceStatsDUnitTest extends 
PRClientServerTestBase {
       public Object call() throws Exception {
         InternalDistributedSystem internalDistributedSystem =
             ((InternalDistributedSystem) getCache().getDistributedSystem());
-        FunctionServiceStatsImpl functionServiceStats =
+        FunctionServiceStats functionServiceStats =
             
internalDistributedSystem.getInternalDistributedSystemStats().getFunctionServiceStats();
         waitNoFunctionsRunning(functionServiceStats);
 
@@ -863,7 +863,7 @@ public class FunctionServiceStatsDUnitTest extends 
PRClientServerTestBase {
             InternalDistributedSystem internalDistributedSystem =
                 ((InternalDistributedSystem) 
getCache().getDistributedSystem());
             // 3 Function Executions took place
-            FunctionServiceStatsImpl functionServiceStats =
+            FunctionServiceStats functionServiceStats =
                 internalDistributedSystem.getInternalDistributedSystemStats()
                     .getFunctionServiceStats();
             waitNoFunctionsRunning(functionServiceStats);
@@ -1122,7 +1122,7 @@ public class FunctionServiceStatsDUnitTest extends 
PRClientServerTestBase {
 
     member1.invoke(new 
SerializableCallable("checkFunctionExecutionStatsForMember1") {
       public Object call() throws Exception {
-        FunctionServiceStatsImpl functionServiceStats =
+        FunctionServiceStats functionServiceStats =
             
distributedSystem.getInternalDistributedSystemStats().getFunctionServiceStats();
         waitNoFunctionsRunning(functionServiceStats);
 
@@ -1146,7 +1146,7 @@ public class FunctionServiceStatsDUnitTest extends 
PRClientServerTestBase {
     SerializableCallable checkFunctionExecutionStatsForOtherMember =
         new SerializableCallable("checkFunctionExecutionStatsForOtherMember") {
           public Object call() throws Exception {
-            FunctionServiceStatsImpl functionServiceStats =
+            FunctionServiceStats functionServiceStats =
                 
distributedSystem.getInternalDistributedSystemStats().getFunctionServiceStats();
             waitNoFunctionsRunning(functionServiceStats);
 
@@ -1297,7 +1297,7 @@ public class FunctionServiceStatsDUnitTest extends 
PRClientServerTestBase {
 
             noOfExecutionCalls_Aggregate++;
             noOfExecutionExceptions_Aggregate++;
-            FunctionServiceStatsImpl functionServiceStats =
+            FunctionServiceStats functionServiceStats =
                 ((InternalDistributedSystem) getCache().getDistributedSystem())
                     .getInternalDistributedSystemStats()
                     .getFunctionServiceStats();
diff --git 
a/geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java
 
b/geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java
index 2fdd781..6918413 100644
--- 
a/geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java
+++ 
b/geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java
@@ -1275,7 +1275,8 @@ public class InternalLocator extends Locator implements 
ConnectListener {
   @Override
   public void onConnect(InternalDistributedSystem sys) {
     try {
-      
this.stats.hookupStats(SocketCreator.getLocalHost().getCanonicalHostName() + 
'-' + this.server.getBindAddress());
+      this.stats.hookupStats(
+          SocketCreator.getLocalHost().getCanonicalHostName() + '-' + 
this.server.getBindAddress());
     } catch (UnknownHostException e) {
       logger.warn(e);
     }
diff --git 
a/geode-core/src/main/java/org/apache/geode/distributed/internal/LocatorStatsImpl.java
 
b/geode-core/src/main/java/org/apache/geode/distributed/internal/LocatorStatsImpl.java
index 0407787..8cd8c46 100755
--- 
a/geode-core/src/main/java/org/apache/geode/distributed/internal/LocatorStatsImpl.java
+++ 
b/geode-core/src/main/java/org/apache/geode/distributed/internal/LocatorStatsImpl.java
@@ -110,14 +110,14 @@ public class LocatorStatsImpl implements LocatorStats, 
GFSStatsImplementer {
    */
   @Override
   public void hookupStats(String name) {
-//    if (this._stats == null) {
-//      this._stats = f.createAtomicStatistics(type, name);
-//      setLocatorCount(known_locators.get());
-//      setServerCount(endpoints_known.get());
-//      setLocatorRequests(requests_to_locator.get());
-//      setLocatorResponses(responses_from_locator.get());
-//      setServerLoadUpdates(serverLoadUpdates.get());
-//    }
+    // if (this._stats == null) {
+    // this._stats = f.createAtomicStatistics(type, name);
+    // setLocatorCount(known_locators.get());
+    // setServerCount(endpoints_known.get());
+    // setLocatorRequests(requests_to_locator.get());
+    // setLocatorResponses(responses_from_locator.get());
+    // setServerLoadUpdates(serverLoadUpdates.get());
+    // }
   }
 
 
diff --git 
a/geode-core/src/main/java/org/apache/geode/internal/cache/CachePerfStatsImpl.java
 
b/geode-core/src/main/java/org/apache/geode/internal/cache/CachePerfStatsImpl.java
index b105a2d..f985ead 100644
--- 
a/geode-core/src/main/java/org/apache/geode/internal/cache/CachePerfStatsImpl.java
+++ 
b/geode-core/src/main/java/org/apache/geode/internal/cache/CachePerfStatsImpl.java
@@ -1110,7 +1110,7 @@ public class CachePerfStatsImpl implements 
CachePerfStats, GFSStatsImplementer {
   }
 
   private void calculateEndTimeMetrics(long start, int deltaTimeId,
-                                       int inProgressId, int completedId) {
+      int inProgressId, int completedId) {
     if (enableClockStats) {
       stats.incLong(deltaTimeId, NanoTimer.getTime() - start);
     }
@@ -1132,7 +1132,8 @@ public class CachePerfStatsImpl implements 
CachePerfStats, GFSStatsImplementer {
    */
   @Override
   public void endCacheWriterCall(long start) {
-    
calculateEndTimeMetrics(start,cacheWriterCallTimeId,cacheWriterCallsInProgressId,cacheWriterCallsCompletedId);
+    calculateEndTimeMetrics(start, cacheWriterCallTimeId, 
cacheWriterCallsInProgressId,
+        cacheWriterCallsCompletedId);
   }
 
   /**
@@ -1151,7 +1152,8 @@ public class CachePerfStatsImpl implements 
CachePerfStats, GFSStatsImplementer {
    */
   @Override
   public void endCacheListenerCall(long start) {
-    
calculateEndTimeMetrics(start,cacheListenerCallTimeId,cacheListenerCallsInProgressId,cacheListenerCallsCompletedId);
+    calculateEndTimeMetrics(start, cacheListenerCallTimeId, 
cacheListenerCallsInProgressId,
+        cacheListenerCallsCompletedId);
   }
 
   /**
@@ -1168,7 +1170,8 @@ public class CachePerfStatsImpl implements 
CachePerfStats, GFSStatsImplementer {
    */
   @Override
   public void endGetInitialImage(long start) {
-    
calculateEndTimeMetrics(start,getInitialImageTimeId,getInitialImagesInProgressId,getInitialImagesCompletedId);
+    calculateEndTimeMetrics(start, getInitialImageTimeId, 
getInitialImagesInProgressId,
+        getInitialImagesCompletedId);
   }
 
   /**
diff --git 
a/geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreStatsImpl.java
 
b/geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreStatsImpl.java
index 53b5776..dc65e8c 100644
--- 
a/geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreStatsImpl.java
+++ 
b/geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreStatsImpl.java
@@ -23,6 +23,7 @@ import 
org.apache.geode.stats.common.statistics.StatisticsType;
 
 /**
  * GemFire statistics about a {@link DiskStoreImpl}.
+ *
  * @since GemFire prPersistSprint2
  */
 public class DiskStoreStatsImpl implements DiskStoreStats, GFSStatsImplementer 
{
@@ -93,8 +94,7 @@ public class DiskStoreStatsImpl implements DiskStoreStats, 
GFSStatsImplementer {
     String statName = "DiskStoreStatistics";
     String statDescription = "Statistics about a Region's use of the disk";
 
-    final String
-        writesDesc =
+    final String writesDesc =
         "The total number of region entries that have been written to disk. A 
write is done every time an entry is created on disk or every time its value is 
modified on disk.";
     final String writeTimeDesc = "The total amount of time spent writing to 
disk";
     final String bytesWrittenDesc = "The total number of bytes that have been 
written to disk";
@@ -124,7 +124,7 @@ public class DiskStoreStatsImpl implements DiskStoreStats, 
GFSStatsImplementer {
         "The number of backups of this disk store that have been taking while 
this VM was alive";
 
     type = factory.createType(statName, statDescription,
-        new StatisticDescriptor[]{factory.createLongCounter("writes", 
writesDesc, "ops"),
+        new StatisticDescriptor[] {factory.createLongCounter("writes", 
writesDesc, "ops"),
             factory.createLongCounter("writeTime", writeTimeDesc, 
"nanoseconds"),
             factory.createLongCounter("writtenBytes", bytesWrittenDesc, 
"bytes"),
             factory.createLongCounter("flushes", flushesDesc, "ops"),
@@ -345,6 +345,7 @@ public class DiskStoreStatsImpl implements DiskStoreStats, 
GFSStatsImplementer {
 
   /**
    * Invoked before data is written to disk.
+   *
    * @return The timestamp that marks the start of the operation
    * @see DiskRegion#put
    */
@@ -367,6 +368,7 @@ public class DiskStoreStatsImpl implements DiskStoreStats, 
GFSStatsImplementer {
 
   /**
    * Invoked after data has been written to disk
+   *
    * @param start The time at which the write operation started
    */
   @Override
@@ -393,6 +395,7 @@ public class DiskStoreStatsImpl implements DiskStoreStats, 
GFSStatsImplementer {
 
   /**
    * Invoked before data is read from disk.
+   *
    * @return The timestamp that marks the start of the operation
    * @see DiskRegion#get
    */
@@ -403,6 +406,7 @@ public class DiskStoreStatsImpl implements DiskStoreStats, 
GFSStatsImplementer {
 
   /**
    * Invoked after data has been read from disk
+   *
    * @param start The time at which the read operation started
    * @param bytesRead The number of bytes that were read
    */
@@ -417,6 +421,7 @@ public class DiskStoreStatsImpl implements DiskStoreStats, 
GFSStatsImplementer {
 
   /**
    * Invoked before data is recovered from disk.
+   *
    * @return The timestamp that marks the start of the operation
    */
   @Override
@@ -438,6 +443,7 @@ public class DiskStoreStatsImpl implements DiskStoreStats, 
GFSStatsImplementer {
 
   /**
    * Invoked after data has been recovered from disk
+   *
    * @param start The time at which the recovery operation started
    * @param bytesRead The number of bytes that were recovered
    */
@@ -492,6 +498,7 @@ public class DiskStoreStatsImpl implements DiskStoreStats, 
GFSStatsImplementer {
 
   /**
    * Invoked before data is removed from disk.
+   *
    * @return The timestamp that marks the start of the operation
    * @see DiskRegion#remove
    */
@@ -502,6 +509,7 @@ public class DiskStoreStatsImpl implements DiskStoreStats, 
GFSStatsImplementer {
 
   /**
    * Invoked after data has been removed from disk
+   *
    * @param start The time at which the read operation started
    */
   @Override
diff --git 
a/geode-core/src/main/java/org/apache/geode/internal/cache/HasDiskRegion.java~d2263ebc2...
 Create HasDiskRegion interface 
b/geode-core/src/main/java/org/apache/geode/internal/cache/HasDiskRegion.java~d2263ebc2...
 Create HasDiskRegion interface
deleted file mode 100644
index dbf55db..0000000
--- 
a/geode-core/src/main/java/org/apache/geode/internal/cache/HasDiskRegion.java~d2263ebc2...
 Create HasDiskRegion interface   
+++ /dev/null
@@ -1,22 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.geode.internal.cache;
-
-public interface HasDiskRegion {
-
-  DiskRegion getDiskRegion();
-}
diff --git 
a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheServerStatsImpl.java
 
b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheServerStatsImpl.java
index 735901f..a45e2b7 100644
--- 
a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheServerStatsImpl.java
+++ 
b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheServerStatsImpl.java
@@ -14,7 +14,6 @@
  */
 package org.apache.geode.internal.cache.tier.sockets;
 
-import org.apache.geode.distributed.internal.InternalDistributedSystem;
 import org.apache.geode.stats.common.distributed.internal.PoolStatHelper;
 import 
org.apache.geode.stats.common.internal.cache.tier.sockets.CacheServerStats;
 import org.apache.geode.stats.common.statistics.GFSStatsImplementer;
diff --git 
a/geode-core/src/main/java/org/apache/geode/internal/statistics/InternalDistributedSystemStats.java
 
b/geode-core/src/main/java/org/apache/geode/internal/statistics/InternalDistributedSystemStats.java
index 476a84a..2108590 100644
--- 
a/geode-core/src/main/java/org/apache/geode/internal/statistics/InternalDistributedSystemStats.java
+++ 
b/geode-core/src/main/java/org/apache/geode/internal/statistics/InternalDistributedSystemStats.java
@@ -47,8 +47,7 @@ public class InternalDistributedSystemStats {
 
   private StatisticsFactory statisticsFactory = 
StatsFactory.getStatisticsFactory();
 
-  private InternalDistributedSystemStats() {
-  }
+  private InternalDistributedSystemStats() {}
 
   public static InternalDistributedSystemStats createInstance(boolean 
statsDisabled) {
 
@@ -59,9 +58,9 @@ public class InternalDistributedSystemStats {
   }
 
   private static void startGemFireStatSampler(boolean statsDisabled,
-                                              DistributionConfig 
distributionConfig,
-                                              InternalDistributedSystem 
distributedSystem,
-                                              InternalDistributedSystemStats 
internalDistributedSystemStats) {
+      DistributionConfig distributionConfig,
+      InternalDistributedSystem distributedSystem,
+      InternalDistributedSystemStats internalDistributedSystemStats) {
     if (!statsDisabled && StatsFactory.isLegacyGeodeStats()) {
       internalDistributedSystemStats.sampler =
           new GemFireStatSampler(distributedSystem.getId(), distributionConfig,
@@ -73,8 +72,8 @@ public class InternalDistributedSystemStats {
   }
 
   public void startGemFireStatSampler(boolean statsDisabled,
-                                              DistributionConfig 
distributionConfig,
-                                              InternalDistributedSystem 
distributedSystem) {
+      DistributionConfig distributionConfig,
+      InternalDistributedSystem distributedSystem) {
     startGemFireStatSampler(statsDisabled, distributionConfig, 
distributedSystem, this);
   }
 
diff --git 
a/geode-core/src/main/java/org/apache/geode/management/internal/beans/MemberMBeanBridge.java
 
b/geode-core/src/main/java/org/apache/geode/management/internal/beans/MemberMBeanBridge.java
index d55aadc..3ac61aa 100644
--- 
a/geode-core/src/main/java/org/apache/geode/management/internal/beans/MemberMBeanBridge.java
+++ 
b/geode-core/src/main/java/org/apache/geode/management/internal/beans/MemberMBeanBridge.java
@@ -64,7 +64,6 @@ import org.apache.geode.internal.cache.InternalRegion;
 import org.apache.geode.internal.cache.LocalRegion;
 import org.apache.geode.internal.cache.PartitionedRegion;
 import org.apache.geode.internal.cache.execute.FunctionServiceStats;
-import org.apache.geode.internal.cache.execute.FunctionServiceStatsImpl;
 import org.apache.geode.internal.i18n.LocalizedStrings;
 import org.apache.geode.internal.logging.LogService;
 import org.apache.geode.internal.logging.log4j.LocalizedMessage;
diff --git 
a/geode-stats-common/src/main/java/org/apache/geode/stats/common/distributed/internal/LocatorStats.java
 
b/geode-stats-common/src/main/java/org/apache/geode/stats/common/distributed/internal/LocatorStats.java
index d76bbc4..9ebb648 100644
--- 
a/geode-stats-common/src/main/java/org/apache/geode/stats/common/distributed/internal/LocatorStats.java
+++ 
b/geode-stats-common/src/main/java/org/apache/geode/stats/common/distributed/internal/LocatorStats.java
@@ -15,7 +15,6 @@
 package org.apache.geode.stats.common.distributed.internal;
 
 import org.apache.geode.stats.common.Stats;
-import org.apache.geode.stats.common.statistics.StatisticsFactory;
 
 public interface LocatorStats extends Stats {
 
diff --git 
a/geode-stats-common/src/main/java/org/apache/geode/stats/common/statistics/factory/StatsFactory.java
 
b/geode-stats-common/src/main/java/org/apache/geode/stats/common/statistics/factory/StatsFactory.java
index 0bb6c61..85b4900 100644
--- 
a/geode-stats-common/src/main/java/org/apache/geode/stats/common/statistics/factory/StatsFactory.java
+++ 
b/geode-stats-common/src/main/java/org/apache/geode/stats/common/statistics/factory/StatsFactory.java
@@ -51,7 +51,7 @@ public class StatsFactory {
   private final StatisticsFactory statisticsFactory;
 
   private StatsFactory(Class<? extends StatsImplementer> 
selectedStatsImplementor,
-                       StatisticsFactory statisticsFactory) {
+      StatisticsFactory statisticsFactory) {
     List<ClassLoader> classLoadersList = new LinkedList<>();
     classLoadersList.add(ClasspathHelper.contextClassLoader());
     classLoadersList.add(ClasspathHelper.staticClassLoader());
@@ -72,7 +72,7 @@ public class StatsFactory {
     try {
       return isExperimentalEnabled
           ? (Class<? extends StatsImplementer>) Class
-          
.forName("org.apache.geode.statistics.micrometer.MicrometerStatsImplementer")
+              
.forName("org.apache.geode.statistics.micrometer.MicrometerStatsImplementer")
           : GFSStatsImplementer.class;
     } catch (ClassNotFoundException e) {
       e.printStackTrace();
@@ -96,7 +96,7 @@ public class StatsFactory {
   }
 
   public static <V extends StatsImplementer> V createStatsImpl(Class<?> 
interfaceClazz,
-                                                               String 
identifier) {
+      String identifier) {
     return (V) resolveInstanceFromClass(interfaceClazz, identifier);
   }
 
@@ -118,13 +118,13 @@ public class StatsFactory {
   }
 
   private static StatsImplementer 
resolveConnectionStatInstanceFromClass(String name,
-                                                                         
PoolStats poolStats) {
+      PoolStats poolStats) {
     return singletonStatsFactory.createConnectionStatInstanceFromClass(name, 
poolStats);
   }
 
   public static RegionPerfStats createRegionPerfStatsImplFromClass(Class<?> 
interfaceClazz,
-                                                                   
CachePerfStats cachePerfStats,
-                                                                   String 
regionName) {
+      CachePerfStats cachePerfStats,
+      String regionName) {
     try {
       Class<? extends StatsImplementer> resolvedLocatorClassImpl =
           singletonStatsFactory.resolvedStatsImplForClass.get(interfaceClazz);
@@ -165,7 +165,7 @@ public class StatsFactory {
     reflections.getSubTypesOf(CachePerfStats.class).stream()
         .filter(clazz -> selectedStatsImplementor.isAssignableFrom(clazz)
             && !RegionPerfStats.class.isAssignableFrom(clazz) && 
!clazz.getName()
-            .contains("DummyCachePerfStats"))
+                .contains("DummyCachePerfStats"))
         .forEach(aClass -> resolvedStatsImplForClass
             .put(CachePerfStats.class, (Class<? extends StatsImplementer>) 
aClass));
 
@@ -177,7 +177,7 @@ public class StatsFactory {
   }
 
   private StatsImplementer createConnectionStatInstanceFromClass(String 
locatorName,
-                                                                 PoolStats 
poolStats) {
+      PoolStats poolStats) {
     try {
       Class<? extends StatsImplementer> resolvedLocatorClassImpl =
           resolveImplementationForClass(ConnectionStats.class);

Reply via email to