[geode] branch develop updated: GEODE-5788: On Windows, Ignore tests that bounces VMs (#2524)

[sai_boorlagadda]

This is an automated email from the ASF dual-hosted git repository.

sai_boorlagadda pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/develop by this push:
     new ef95dd5  GEODE-5788: On Windows, Ignore tests that bounces VMs (#2524)
ef95dd5 is described below

commit ef95dd509991529ac9c7af2005bd31a13f6f281c
Author: Sai Boorlagadda <sai.boorlaga...@gmail.com>
AuthorDate: Thu Sep 27 21:47:25 2018 -0700

    GEODE-5788: On Windows, Ignore tests that bounces VMs (#2524)
    
      bounce on windows is not graceful and causes
      distributed system to start suspect processing.
      Ignoring these tests until GEODE-5787 is fixed.
---
 .../internal/cli/commands/DeployWithGroupsDUnitTest.java         | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git 
a/geode-core/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/DeployWithGroupsDUnitTest.java
 
b/geode-core/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/DeployWithGroupsDUnitTest.java
index 14922a7..d7f9223 100644
--- 
a/geode-core/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/DeployWithGroupsDUnitTest.java
+++ 
b/geode-core/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/DeployWithGroupsDUnitTest.java
@@ -15,8 +15,10 @@
 package org.apache.geode.management.internal.cli.commands;
 
 import static org.apache.geode.distributed.ConfigurationProperties.GROUPS;
+import static org.apache.geode.internal.lang.SystemUtils.isWindows;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
+import static org.junit.Assume.assumeFalse;
 
 import java.io.File;
 import java.io.Serializable;
@@ -198,7 +200,9 @@ public class DeployWithGroupsDUnitTest implements 
Serializable {
   }
 
   @Test
-  public void deployJarToAllServersWithRestart() throws Exception {
+  public void deployJarToAllServersWithRestart() {
+    // TODO: Ignore on windows until GEODE-5787
+    assumeFalse(isWindows());
     // Deploy a jar to all servers
     gfshConnector.executeAndAssertThat("deploy --jar=" + 
jar1).statusIsSuccess();
     String resultString = gfshConnector.getGfshOutput();
@@ -227,6 +231,8 @@ public class DeployWithGroupsDUnitTest implements 
Serializable {
 
   @Test
   public void undeployJarFromAllServersWithRestart() throws Exception {
+    // TODO: Ignore on windows until GEODE-5787
+    assumeFalse(isWindows());
     // Deploy a jar to all servers
     gfshConnector.executeAndAssertThat("deploy --jar=" + 
jar1).statusIsSuccess();
     String resultString = gfshConnector.getGfshOutput();
@@ -239,7 +245,6 @@ public class DeployWithGroupsDUnitTest implements 
Serializable {
     server2.invoke(() -> assertThatCanLoad(jarName1, class1));
 
     gfshConnector.executeAndAssertThat("undeploy --jar=" + 
jar1.getName()).statusIsSuccess();
-    // Although the jar is undeployed, we can still access the class
     server1.invoke(() -> assertThatCannotLoad(jarName1, class1));
     server2.invoke(() -> assertThatCannotLoad(jarName1, class1));