This is an automated email from the ASF dual-hosted git repository.
dschneider pushed a change to branch feature/GEODE-5897
in repository https://gitbox.apache.org/repos/asf/geode.git.
from dc686ea GEODE-5501: Wait for listener to disconnect (#2583)
new eaa5bcf DataSourceFactory methods are no longer static to aid unit
testing
new 28e7f28 Verified the bug with new unit test. The problem was caused
by exception being caught, logged, and not rethrown. Now the gfsh function will
get the thrown exception and pass a failure back to gfsh. For backwards
compatibility, the XML parser still logs a warning if the jndi-binding can not
be created, instead of having it cause the cache not to start.
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../CreateJndiBindingCommandDUnitTest.java | 21 ++++++
.../datasource/AbstractPoolCacheJUnitTest.java | 4 +-
.../functions/DestroyJndiBindingFunctionTest.java | 2 +-
.../cli/functions/ListJndiBindingFunctionTest.java | 2 +-
.../internal/cache/xmlcache/CacheXmlParser.java | 12 ++-
.../internal/datasource/DataSourceFactory.java | 12 +--
.../apache/geode/internal/jndi/JNDIInvoker.java | 85 +++++++++++-----------
.../cli/functions/CreateJndiBindingFunction.java | 6 +-
.../GemFireBasicDataSourceJUnitTest.java | 6 +-
.../geode/internal/jndi/JNDIInvokerTest.java | 52 +++++++++++++
10 files changed, 142 insertions(+), 60 deletions(-)
create mode 100644
geode-core/src/test/java/org/apache/geode/internal/jndi/JNDIInvokerTest.java
