This is an automated email from the ASF dual-hosted git repository. wirebaron pushed a commit to branch GEODE-6233 in repository https://gitbox.apache.org/repos/asf/geode-benchmarks.git
commit d838b34034d20b08ab3730bd1e2f9288ea530170 Author: Helena Bales <[email protected]> AuthorDate: Fri Dec 21 13:37:12 2018 -0800 GEODE-6233: Use a new hash-map for each PutAll batch in PrePopulateRegion We see an occasional delay/hang when simply clearing and reusing the same hashmap for multiple putAll requests. This change creates a new hashmap every time it starts a new batch. This also increases the keyRange for the benchmarks from 10k to 1M. Co-Authored-By: Helena Bales <[email protected]> --- .../main/java/org/apache/geode/benchmark/tasks/PrePopulateRegion.java | 2 +- .../java/org/apache/geode/benchmark/tests/PartitionedGetBenchmark.java | 2 +- .../java/org/apache/geode/benchmark/tests/PartitionedPutBenchmark.java | 2 +- .../java/org/apache/geode/benchmark/tests/ReplicatedGetBenchmark.java | 2 +- .../java/org/apache/geode/benchmark/tests/ReplicatedPutBenchmark.java | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/geode-benchmarks/src/main/java/org/apache/geode/benchmark/tasks/PrePopulateRegion.java b/geode-benchmarks/src/main/java/org/apache/geode/benchmark/tasks/PrePopulateRegion.java index bae2237..a1be80d 100644 --- a/geode-benchmarks/src/main/java/org/apache/geode/benchmark/tasks/PrePopulateRegion.java +++ b/geode-benchmarks/src/main/java/org/apache/geode/benchmark/tasks/PrePopulateRegion.java @@ -131,7 +131,7 @@ public class PrePopulateRegion implements Task { if (putIndex % getBatchSize() == 0) { region.putAll(valueMap); - valueMap.clear(); + valueMap = new HashMap<>(); } } diff --git a/geode-benchmarks/src/main/java/org/apache/geode/benchmark/tests/PartitionedGetBenchmark.java b/geode-benchmarks/src/main/java/org/apache/geode/benchmark/tests/PartitionedGetBenchmark.java index cd9d9b8..f958f0f 100644 --- a/geode-benchmarks/src/main/java/org/apache/geode/benchmark/tests/PartitionedGetBenchmark.java +++ b/geode-benchmarks/src/main/java/org/apache/geode/benchmark/tests/PartitionedGetBenchmark.java @@ -37,7 +37,7 @@ import org.apache.geode.perftest.TestRunners; */ public class PartitionedGetBenchmark implements PerformanceTest { - private long keyRange = 10000; + private long keyRange = 1000000; @Test public void run() throws Exception { diff --git a/geode-benchmarks/src/main/java/org/apache/geode/benchmark/tests/PartitionedPutBenchmark.java b/geode-benchmarks/src/main/java/org/apache/geode/benchmark/tests/PartitionedPutBenchmark.java index 56fdd0e..3357a17 100644 --- a/geode-benchmarks/src/main/java/org/apache/geode/benchmark/tests/PartitionedPutBenchmark.java +++ b/geode-benchmarks/src/main/java/org/apache/geode/benchmark/tests/PartitionedPutBenchmark.java @@ -36,7 +36,7 @@ import org.apache.geode.perftest.TestRunners; */ public class PartitionedPutBenchmark implements PerformanceTest { - private long keyRange = 10000; + private long keyRange = 1000000; public PartitionedPutBenchmark() {} diff --git a/geode-benchmarks/src/main/java/org/apache/geode/benchmark/tests/ReplicatedGetBenchmark.java b/geode-benchmarks/src/main/java/org/apache/geode/benchmark/tests/ReplicatedGetBenchmark.java index e75b752..806c058 100644 --- a/geode-benchmarks/src/main/java/org/apache/geode/benchmark/tests/ReplicatedGetBenchmark.java +++ b/geode-benchmarks/src/main/java/org/apache/geode/benchmark/tests/ReplicatedGetBenchmark.java @@ -37,7 +37,7 @@ import org.apache.geode.perftest.TestRunners; */ public class ReplicatedGetBenchmark implements PerformanceTest { - private long keyRange = 10000; + private long keyRange = 1000000; @Test public void run() throws Exception { diff --git a/geode-benchmarks/src/main/java/org/apache/geode/benchmark/tests/ReplicatedPutBenchmark.java b/geode-benchmarks/src/main/java/org/apache/geode/benchmark/tests/ReplicatedPutBenchmark.java index cf6341a..40bc02f 100644 --- a/geode-benchmarks/src/main/java/org/apache/geode/benchmark/tests/ReplicatedPutBenchmark.java +++ b/geode-benchmarks/src/main/java/org/apache/geode/benchmark/tests/ReplicatedPutBenchmark.java @@ -36,7 +36,7 @@ import org.apache.geode.perftest.TestRunners; */ public class ReplicatedPutBenchmark implements PerformanceTest { - private long keyRange = 10000; + private long keyRange = 1000000; public ReplicatedPutBenchmark() {}
